when apply_olh_log() detects multiple instances with the same epoch, we
only promote the one that the bucket index lists as more current
Fixes: https://tracker.ceph.com/issues/39142
Signed-off-by: Casey Bodley <cbodley@redhat.com>
The ceph group usually won't exist; rotate as root.root.
(If we leave this off, logrotate complains about directory ownership
and permissions and doesn't do anything.)
Signed-off-by: Sage Weil <sage@redhat.com>
to support bidirectional replication, where each zone could create its
own instances with the same olh epoch, the sort order of those instances
should be used to determine whether an entry should be promoted over the
current instance
Fixes: https://tracker.ceph.com/issues/39142
Signed-off-by: Casey Bodley <cbodley@redhat.com>
These are unused since 1d29722f80 ("switch monc, daemons to use new
msgr2 auth frame exchange"). As they default to false, a confused user
might flip them to true and think that their client <-> OSD traffic is
encrypted.
The new set of options was added in c7ee66c3e5
("auth,msg/async/ProtocolV2: negotiate connection modes").
Fixes: https://tracker.ceph.com/issues/42976
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
before this change, the librados applications are responsible to call
`AioCompletion::release()` explicitly to release its internal pimpl
pointer. this is error prone and not intuitive.
after this change, the destructor of `AioCompletion` and
`PoolAsyncCompletion` will do this automatically. while
`AioCompletion::release()` and `PoolAsyncCompletion::release()` still
delete the instance as they did before. so this change is backward
compatible, as existing librados clients can still use `ptr->release()`
to free the completion instance, while new clients can just `delete
ptr`.
librados_test_stub is updated accordingly to match the new model
Signed-off-by: Kefu Chai <kchai@redhat.com>
* refs/pull/31788/head:
ceph-daemon: append newline before public key string
Reviewed-by: Thomas Bechtold <tbechtold@suse.com>
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
This reverts commit 669453138d, reversing
changes made to 36f5fcbb97.
Signed-off-by: Sage Weil <sage@redhat.com>
- conflicts due to code rearrangement in 14b0db908f
* refs/pull/31798/head:
ceph-daemon: ceph-volume works without an fsid
ceph-daemon: several commands that can infer fsids still require them
ceph-daemon: fix fsid inference
Reviewed-by: Michael Fritch <mfritch@suse.com>
Previously, incorrect parameters were being passed to "config rm",
causing it to do nothing. This commit also ensures the correct
error message is shown for both the set and remove failure cases.
I've also moved the update of the in-memory config map to *after*
the value is persisted, to ensure the config map actually reflects
what's stored.
Fixes: https://tracker.ceph.com/issues/42958
Signed-off-by: Tim Serong <tserong@suse.com>
Popen does not open a shell by default, so A FileNotFoundError is
raised instead of returning a 127 return code.
Signed-off-by: Jan Fajerski <jfajerski@suse.com>
‘struct icmp_hdr’ is defined in both IP.h and rte_icmp.h. DPDK.cc include
rte_ethdev.h that references rte_icmp.h, and include IP.h. It cause
redefinition of ‘struct icmp_hdr’ error. So move the definition of
‘struct icmp_hdr’ from IP.h to IP.cc.
Signed-off-by: Chunsong Feng <fengchunsong@huawei.com>
We are either 'hdd' or 'ssd' based on the rotational flag. Previously,
we would try to distinguish between an nvme vs SATA/SAS ssd and set the
class to 'nvme'. This was misguided--the interface is not important and
has no direct bearing on the device performance. Moreover, the HDD
manufacturers are planning to produce rotation HDDs that use the nvme
interface instead of SATA/SAS.
So, drop this.
This may be somewhat disruptive to clusters where we were detecting
nvme but now are not. However, the good news is that this doesn't seem
to trigger for real deployments because LVM breaks the is_nvme()
method.
Signed-off-by: Sage Weil <sage@redhat.com>
* refs/pull/31702/head:
ceph-daemon: infer fsid for shell, enter, ceph-volume, unit, logs
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
The mgr/ssh module has a command now to do this; use that instead of
generating the key ourselves and manually injecting it.
Signed-off-by: Sage Weil <sage@redhat.com>
MDS free heap space can grow to large for some workloads (like smallfile
and recursive deletes). This can cause the MDS mapped memory to grow
well beyond memory targets.
When we finally use the PriorityCache in the MDS, this will not be
necessary anymore as the PriorityCache already does this.
Fixes: https://tracker.ceph.com/issues/42938
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Set the mgr/ssh/mode option to ceph-daemon-package to switch to a mode
where we assume ceph-daemon is installed on the remote host and we can
ssh as user cephdaemon.
Signed-off-by: Sage Weil <sage@redhat.com>
