Sebastian Wagner
1f6b4744b5
qa: Upgrade to mypy 0.901
...
mypy 0.9 now requires stub packages
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
2021-06-09 12:53:21 +02:00
Sebastian Wagner
20e02db29e
mgr/rook: OSD create: Fix broken list-comprehension
...
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-06-09 12:39:58 +02:00
Sebastian Wagner
3fab28a55f
src,qa: Upgrade to mypy 0.812
...
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-06-09 12:39:58 +02:00
Kefu Chai
09f3c21f62
Merge pull request #41727 from yanqiang-ux/handle_error_ret_FillInVerifyExtent
...
osd: set r only if succeed in FillInVerifyExtent
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-06-09 17:03:05 +08:00
yanqiang-ux
127745161f
osd: set r only if succeed in FillInVerifyExtent
...
When read failed, ret can be taken as data len in FillInVerifyExtent, which should be avoided.
It may cause errors in crc repair or retry read because of the data len. In my case, we use FillInVerifyExtent for EC read,
when meet -EIO，we will try crc repair, which need read data from other shard accrding to data len.
And I meet assert in ECBackend.cc (loc: line 2288 ceph_assert(range.first != range.second) ), But it seems master branch not support EC crc repair.
In shot, when reuse the readop may cause unpredictable error.
Fixes: https://tracker.ceph.com/issues/51115
Signed-off-by: yanqiang-ux <yanqiang_ux@163.com>
2021-06-09 16:44:06 +08:00
Kefu Chai
13666263ab
Merge pull request #41718 from tchaikov/wip-doc-ci-deps
...
doc/dev: add continuous-integration
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2021-06-09 16:36:01 +08:00
Kefu Chai
3729788e97
doc/dev: add continuous-integration
...
for noting down the architecture of our CI. and how we prepare
some of the build dependencies.
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-06-09 16:23:44 +08:00
Ernesto Puerta
6465b9a254
Merge pull request #41123 from rhcs-dashboard/host-addr-and-labels
...
mgr/dashboard: Include Network address and labels on Host Creation form
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2021-06-09 10:23:34 +02:00
Ernesto Puerta
2f48f7d049
Merge pull request #41548 from rhcs-dashboard/revert-npm
...
Revert "mgr/dashboard: Generate NPM dependencies manifest"
Reviewed-by: Waad Alkhoury <walkhour@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2021-06-09 10:08:16 +02:00
J. Eric Ivancich
0b43e5f8ed
Merge pull request #38135 from joke-lee/fix-list-parts-show-id-and-displayname
...
rgw: RGWListMultipart show Owner ID and DisplayName
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2021-06-08 13:20:05 -04:00
J. Eric Ivancich
2b8f0b9684
Merge pull request #40975 from trociny/wip-50415
...
cls/rgw: look for plain entries in non-ascii plain namespace too
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
2021-06-08 13:19:33 -04:00
J. Eric Ivancich
28f644ddf5
Merge pull request #41065 from pponnuvel/tracker_50554
...
rgw: Improve error message on email id reuse
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
2021-06-08 13:19:16 -04:00
J. Eric Ivancich
be32908d57
Merge pull request #41678 from ivancich/wip-multipart-delete-marker
...
rgw: completion of multipart upload leaves delete marker
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Matt Benjamin mbenjamin@redhat.com
2021-06-08 13:18:25 -04:00
zdover23
29d4bd3ceb
Merge pull request #41760 from zdover23/wip-doc-2021-06-09-dev-guide-reposotory-spelling
...
doc/dev: s/reposotory/repository/ (really)
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-06-09 02:14:25 +10:00
Zac Dover
298b446c35
doc/dev: s/reposotory/repository/ (really)
...
This corrects the heinous misspelling described in the
substitution expression in the title. This misspelling is
all the more egregious because it appears in a title, and
therefore would be used to create links if it had not been
caught.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
2021-06-09 01:57:13 +10:00
Ernesto Puerta
90a78befc1
Merge pull request #41523 from rhcs-dashboard/fix-50955-master
...
mgr/dashboard: introduce separate front-end component for API docs
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2021-06-08 17:48:25 +02:00
Kefu Chai
c384b04ceb
Merge pull request #41703 from tchaikov/wip-options-mgr-mon
...
common/options: extract mgr and mon options out
Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-06-08 23:33:38 +08:00
Kefu Chai
04fa416472
Merge pull request #41444 from Daniel-Pivonka/cephadm-monitoring-ip-bind
...
mgr/cephadm: allow monitoring stack ip binding and custom ports
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Patrick Seidensal <pseidensal@suse.com>
Reviewed-by: Adam King <adking@redhat.com>
2021-06-08 23:32:24 +08:00
Kefu Chai
fb25fa722a
Merge pull request #41555 from mgfritch/cephadm-pytest-bootstrap
...
cephadm: add bootstrap unit tests
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
2021-06-08 23:30:47 +08:00
Kefu Chai
7bb4628e76
Merge pull request #41567 from ybwang0211/listxattr
...
doc: Added the explanation of the 'listxattr <obj-name>' and 'getxattr <obj-name> attr' commands
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-06-08 23:30:13 +08:00
Kefu Chai
a879aadd51
Merge pull request #41724 from tchaikov/wip-cmdparse-cleanup
...
common/cmdparse: do not create temp string unless necessary
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-06-08 23:29:27 +08:00
Ernesto Puerta
a9ea94f8f6
Merge pull request #41656 from rhcs-dashboard/49885-fix-bucket-object-lock-fields
...
mgr/dashboard: simplify object locking fields in 'Bucket Creation' form
Reviewed-by: Waad Alkhoury <walkhour@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2021-06-08 16:53:10 +02:00
Kefu Chai
cf4587e654
Merge pull request #41743 from tchaikov/wip-rgw-lua-exception
...
rgw/rgw_lua_utils: return error using luaL_error()
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
2021-06-08 21:33:50 +08:00
Kefu Chai
e2693727ac
Merge pull request #41689 from tchaikov/wip-vstart-restful
...
vstart.sh: disable restful by default
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2021-06-08 20:23:40 +08:00
Kefu Chai
873e3fc8dc
Merge pull request #41756 from rzarzynski/wip-crimson-monc-fix-races-in-on_session_opened
...
crimson/monc: fix races between on_session_opened() and the reset sequence
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-06-08 19:40:38 +08:00
Kefu Chai
52600606fa
Merge pull request #41747 from dengchl01/dengchl01-commit
...
mgr/mgr_module: update docstring of MgrModule.get()
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-06-08 19:11:35 +08:00
Radoslaw Zarzynski
b5f3dc4d9d
crimson/monc: fix races between on_session_opened() and the reset sequence.
...
The `active_con` can get invalidated every single time when there is
a preemption point. This includes even the middle connection open
sequence as it's spread across multiple continuations!
Unfortunately, we don't check for `active_con` in the lambdas inside
the `on_session_opened()` method. That was the reason of the following
crash at Sepia [1]:
```
INFO 2021-06-08 09:36:23,992 [shard 0] monc - do_auth_single: connection closed
/home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-4967-g96cdf983/rpm/el8/BUILD/ceph-17.0.0-4967-g96cdf983/src/crimson/mon/MonClient.cc:399:10: runtime error: member access within null pointer of type 'struct Connection'
Segmentation fault on shard 0.
Backtrace:
0# 0x000055C3C1CA860F in ceph-osd
1# FatalSignal::signaled(int, siginfo_t const*) in ceph-osd
2# FatalSignal::install_oneshot_signal_handler<11>()::{lambda(int, siginfo_t*, void*)#1}::_FUN(int, siginfo_t*, void*) in ceph-osd
3# 0x00007FAAE1713B20 in /lib64/libpthread.so.0
4# crimson::mon::Connection::get_conn() in ceph-osd
5# 0x000055C3C2532DA8 in ceph-osd
6# 0x000055C3C2535CB5 in ceph-osd
7# 0x000055C3BBC9FC70 in ceph-osd
8# 0x000055C3C76FAE5F in ceph-osd
9# 0x000055C3C77003A0 in ceph-osd
10# 0x000055C3C78B240B in ceph-osd
11# 0x000055C3C740FE8A in ceph-osd
12# 0x000055C3C7419FAE in ceph-osd
13# main in ceph-osd
14# __libc_start_main in /lib64/libc.so.6
15# _start in ceph-osd
Fault at location: 0x98
```
[1]: http://pulpito.front.sepia.ceph.com/rzarzynski-2021-06-08_09:11:05-rados-master-distro-basic-smithi/6159602
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-06-08 10:57:03 +00:00
dengchl01
ff15d24d4a
mgr/mgr_module: add docstring of MgrModule.get()-mgr_map,modified_config_options,service_map,mds_metadata,pg_status,osd_pool_stats,mgr_ips,have_local_config_map
...
Signed-off-by: dengchl01 <dengchl01@inspur.com>
2021-06-08 15:42:27 +08:00
Kefu Chai
a5fd875665
Merge pull request #41745 from tchaikov/wip-crimson-osd-cleanup
...
crimson/osd: do not capture unused variable
Reviewed-by: Samuel Just <sjust@redhat.com>
2021-06-08 13:57:03 +08:00
Kefu Chai
02f7a41f9c
crimson/osd: do not capture unused variable
...
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-06-08 13:12:41 +08:00
Kefu Chai
0182a11670
rgw/rgw_lua*: return unknown field error using luaL_error()
...
it's found on aarch64, the exception is not caught even if we do
catch exactly the same type of thrown exception, and the uncaught
exception ends up with a std::terminate() call. it could be the ABI
mismatch in aarch64, so the C++ runtime failed to find the catch block.
in this change, luaL_error() is used to populate the error to the
caller instead to workaround this issue.
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-06-08 12:44:43 +08:00
Kefu Chai
9b2e0b6ac2
rgw/rgw_lua_utils: return error using luaL_error()
...
it's found on aarch64, the exception is not caught even if we do
catch exactly the same type of thrown exception, and the uncaught
exception ends up with a std::terminate() call. it could be the ABI
mismatch in aarch64, so the C++ runtime failed to find the catch block.
in this change, luaL_error() is used to populate the error to the
caller instead to workaround this issue.
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-06-08 12:44:35 +08:00
Kefu Chai
7fc07dd728
Merge pull request #41742 from lmgdlmgd/master
...
mgr/mgr_module: correct docstring of MgrModule.get()
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-06-08 09:26:43 +08:00
Kefu Chai
ed4ef5a3dd
Merge pull request #41736 from rzarzynski/wip-crimson-alienstore-open_collection_dne
...
crimson/os/alienstore: open_collection() returns nullptr if DNE.
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-06-08 08:59:36 +08:00
Kefu Chai
191cd95211
Merge pull request #41730 from tchaikov/wip-fc35-python
...
do_cmake.sh: use python3.10 for fedora 35
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
2021-06-08 08:58:48 +08:00
靳登科
24ca308e10
mgr/mgr_module: correct docstring of MgrModule.get()
...
In annotation, one of param of Mgr_module.get() is "osd_crush_map_text", but in PyObject *ActivePyModules::get_python and selftest, the param is "osdmap_crush_map_text", so update annotation from "osd_crush_map_text" to "osdmap_crush_map_text"
Signed-off-by: lmgdlmgd <1105050771@qq.com>
2021-06-08 08:55:20 +08:00
Andrew Schoen
acaad279c7
Merge pull request #40659 from PepperJo/data_allocate_fraction_v2
...
ceph-volume,python-common: Data allocate fraction
Reviewed-by: Andrew Schoen <aschoen@redhat.com>
2021-06-07 14:06:52 -05:00
Radoslaw Zarzynski
04c0196b62
crimson/os/alienstore: open_collection() returns nullptr if DNE.
...
This is an AlienStore's counterpart of 9fbd60131b6b66c30b23
2021-06-07 16:47:47 +00:00
Kefu Chai
e13dbe94b3
Merge pull request #41733 from rzarzynski/wip-crimson-clientreq-cleanup
...
crimson/osd: clean up mutability and fix log in ClientRequest
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-06-07 23:24:46 +08:00
Radoslaw Zarzynski
fbb3b40807
crimson/osd: fix debug in ClientRequest::do_process().
...
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-06-07 14:30:48 +00:00
Radoslaw Zarzynski
7973ce3e19
crimson/osd: drop unneeded lambda mutability in ClientRequest.
...
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-06-07 14:30:48 +00:00
Kefu Chai
abca699b59
common/cmdparse: do not create temp string for writing ostream
...
ostream is able to handle std::string_view, so no need to create
temporary std::string instance for writing to a std::ostream
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-06-07 22:11:58 +08:00
Kefu Chai
0893d18b4d
common/cmdparse: do not create temp string for cmd_getval()
...
cmd_getval() consumes string_view, so no need to create a temporary
std::string instance for it.
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-06-07 22:11:58 +08:00
Sage Weil
3a2f0f0103
Merge PR #41709 into master
...
* refs/pull/41709/head:
cephadm: improve is_container_running()
Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-06-07 10:03:09 -04:00
Sage Weil
b18427da4b
Merge PR #41509 into master
...
* refs/pull/41509/head:
common/cmdparse: fix CephBool validation for tell commands
mgr/nfs: fix 'nfs export create' argument order
common/cmdparse: emit proper json
mon/MonCommands: add -- seperator to example
qa/tasks/cephfs/test_nfs: fix export create test
mgr: make mgr commands compat with pre-quincy mon
doc/_ext/ceph_commands: handle non-positional args in docs
mgr: fix reweight-by-utilization cephbool flag
mon/MonCommands: convert some CephChoices to CephBool
mgr/k8sevents: fix help strings
pybind/mgr/mgr_module: fix help desc formatting
mgr/orchestrator: clean up 'orch {daemon add,apply} rgw' args
mgr/orchestrator: add end_positional to a few methods
mgr/orchestrator: reformat a few methods
pybind/ceph_argparse: stop parsing when we run out of positional args
pybind/ceph_argparse: remove dead code
pybind/mgr/mgr_module: infer non-positional args
pybind/mgr/mgr_module: add separator for non-positional args
command/cmdparse: use -- to separate positional from non-positional args
pybind/ceph_argparse: adjust help text for non-positional args
pybind/ceph_argparse: track a 'positional' property on cli args
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-06-07 10:02:52 -04:00
Kefu Chai
fac4e1a9af
Merge pull request #41725 from tchaikov/wip-cmake-prom-warning
...
cmake: do not print warning in each cmake run
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-06-07 21:56:38 +08:00
Kefu Chai
106c3b8c68
Merge pull request #41728 from tchaikov/wip-cmake-win32-cleanup
...
cmake: let vstart-base depend on cython_rados if NOT WIN32
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-06-07 21:55:39 +08:00
Kefu Chai
78fa680bc2
Merge pull request #41704 from tchaikov/wip-ceph-daemon-ann
...
pybind/ceph_daemon: add missing type annotations
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
2021-06-07 21:46:49 +08:00
Kefu Chai
6095d1abf1
Merge pull request #41732 from rzarzynski/wip-crimson-opsequencer-prev_op-gt-last_unblocked
...
crimson/osd: fix assertion failure in OpSequencer on replay.
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-06-07 21:43:52 +08:00
Kefu Chai
f715d5b053
Merge pull request #41705 from tchaikov/wip-script-ceph-debug-docker
...
script/ceph-debug-docker: s/x86_64/$(arch)/
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-06-07 21:32:02 +08:00
