Partially format the 'Basic Workflow' section's introduction and 'Basic Functionalities' subsection in s3select. Nothing else is being fixed.
Signed-off-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
mgr/dashboard: expose more grafana configs in service form
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Remove mention of ceph-medic from doc/rados/operations/monitoring.rst,
because it is no longer supported.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Show the grafana_port and initial_admin_password in the form but disable
the password field in the edit option
Fixes: https://tracker.ceph.com/issues/58016
Signed-off-by: Nizamudeen A <nia@redhat.com>
tried to fix this issue from the daemon component sometime ago several
times but it didn't work. So force ignoring the error
Fixes: https://tracker.ceph.com/issues/59444
Signed-off-by: Nizamudeen A <nia@redhat.com>
librbd: on notify_quiesce() show attempts in a better format
Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: N Balachandran <nibalach@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
notify_quiesce() currently shows number of attempts in descending order,
this might be bit confusing to read.
Example: on the very first attempt,
2023-04-04T19:45:56.096+0530 7ff8ba7fc640 10 librbd::ImageWatcher:
0x7ff898008b30 notify_quiesce: async_request_id=[4151,140705343226832,23] attempts=10
I initially misread the above means 10 attempts where done.
This commit tries to pick the format that is used by
ImageWatcher<I>::handle_payload() and ImageWatcher<I>::notify_async_progress()
Fixes: https://tracker.ceph.com/issues/59379
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
qemu-utils is usually pre-installed but, due to what appears to be
a Ubuntu packaging bug, it's not upgraded when qemu-block-extra is
installed:
The following NEW packages will be installed:
qemu-block-extra
The following packages will be upgraded:
qemu-system-common qemu-system-data qemu-system-gui qemu-system-x86
However, the version of the block driver must match exactly the version
of the qemu-img tool, so the above leads to:
$ qemu-img convert -f qcow2 -O raw /home/ubuntu/cephtest/qemu/base.client.0.0.qcow2 rbd:rbd/client.0.0
Failed to initialize module: /usr/lib/x86_64-linux-gnu/qemu/block-rbd.so
Note: only modules from the same build can be loaded.
qemu: module block-block-rbd not found, do you want to install qemu-block-extra package?
qemu-img: Unknown protocol 'rbd'
Fixes: https://tracker.ceph.com/issues/59431
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
There are two types of snapshots that can be created on a snapshot based mirroring image - Normal Snapshot(same as journal based snapshot) and Nirror Image Snapshot. Till now Dashboard allowed only Mirror image snapshot, this PR intends to enable both the types
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
1e44d86b2 swapped this to a pg tell command which doesn't actually
need the primary specified. Drop the now unnecessary lookup.
Signed-off-by: Samuel Just <sjust@redhat.com>
As with on_info_history_change(), we don't need to deal with scrub
scheduling during peering. Once we've gone active, the scrubber itself
would be the origin of any stat changes that could affect scrub
scheduling. The other possible change vectors would be OSD config
changes or pool config changes.
PG::reschedule_scrub becomes PG::on_scrub_schedule_input_change. Should
be called in all cases where an input to scrub scheduling changes.
OSD::resched_all_scrubs() calls PG::on_scrub_schedule_input_change
unconditionally
now to deal with changes to osd_scrub_(min|max)_interval.
PG::set_last_[deep_]scrub_stamp now invoke
PG::on_scrub_schedule_input_change directly.
PG::handle_activate_map() now calls PG::on_scrub_schedule_input_change
directly to deal with changes to scrub related pool options.
Signed-off-by: Samuel Just <sjust@redhat.com>
The only usage of this method was to notify scrub that the pg history
has been updated during split or peering. That shouldn't be necessary.
Scrub does not schedule itself prior to activation, and we necessarily
must have an authoritative history by that point.
Signed-off-by: Samuel Just <sjust@redhat.com>
Separate and clarify handling of interval termination, pg activation,
and configuration change.
A primary PG now registers with its OSD for scrubbing only on
activation: on_pg_activate() called from PG::on_activate().
When the interval ends, the scrubber is notified via on_interval_change,
which is responsible for cleaning up any active or replica state
associated with scrub.
Configuration changes are still handled by update_scrub_job().
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
OpRequestRef::sent_epoch can be used to uniformly check incoming
messages against the current interval. Every caller should do it first
thing before any other processing.
Signed-off-by: Samuel Just <sjust@redhat.com>
Also removes misleading comment -- because primaries may
freely reset scrub, there may well be valid scrub state.
Signed-off-by: Samuel Just <sjust@redhat.com>
First, the is_stale() case should be impossible. This patch leaves an
error message rather than an assert.
Second, this patch removes the special handling for receiving a reservation
when m_remote_osd_resource is already populated. The next patch will exploit
the fact that all calls to m_remote_osd_resource.reset() and advance_token()
occur together.
Signed-off-by: Samuel Just <sjust@redhat.com>
