Commit Graph

91487 Commits

Author SHA1 Message Date
Sage Weil
1c081dde77 mgr/diskprediction: use global device_failure_prediction_mode setting
Signed-off-by: Sage Weil <sage@redhat.com>
2018-10-29 08:44:17 -05:00
Ricardo Dias
52dfb4072c
Merge pull request #24693 from idryomov/wip-is-queued
msg/async: fix is_queued() semantics

Reviewed-by: Ricardo Dias <rdias@suse.com>
2018-10-25 09:12:11 +01:00
Kefu Chai
ad63659f2d
Merge pull request #24739 from tspmelo/wip-py3-itervalues
ceph.in: Add support for python 3

Reviewed-by: Kefu Chai <kchai@redhat.com>
2018-10-25 10:50:54 +08:00
Kefu Chai
7a3bf10907
Merge pull request #23962 from aclamk/fio-fix-compilation
objectstore/test/fio: Fixed fio compilation when tcmalloc is used.

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2018-10-25 10:24:28 +08:00
Tiago Melo
c0817527cc ceph.in: Add support for python 3
This will allow the condition to work in both python 2 and 3 environments.

Signed-off-by: Tiago Melo <tmelo@suse.com>
2018-10-24 17:58:18 +01:00
Alfredo Deza
75eb578ae7
Merge pull request #24738 from alfredodeza/wip-rm36492
ceph-volume: do not send (lvm) stderr/stdout to the terminal, use the logfile

Reviewed-by: Andrew Schoen <aschoen@redhat.com>
2018-10-24 12:22:52 -04:00
Sage Weil
74fc2f3b28 Merge PR #24665 into master
* refs/pull/24665/head:
	common: remove unused ioprio thread/wq infrastructure

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: Jianpeng Ma <jianpeng.ma@intel.com>
2018-10-24 10:34:44 -05:00
Sage Weil
0638eb1aa4 Merge PR #24701 into master
* refs/pull/24701/head:
	os/bluestore: fix race between SharedBlobSet::lookup and SharedBlob::put

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
2018-10-24 10:34:29 -05:00
Sage Weil
82acec1835 Merge PR #24707 into master
* refs/pull/24707/head:
	build/ops: drop sgdisk build/runtime dependencies

Reviewed-by: Tim Serong <tserong@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Jan Fajerski <jfajerski@suse.com>
2018-10-24 10:34:08 -05:00
Sage Weil
2ff2a1a44e Merge PR #24687 into master
* refs/pull/24687/head:
	src/test: fix unordered manifest-unset op

Reviewed-by: Sage Weil <sage@redhat.com>
2018-10-24 10:31:15 -05:00
Alfredo Deza
6d6bcda75f ceph-volume tests.api update monkeypatching to use **kw
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2018-10-24 10:55:06 -04:00
Alfredo Deza
04e51c956e ceph-volume tests allow **kw when monkeypatching
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2018-10-24 10:54:48 -04:00
Alfredo Deza
581eed36ea ceph-volume api.lvm: do not spit out errors on the terminal from LVM
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2018-10-24 10:54:18 -04:00
Lenz Grimmer
fb1afdf76c
Merge pull request #24722 from zmc/rbd-redirect
mgr/dashboard: Redirect /block to /block/rbd

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2018-10-24 11:47:13 +02:00
Kefu Chai
86106ecb00
Merge pull request #19964 from runsisi/wip-build
cmake: move ceph-osdomap-tool, ceph-monstore-tool out of ceph-test

Reviewed-by: Kefu Chai <kchai@redhat.com>
2018-10-24 10:01:37 +08:00
Patrick Donnelly
f790de8e28
Merge PR #24540 into master
* refs/pull/24540/head:
	mgr/status: fix fs status subcommand did not show standby-replay MDS' perf info

Reviewed-by: John Spray <john.spray@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2018-10-23 15:32:55 -07:00
Patrick Donnelly
9c62710edd
Merge PR #24709 into master
* refs/pull/24709/head:
	PendingReleaseNotes: note about cephfs client state reclaim

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2018-10-23 15:24:09 -07:00
Patrick Donnelly
8c95f8e119
Merge PR #24466 into master
* refs/pull/24466/head:
	common: assert if buffer advance length overflow

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2018-10-23 15:02:26 -07:00
Patrick Donnelly
bc93a6173a
Merge PR #24529 into master
* refs/pull/24529/head:
	mds: cleanup command descriptions

Reviewed-by: Zheng Yan <zyan@redhat.com>
2018-10-23 15:01:53 -07:00
Patrick Donnelly
6d9f39b096
Merge PR #24640 into master
* refs/pull/24640/head:
	mds: remove MonClient reconnect

Reviewed-by: Sage Weil <sage@redhat.com>
2018-10-23 15:01:14 -07:00
Patrick Donnelly
60c63f71f6
Merge PR #24533 into master
* refs/pull/24533/head:
	qa: add timeouts for remote ops for client mounts

Reviewed-by: Zheng Yan <zyan@redhat.com>
2018-10-23 14:46:34 -07:00
Lenz Grimmer
f24b46ee4d
Merge pull request #24679 from tspmelo/wip-36528
mgr/dashboard: Fix HttpClient Module imports in unit tests

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
2018-10-23 23:23:18 +02:00
Lenz Grimmer
549e00286e
Merge pull request #24632 from Devp00l/wip-issue-36468
mgr/dashboard: Handle class objects as regular objects in KV-table

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2018-10-23 23:22:05 +02:00
Alfredo Deza
7ba945534f
Merge pull request #24674 from sileht/master
ceph-volume: extract flake8 config

Reviewed-by: Alfredo Deza <adeza@redhat.com>
2018-10-23 15:04:54 -05:00
Zack Cerza
57040391f5 mgr/dashboard: Redirect /block to /block/rbd
Fixes: https://tracker.ceph.com/issues/36401

Signed-off-by: Zack Cerza <zack@redhat.com>
2018-10-23 13:27:40 -06:00
Matt Benjamin
16dcd2ee6f
Merge pull request #23242 from linuxbox2/wip-rgw-inflight-ops
rgw: set default objecter_inflight_ops = 24576
2018-10-23 11:21:10 -04:00
Sage Weil
39304caf95 common: remove unused ioprio thread/wq infrastructure
This is all now obsolete, with no remaining users.

Move ceph_gettid into Thread.{cc,h}

Signed-off-by: Sage Weil <sage@redhat.com>
2018-10-23 08:29:02 -05:00
Kefu Chai
86af98f42d
Merge pull request #24692 from tchaikov/wip-cmake-with-asan
cmake: fixes to enable WITH_ASAN with clang and GCC

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2018-10-23 19:26:59 +08:00
Lenz Grimmer
966a1e9629
Merge pull request #24664 from tspmelo/wip-36513
mgr/dashboard: Fix missing failed restore notification

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
2018-10-23 12:59:06 +02:00
Lenz Grimmer
80dd99baa3
Merge pull request #24637 from ricardoasmarques/fix-rbd-actions-disable
mgr/dashboard: Fix RBD actions disable

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2018-10-23 12:35:53 +02:00
Lenz Grimmer
709e65e395
Merge pull request #24612 from Tinatinak/fix_bug24548
mgr/dashboard: Fixed documentation link on RGW page

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2018-10-23 12:28:57 +02:00
Tiago Melo
fba0097a8c mgr/dashboard: Fix HttpClient Module imports in unit tests
Some of the tests were importing the wrong HttpClient Module and that was
causing random errors.

Fixes: https://tracker.ceph.com/issues/36528

Signed-off-by: Tiago Melo <tmelo@suse.com>
2018-10-23 10:41:51 +01:00
Tiago Melo
2f4ce95725 mgr/dashboard: Fix missing failed restore notification
Fixes: http://tracker.ceph.com/issues/36513

Signed-off-by: Tiago Melo <tmelo@suse.com>
2018-10-23 10:34:03 +01:00
Lenz Grimmer
5727f9b455
Merge pull request #24544 from votdev/bug_24729
mgr/dashboard: Confirmation modal doesn't close

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
2018-10-23 08:50:14 +02:00
Lenz Grimmer
087958f329
Merge pull request #24699 from rhcs-dashboard/add-tslint-rule
mgr/dashboard: Add TSLint rule "no-unused-variable"

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2018-10-23 08:48:54 +02:00
Lenz Grimmer
3105e967f5
Merge pull request #24694 from tspmelo/wip-36544
mgr/dashboard: Fix problem with ErasureCodeProfileService

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
2018-10-23 08:47:55 +02:00
Mykola Golub
5dd0599bdf
Merge pull request #24696 from dillaman/wip-36542
qa/tasks/qemu: use unique clone directory to avoid race with workunit

Reviewed-by: Mykola Golub <mgolub@suse.com>
2018-10-23 09:41:43 +03:00
Nathan Cutler
7349218acb build/ops: drop sgdisk build/runtime dependencies
sgdisk was a dependency of ceph-disk, which has been ripped out.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
2018-10-23 07:56:13 +02:00
Sage Weil
a350131d16 Merge PR #24698 into master
* refs/pull/24698/head:
	Merge PR #24697 into nautilus
	ceph_test_msgr: fix authorizer behavior
	Merge pull request #24667 from liewegas/wip-ec-thrash-full
	Merge PR #24689 into nautilus
	qa/suites/rados/thrash-erasure-code*/thrashers/*: less likely resv rejection injection

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2018-10-22 22:46:23 -05:00
Kefu Chai
b0c8102cfb
Merge pull request #24691 from iridescent-rsy/fix_typo
common: fix typos in BackoffThrottle

Reviewed-by: Kefu Chai <kchai@redhat.com>
2018-10-23 10:56:13 +08:00
Sage Weil
a0b5445bc8 Merge PR #24697 into nautilus
* refs/pull/24697/head:
	ceph_test_msgr: fix authorizer behavior

Reviewed-by: Gregory Farnum <gfarnum@redhat.com>
2018-10-22 20:45:40 -05:00
Brad Hubbard
a20ba3dcf7
Merge pull request #24652 from badone/wip-undefined-gperftool-symbols-2
rpm: Use updated gperftools-libs at runtime

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Tim Serong <tserong@suse.com>
2018-10-23 09:37:35 +10:00
Sage Weil
020bd7b5f3 os/bluestore: fix race between SharedBlobSet::lookup and SharedBlob::put
A                             B
SharedBlobSet::lookup()
  takes lock
  nref is not 0
                              SharedBlob::put()
                                --nref
returns SharedBlobRef,
  ++nref
                                takes cache lock
                                SharedBlobSet::remove
                                  takes lock
                                  removes
                                deletes SharedBlob

-> A ends up with a ref to deleted SharedBlob

Fix by verifying that nref is still zero in SharedBlobSet::remove(),
while we are holding the SharedBlobSet::lock.  The lock ensures that we
have increased the ref for the lookup before entering remove, so we can
verify that nref is still zero before removing it.  If not, we have
raced, and put() bails out and does nothing.

Fixes: http://tracker.ceph.com/issues/36526
Signed-off-by: Sage Weil <sage@redhat.com>
2018-10-22 14:45:37 -05:00
alfonsomthd
85570639cb mgr/dashboard: Add TSLint rule
- TSlint no-unused-variable rule added.
- Cleanup: unused imports and variables.

Signed-off-by: Alfonso Martínez <almartin@redhat.com>
2018-10-22 19:38:38 +02:00
Lenz Grimmer
9d79acdaac
Merge pull request #24591 from tspmelo/wip-testing-module
mgr/dashboard: Unit Tests cleanup

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
2018-10-22 19:33:53 +02:00
Sage Weil
1a01cf4872 ceph_test_msgr: fix authorizer behavior
Fixes breakage from this PR 2152d8ffb7.

Fixes: http://tracker.ceph.com/issues/36495
Signed-off-by: Sage Weil <sage@redhat.com>
2018-10-22 10:06:06 -05:00
Kefu Chai
3d0d24a228 include/ceph_assert.h: do not pack assert params if WITH_ASAN
we pack the asset() params for smaller code size, but this creates a
inlined `assert_data_ctx` instance for every compilation unit which
call ceph_assert() defined in .h .

__PRETTY_FUNCTION__ is likely to be referenced by `assert_data_ctx`
sections which are included by different compiled object files. if the
ceph_assert() call is used by header file, then there will be multiple
`assert_data_ctx` sections sharing the same identifier. these sections are
defined as "COMDAT" group sections, i.e. common data sections. when linker
see multiple COMDAT sections with the same identifer, it will simply discard
the duplicated ones, and only keep a single copy of them. without enabling
ASan, GCC can always handle this problem just fine. but the dedup feature
does not work well with ASan. if ASan is enabled, and we link the objects
with the wrong order, some references will be pointing to the discarded
sections.

to address this issue, we could audit the link command line and inspect
all .o files to make sure they are properly ordered. but this is
non-trivial. as a workaround, in this change, the assert params are not
packed, and sent to the  __ceph_assert_fail() overrides which accepts
unpacked params directly, so the COMDAT section is not created.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-10-22 23:01:36 +08:00
Jason Dillaman
5d56014c61 qa/tasks/qemu: use unique clone directory to avoid race with workunit
If there is a workunit task associated with the same client, the two
tasks will attempt to clone the suite repo to the same directory.
Worse, if it's parallel tasks, the two clones will clobber each
other.

Fixes: http://tracker.ceph.com/issues/36542
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2018-10-22 10:44:40 -04:00
Josh Durgin
36ca230776
Merge pull request #24667 from liewegas/wip-ec-thrash-full
qa/suites/rados/thrash-erasure-code*/thrashers/*: less likely resv rejection injection

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2018-10-22 07:39:26 -07:00
Kefu Chai
4af71e7c00
Merge pull request #23103 from ifed01/wip-ifed-bluefs-migrate
os/bluestore: allow ceph-bluestore-tool to coalesce, add and migrate BlueFS backing volumes

Reviewed-by:  Sage Weil <sage@redhat.com>
2018-10-22 22:33:08 +08:00