Commit Graph

140561 Commits

Author SHA1 Message Date
Casey Bodley
c78168d188
Merge pull request #53691 from max-licc/radosgw_start_watcher_crash
rgw: fix unwatch crash at radosgw startup

Reviewed-by: Adam Emerson <aemerson@redhat.com>
2023-10-02 15:34:51 +01:00
Casey Bodley
100d81aa06
Merge pull request #53714 from cbodley/wip-63004
[CVE-2023-43040] rgw: Fix bucket validation against POST policies

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2023-10-02 15:34:25 +01:00
Adam King
0bca13c8bf
Merge pull request #53724 from adk3798/rm-get_unit_name_by_instance
cephadm: remove get_unit_name_by_instance func

Reviewed-by: John Mulligan <jmulligan@redhat.com>
2023-10-02 09:46:04 -04:00
Adam King
1bfcd77a17
Merge pull request #53715 from adk3798/other-haproxy-container-version
cephadm: fix haproxy version with certain containers

Reviewed-by: John Mulligan <jmulligan@redhat.com>
2023-10-02 09:41:38 -04:00
zdover23
e1ea0a18df
Merge pull request #53744 from zdover23/wip-doc-2023-10-02-architecture-16-of-x
doc/architecture: edit "Calculating PG IDs"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-10-02 23:01:54 +11:00
Ilya Dryomov
237aa221eb qa/suites/krbd: stress test for recovering from watch errors
Fixes: https://tracker.ceph.com/issues/63010
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2023-10-02 12:21:12 +02:00
Ronen Friedman
39e370099d
Merge pull request #53606 from Patty8122/control-reaches-end-fix
test: corrected control reaches end by adding a return

Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
2023-10-02 08:37:18 +03:00
Zac Dover
69a585fbf4 doc/architecture: edit "Calculating PG IDs"
Edit the section "Calcluating PG IDs" in doc/architecture.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-10-02 10:22:16 +10:00
Patty8122
346981a7c2 test: corrected control reaches end by adding a return
Signed-off-by: Patty8122 <divyapattisapu@uchicago.edu>
2023-10-01 18:09:40 -05:00
Ali Masarwa
51e9525bae
Merge pull request #53580 from AliMasarweh/wip-alimasa-persistent-q-migration
RGW | Bucket Notification: migrating old entries to support persistency control

Reviewed-by: yuvalif <ylifshit@redhat.com>
2023-10-01 16:38:40 +03:00
Yuri Weinstein
5b70a6b920
Merge pull request #46692 from pdvian/wip-unreachable-osd
osd: Report health error if OSD public address is not within subnet

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2023-10-01 05:59:26 -07:00
Yuri Weinstein
c9f29cc362
Merge pull request #52509 from ericqzhao/main
mgr: add throttle policy for DaemonServer

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2023-10-01 05:57:01 -07:00
zdover23
e427b9e3b1
Merge pull request #53740 from zdover23/wip-doc-2023-09-30-architecture-15-of-x
doc/architecture: edit several sections

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-10-01 22:50:24 +11:00
Adam King
b949914ca1
Merge pull request #53618 from adk3798/cephadm-refactor-more-net-utils
cephadm: move more funcs into net_utils.py

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
2023-09-30 18:41:29 -04:00
Zac Dover
9657c45fc1 doc/architecture: edit several sections
Edit the following sections in doc/architecture.rst:

 1. Dynamic Cluster Management
 2. About Pools
 3. Mapping PGs to OSDs

The tone of "Dynamic Cluster Management" remains a bit too close to the
tone of marketing material, in my opinion, but I will return to firm it
up when I have finished a once-over of architecture.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-10-01 08:25:34 +10:00
Adam King
1b1e91ea7b
Merge pull request #53702 from adk3798/cephadm-refactor-registry-login
cephadm: move registry_login to container_engines.py

Reviewed-by: John Mulligan <jmulligan@redhat.com>
2023-09-30 17:07:45 -04:00
Adam King
2367fabaea
Merge pull request #53617 from adk3798/cephadm-refactor-more-data-utils
cephadm: move more funcs into data_utils.py

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
2023-09-30 17:05:47 -04:00
Adam King
e2b54e39bd
Merge pull request #53612 from adk3798/fix-refreshed-column
mgr/cephadm: fix REFRESHED column of orch ps being unpopulated

Reviewed-by: Michael Fritch <mfritch@suse.com>
2023-09-30 16:59:42 -04:00
Adam King
91cbbaf799 cephadm: re-format black data_utils.py
Signed-off-by: Adam King <adking@redhat.com>
2023-09-30 15:28:44 -04:00
Adam King
915ac7d74f cephadm: move more funcs into data_utils.py
Signed-off-by: Adam King <adking@redhat.com>
2023-09-30 15:28:40 -04:00
Adam King
6306e5c316
Merge pull request #53682 from phlogistonjohn/jjm-cephadm-move-pathify
cephadm: move pathify & get_file_timestamp to file_utils

Reviewed-by: Adam King <adking@redhat.com>
2023-09-30 15:25:59 -04:00
Adam King
46e4c40b91
Merge pull request #53683 from phlogistonjohn/jjm-cephadm-move-getters
cephadm: move context getters

Reviewed-by: Adam King <adking@redhat.com>
2023-09-30 15:22:12 -04:00
zdover23
8f07179437
Merge pull request #53726 from zdover23/wip-doc-2023-09-29-architecture-14-of-x
doc/architecture: edit "Replication"

Reviewed-by: Cole Mitchell <cole.mitchell.ceph.@gmail.com>
2023-09-30 10:12:15 +10:00
Laura Flores
3deccad920
Merge pull request #53605 from sayantani11/osd-1
script/backport-resolve-issue: Update script with latest versions
2023-09-29 18:34:45 -04:00
mengxiangrui
f021b96302 rgw: fix rgw rate limiting RGWRateLimitInfo class decode_json max_read_bytes and max_write_bytes field mismatch
Fixes: https://tracker.ceph.com/issues/62955
Signed-off-by: xiangrui meng <mengxr@chinatelecom.cn>
2023-09-29 20:02:49 +08:00
zdover23
1d10b71792
Merge pull request #53723 from zdover23/wip-doc-2023-09-29-architecture-13-of-x
doc/architecture: edit "Data Scrubbing"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-09-29 16:02:14 +10:00
Zac Dover
4cf22e195a doc/architecture: edit "Replication"
Edit "Replication" in the "Smart Daemons Enable Hyperscale" section of
doc/architecture.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-09-29 15:30:14 +10:00
Zac Dover
d7b991646f doc/architecture: edit "Data Scrubbing"
Edit the "Data Scrubbing" listitem in the list of benefits conferred by
the use by OSDs of the aggregate power of the cluster, in the section
"Smart Daemons Enable Hyperscale" in doc/architecture.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-09-29 15:26:13 +10:00
Venky Shankar
6d8679ebcd Merge PR #53594 into main
* refs/pull/53594/head:
	qa: fix "no orch backend set" in nfs suite

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-09-29 10:01:17 +05:30
zdover23
8e5dda2493
Merge pull request #53707 from zdover23/wip-doc-2023-09-28-architecture-12-of-x
doc/architecture: edit "OSD Membership and Status"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-09-29 07:35:45 +10:00
Adam King
34fa171ff3 cephadm: remove get_unit_name_by_instance func
As it is one line, quite simple, and only
had a single caller, it was decided we'd remove
this function as part of the cephadm refactor.

Signed-off-by: Adam King <adking@redhat.com>
2023-09-28 14:39:53 -04:00
Zac Dover
dbd85336b1 doc/architecture: edit "OSD Membership and Status"
Edit "OSD Membership and Status" in the "Smart Daemons Enable
Hyperscale" section of doc/architecture.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-09-29 04:28:56 +10:00
Adam King
5540cd1882 cephadm: fix haproxy version with certain containers
Some builds of haproxy containers' output
from "haproxy -v" start with

HAProxy version

rather than

HA-Proxy version

no reason on our end not to accept both

Signed-off-by: Adam King <adking@redhat.com>
2023-09-28 11:07:21 -04:00
Joshua Baergen
98bfb71cb3 rgw: Fix bucket validation against POST policies
It's possible that user could provide a form part as a part of a POST
object upload that uses 'bucket' as a key; in this case, it was
overriding what was being set in the validation env (which is the real
bucket being modified). The result of this is that a user could actually
upload to any bucket accessible by the specified access key by matching
the bucket in the POST policy in said POST form part.

Fix this simply by setting the bucket to the correct value after the
POST form parts are processed, ignoring the form part above if
specified.

Fixes: https://tracker.ceph.com/issues/63004

Signed-off-by: Joshua Baergen <jbaergen@digitalocean.com>
2023-09-28 11:04:35 -04:00
Casey Bodley
2f5657011f
Merge pull request #53608 from cbodley/wip-62536
qa/rgw/sts: keycloak task installs java manually

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2023-09-28 15:37:20 +01:00
Matt Benjamin
c53f3bc319 rgw/file: make setattr(...) a no-op on buckets
Shallow fix for apparent unstable behavior after nfs "chown" on
an RGW bucket via RGW NFS.  While we allow buckets to be created
(and subject to ordinary rules, deleted), chown against a bucket
hasn't been tested and potentially is not valid.  Prevent it
altogether for now--if permissions would allow it, chown will
succeed but won't have any effect.

Fixes: https://tracker.ceph.com/issues/61689

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2023-09-28 09:55:25 -04:00
Ali Masarwa
60eb713084 RGW | Bucket Notification: migrating old entries to support persistency control
Signed-off-by: Ali Masarwa <ali.saed.masarwa@gmail.com>
2023-09-28 16:30:23 +03:00
Ilya Dryomov
2094a0450d qa/suites/krbd: rename singleton to singleton-msgr-failures
A "singleton without msgr-failures" is wanted in the next commit.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2023-09-28 12:06:11 +02:00
Liu-Chunmei
80bcefadf7
Merge pull request #53432 from liu-chunmei/seastore_device_size
crimson/vstart: default seastore_device_size will be out of space f…

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-09-27 20:11:47 -07:00
Adam King
08742e2e0e cephadm: re-format black container_engines.py
Signed-off-by: Adam King <adking@redhat.com>
2023-09-27 15:24:43 -04:00
Adam King
419288649f cephadm: move registry_login to container_engines.py
Signed-off-by: Adam King <adking@redhat.com>
2023-09-27 15:23:42 -04:00
Adam King
90322fb617 cephadm: move logging from registry_login to command_registry_login
So that registry_login can be moved to container_engines.py
without creating a dependency on logging there

Signed-off-by: Adam King <adking@redhat.com>
2023-09-27 15:23:42 -04:00
Casey Bodley
de55616429
Merge pull request #53607 from cfsnyder/wip-cfsnyder-bucket-check-bug
rgw: fix radosgw-admin bucket check stat calculation bug

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2023-09-27 18:38:42 +01:00
Yuval Lifshitz
935c513a14
Merge pull request #52393 from yuvalif/wip-yuval-enable-trace-lua
common/tracer: remove is_enabled check in add_span methods

reviewed-by: cbodley, ljflores
2023-09-27 18:07:28 +03:00
Nizamudeen A
219c62bea6 mgr/dashboard: allow tls 1.2 with a config option
Provide the option to allow tls1.2

`ceph dashboard set-enable-unsafe-tls-v1-2 True` followed with a mgr
restart will enable tls 1.2.

With tls1.2 enabled
```
╰─$ nmap -sV --script ssl-enum-ciphers -p 11000 127.0.0.1
Starting Nmap 7.93 ( https://nmap.org ) at 2023-09-27 16:56 IST
Nmap scan report for localhost (127.0.0.1)
Host is up (0.00018s latency).

PORT      STATE SERVICE  VERSION
11000/tcp open  ssl/http CherryPy wsgiserver
|_http-server-header: Ceph-Dashboard
| ssl-enum-ciphers:
|   TLSv1.2:
|     ciphers:
|       TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (ecdh_x25519) - A
|       TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256 (ecdh_x25519) - A
|       TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (ecdh_x25519) - A
|       TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256 (ecdh_x25519) - A
|       TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA (ecdh_x25519) - A
|       TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA (ecdh_x25519) - A
|       TLS_RSA_WITH_AES_256_GCM_SHA384 (rsa 2048) - A
|       TLS_RSA_WITH_AES_256_CCM (rsa 2048) - A
|       TLS_RSA_WITH_AES_128_GCM_SHA256 (rsa 2048) - A
|       TLS_RSA_WITH_AES_128_CCM (rsa 2048) - A
|       TLS_RSA_WITH_AES_256_CBC_SHA256 (rsa 2048) - A
|       TLS_RSA_WITH_AES_128_CBC_SHA256 (rsa 2048) - A
|       TLS_RSA_WITH_AES_256_CBC_SHA (rsa 2048) - A
|       TLS_RSA_WITH_AES_128_CBC_SHA (rsa 2048) - A
|     compressors:
|       NULL
|     cipher preference: server
|   TLSv1.3:
|     ciphers:
|       TLS_AKE_WITH_AES_256_GCM_SHA384 (ecdh_x25519) - A
|       TLS_AKE_WITH_CHACHA20_POLY1305_SHA256 (ecdh_x25519) - A
|       TLS_AKE_WITH_AES_128_GCM_SHA256 (ecdh_x25519) - A
|       TLS_AKE_WITH_AES_128_CCM_SHA256 (ecdh_x25519) - A
|     cipher preference: server
|_  least strength: A

Service detection performed. Please report any incorrect results at https://nmap.org/submit/ .
Nmap done: 1 IP address (1 host up) scanned in 16.55 seconds
```

Without tls1.2 enabled (which defaults to tls 1.3)
```
╰─$ nmap -sV --script ssl-enum-ciphers -p 11000 127.0.0.1
Starting Nmap 7.93 ( https://nmap.org ) at 2023-09-27 16:54 IST
Nmap scan report for localhost (127.0.0.1)
Host is up (0.000075s latency).

PORT      STATE SERVICE  VERSION
11000/tcp open  ssl/http CherryPy wsgiserver
| ssl-enum-ciphers:
|   TLSv1.3:
|     ciphers:
|       TLS_AKE_WITH_AES_256_GCM_SHA384 (ecdh_x25519) - A
|       TLS_AKE_WITH_CHACHA20_POLY1305_SHA256 (ecdh_x25519) - A
|       TLS_AKE_WITH_AES_128_GCM_SHA256 (ecdh_x25519) - A
|       TLS_AKE_WITH_AES_128_CCM_SHA256 (ecdh_x25519) - A
|     cipher preference: server
|_  least strength: A
|_http-server-header: Ceph-Dashboard
```

Fixes: https://tracker.ceph.com/issues/62940
Signed-off-by: Nizamudeen A <nia@redhat.com>
2023-09-27 17:25:30 +05:30
lichaochao
acd4348903 rgw: fix unwatch crash at radosgw startup
During radosgw initialization, if there is an exception in init_watch that causes the watcher registration to fail,
When finalize_watch is executed, a crash occurs due to unregister an unregistered watch.

Fixes: https://tracker.ceph.com/issues/60094

Signed-off-by: lichaochao <lichaochao2_yewu@cmss.chinamobile.com>
2023-09-27 12:06:41 +02:00
Nizamudeen A
fe8fa180d3 mgr/dashboard: fix cephfs form validator
Number is not allowed as the starting character of the mds service

Fixes: https://tracker.ceph.com/issues/63005
Signed-off-by: Nizamudeen A <nia@redhat.com>
2023-09-27 15:13:34 +05:30
Ilya Dryomov
73dd77f8e7
Merge pull request #53523 from rhcs-dashboard/add-ceph-daemon-label-labeled-counters
exporter: add ceph_daemon labels to labeled counters as well

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2023-09-27 09:27:04 +02:00
Nizamudeen A
3df6ce3071
Merge pull request #52828 from rhcs-dashboard/angular-15
mgr/dashboard: upgrade to angular v15

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2023-09-27 11:11:35 +05:30
Nizamudeen A
95d8f59938
Merge pull request #53596 from rhcs-dashboard/fix-validations-in-cephfs-forms
mgr/dashboard: fix cephfs forms validations

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
2023-09-27 10:43:14 +05:30