Commit Graph

141620 Commits

Author SHA1 Message Date
Nizamudeen A
122c6b2170
Merge pull request #54648 from rhcs-dashboard/fs-rename-fix
mgr/dashboard: fs rename only when fs is offline 

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: ivoalmeida <NOT@FOUND>
2023-12-01 18:21:49 +05:30
zdover23
a34821aaa4
Merge pull request #54731 from zdover23/wip-doc-2023-11-30-rados-tshooting-log-and-debug-note
doc/rados: improve formatting of log-and-debug.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-12-01 11:43:24 +01:00
zdover23
9a6c468bc3
Merge pull request #54730 from zdover23/wip-doc-2023-11-30-glossary-monitor-store
doc/glossary.rst: add "Monitor Store"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-12-01 10:44:41 +01:00
Zac Dover
e63fa697b7 doc/rados: improve formatting of log-and-debug.rst
Improve the arrangment of information in the section "Ceph Subsystems"
in doc/rados/troubleshooting/log-and-debug.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-12-01 10:35:42 +01:00
Ilya Dryomov
cb16d96e83
Merge pull request #54724 from ajarr/wip-63673
qa/workunits/rbd/cli_generic.sh: narrow race window

... when checking that rbd_support module command fails after blocklisting the module's client.

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2023-12-01 10:33:10 +01:00
Nizamudeen A
2c8faf256d mgr/dashboard: generalized code-block component
Fixes: https://tracker.ceph.com/issues/63608
Signed-off-by: Nizamudeen A <nia@redhat.com>
2023-12-01 13:49:48 +05:30
Matan Breizman
f26071f06d
Merge pull request #54304 from cyx1231st/wip-crimson-make-crosscore-send-ordered
crimson/osd: support to send messages concurrently with exclusive phases

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: chunmei-liu <chunmei.liu@intel.com>
2023-11-30 14:39:31 +02:00
Yuval Lifshitz
ae9fe18b47
Merge pull request #54697 from yuvalif/wip-yuval-63314
rgw/kafka/amqp: fix race conditionn in async completion handlers

reviewed-by: cbodley
2023-11-30 14:23:28 +02:00
Nizamudeen A
9bc2c79943
Merge pull request #54305 from rhcs-dashboard/add-tags
mgr/dashboard: add tags to edit bucket

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2023-11-30 14:37:29 +05:30
Nizamudeen A
a42e286fc0
Merge pull request #54355 from nobuto-m/info-rbd-stats-pools
mgr/dashboard: info on why RBD graphs are empty

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2023-11-30 13:38:54 +05:30
Zac Dover
35d168826f doc/glossary.rst: add "Monitor Store"
Add the term "Monitor Store" to the glossary.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-11-30 08:08:00 +01:00
Venky Shankar
6b1f123866 Merge PR #53431 into main
* refs/pull/53431/head:
	qa: add test cases to verify error reporting works as expected
	mgr: fix some doc strings in object_format.py
	mgr/tests: test returning error status works as expected
	mgr: make object_format's Responder class capable of responding err status
	mgr/nfs: report proper errno with err status

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-11-30 11:28:10 +05:30
Rishabh Dave
533ed43609
Merge pull request #54631 from rishabh-d-dave/mgr-vol-tests
qa/cephfs: improvements for name generators in test_volumes.py

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-11-30 10:47:42 +05:30
Casey Bodley
b41399bcbc
Merge pull request #50359 from adamemerson/wip-remove-rgwsi_rados
rgw: Remove `RGWSI_RADOS`

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2023-11-29 21:54:36 +00:00
Rishabh Dave
1febd1302a
Merge pull request #54616 from rishabh-d-dave/mgr-vol-improvements
mgr/vol: make some improvements

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-11-30 00:50:26 +05:30
Rishabh Dave
5d471c2712
Merge pull request #54308 from rishabh-d-dave/mgr-vol-flake-warnings
mgr/vol: fix flake8 warnings

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
2023-11-30 00:49:28 +05:30
Ramana Raja
ea033fe860 qa/workunits/rbd/cli_generic.sh: narrow race window
... when checking whether a rbd_support module command fails after
blocklisting the module's client.

In tests that check the recovery of the rbd_support module after its
client is blocklisted, the rbd_support module's client is
blocklisted using the `osd blocklist add` command. Next,
`osd blocklist ls` command is issued to confirm that the client is
blocklisted. A rbd_support module command is then issued and expected
to fail in order to verify that the blocklisting has affected the
rbd_support module's operations. Sometimes it was observed that before
this rbd_support module command reached the ceph-mgr, the rbd_support
module detected the blocklisting, recovered from it, and was able to
serve the command. To reduce the race window that occurs when trying to
verify that the rbd_support module's operation is affected by client
blocklisting, get rid of the `osd blocklist ls` command.

Fixes: https://tracker.ceph.com/issues/63673
Signed-off-by: Ramana Raja <rraja@redhat.com>
2023-11-29 13:49:06 -05:00
Adam King
f82d87980d
Merge pull request #54424 from phlogistonjohn/jjm-cephadm-daemon-to-container
cephadm: add a more generic daemon_to_container function

Reviewed-by: Adam King <adking@redhat.com>
2023-11-29 13:48:46 -05:00
Adam C. Emerson
0b7b233398 rgw: Remove RGWSI_RADOS
And remove the last places that reference it.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2023-11-29 13:15:27 -05:00
Adam C. Emerson
34b8e9fb22 rgw: Remove RGWSI_RADOS from RGWSI_SysObj*
Simply use the RADOS handle and `rgw_rados_ref` directly.

Also make `rgw::AccessListFilter` a std::function.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2023-11-29 13:15:27 -05:00
Adam C. Emerson
f2807f02b0 rgw: Remove RGWSI_RADOS from RGWSI_User_RADOS
Simply use the RADOS handle and `rgw_rados_ref` directly.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2023-11-29 13:15:27 -05:00
Adam C. Emerson
a992b36efb rgw: Remove RGWSI_RADOS from RGWSI_Zone_Tools
Simply use the RADOS handle directly.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2023-11-29 13:15:27 -05:00
Adam C. Emerson
5294d668d5 rgw: Remove RGWSI_RADOS from RGWSI_Zone
Simply use the RADOS handle directly.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2023-11-29 13:15:27 -05:00
Adam C. Emerson
897f4a9fce rgw: Remove RGWSI_RADOS from RGWSI_Notify
Simply use the RADOS handle directly.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2023-11-29 13:15:27 -05:00
Adam C. Emerson
a493b0710a rgw: Remove RGWSI_RADOS from RGWSI_MDLog
Simply use the RADOS handle and `rgw_rados_ref` directly.

Also move `async_processor` out from `RGWSI_RADOS` and into
`RGWServices_Def`. This is as good a place as it for any, for now, as
it's reachable by everyone who needs it and exists through the
lifetime of the process.

Eventually it's going to go away due to coroutinization, anyway.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2023-11-29 13:15:27 -05:00
Adam C. Emerson
e9c20c8123 rgw: Remove RGWSI_RADOS from RGWSI_ConfigKey_RADOS
Simply use the RADOS handle directly.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2023-11-29 13:15:27 -05:00
Adam C. Emerson
23120f7f8b rgw: Remove RGWSI_RADOS from RGWSI_Cls
Simply use the RADOS handle and `rgw_rados_ref` directly.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2023-11-29 13:15:27 -05:00
Adam C. Emerson
ac27d7a824 rgw: Remove RGWSI_RADOS from RGWSI_BI_RADOS
Simply use the RADOS handle and `rgw_rados_ref` directly.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2023-11-29 13:15:25 -05:00
Adam C. Emerson
750680b2d1 rgw: Distentangle rgw_rados_ref from RGWSI_RADOS
`RGWSI_RADOS` has no reason to exist. `rgw_rados_ref`, on the other
hand, is fairly useful. Move `rgw_rados_ref` to
`store/rados/rgw_tools.h` along with a function to create one.

Then clean up the fallout.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2023-11-29 12:57:59 -05:00
Casey Bodley
090e92a18d
Merge pull request #54619 from cbodley/wip-rgw-sal-get-stats-async
rgw/sal: clean up read_stats_async() callbacks

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2023-11-29 16:24:26 +00:00
Adam King
d58c7d0c08
Merge pull request #54582 from phlogistonjohn/jjm-cephadm-more-template-error
cephadm: add a custom template not found exception with diagnostic info

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
2023-11-29 10:55:54 -05:00
Rishabh Dave
ad96e91ee4 qa/cephfs: improvements for name generators in test_volumes.py
Generate a name that is shorter and easier to remember.

Also, write a simpler, faster & better helper method for generating
unique names. This method will also have shorter and more concise name,
so this will be easier to type and easier to read.

Fixes: https://tracker.ceph.com/issues/63680
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-11-29 21:15:29 +05:30
Casey Bodley
67ffb05d71
Merge pull request #54618 from alimaredia/wip-remove-vstart-runner-radosgw-admin-task
qa: remove vstart runner from radosgw_admin task

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2023-11-29 15:18:57 +00:00
Ronen Friedman
94e40c80f3
Merge pull request #54578 from ronen-fr/wip-rf-dedup-clang
tools: modify ceph_dedup_tool to maintain Clang 15 compatibility

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2023-11-29 15:39:37 +02:00
Venky Shankar
58e7e13214
Merge pull request #48483 from batrick/i48673
mds: revert standby-replay trimming changes

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-11-29 15:43:54 +05:30
Yuval Lifshitz
3e6d5273fc rgw/kafka/amqp: fix race conditionn in async completion handlers
Fixes: https://tracker.ceph.com/issues/63314

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
2023-11-29 09:34:37 +00:00
Matan Breizman
3d760f113b
Merge pull request #54287 from Matan-B/wip-matanb-crimson-do_osd_ops_execute-v3
crimson/osd: execute `submit_error_log` as an ExclusivePhase

Reviewed-by: Samuel Just <sjust@redhat.com>
2023-11-29 10:13:41 +02:00
Vallari Agrawal
b896bebf38
Merge pull request #54209 from VallariAg/wip-xml-scanner
qa: use Remote.run_unit_test and ValgrindScanner
2023-11-29 12:21:02 +05:30
zdover23
a0312323e6
Merge pull request #54685 from zdover23/wip-doc-2023-11-28-rados-tshooting-log-and-debug-small-repair
doc/rados: improve "Ceph Subsystems"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-11-29 05:39:10 +01:00
zdover23
ff796bfe73
Merge pull request #54684 from zdover23/wip-doc-2023-11-28-rados-ops-pgs-typo
doc/rados: ops/pgs: s/power of 2/power of two

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-11-29 05:34:43 +01:00
Zac Dover
7bca5f57cc doc/rados: improve "Ceph Subsystems"
Improve the English in the subsection "Ceph Subsystems" in the section
"Subsystem, Log and Debug Settings" [sic] in
doc/rados/troubleshooting/log-and-debug.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-11-29 03:01:53 +01:00
Zac Dover
ca81963321 doc/rados: ops/pgs: s/power of 2/power of two
Change "power of 2" to "power of two" in
doc/rados/operations/placement-groups.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-11-29 02:50:29 +01:00
Daniel Gryniewicz
785c1083fa
Merge pull request #51229 from jsoref/spelling-rgw
rgw: Fix spelling
2023-11-28 09:38:01 -05:00
Venky Shankar
b9b6c42eed
Merge pull request #53456 from petrutlucian94/dokan_case_insensitive
dokan: simple case insensitive emulation

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-11-28 19:28:20 +05:30
Rishabh Dave
060de1d354 mgr/vol: rectify variable name
Method "open_clone_subvolume_pair()" returns subvolumes, yet return
value is named as clone_volume. Rectify this mistake.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-11-28 14:04:26 +05:30
Ali Maredia
a44fd94b96 qa: remove vstart runner from radosgw_admin task
Fixes: https://tracker.ceph.com/issues/63583

Signed-off-by: Ali Maredia <amaredia@redhat.com>
2023-11-28 02:58:49 -05:00
Casey Bodley
1f34c2706d
Merge pull request #54621 from cbodley/wip-rgw-posix-warning
rgw/posix: fix unused variable warning

Reviewed-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2023-11-27 17:16:05 +00:00
Josh Soref
ed70d843df rgw: fix spelling errors
* access
* acquire
* across
* algorithm
* alternatively
* ambiguous
* attributes
* authenticated
* automatically
* based
* between
* beware
* bootstrap
* bucket
* cache
* character
* check
* cleanup
* combinations
* committed
* comparison
* compatibility
* concurrent
* conditions
* conjunction
* connections
* considered
* contains
* correct
* creates
* crypto
* dependencies
* dequeued
* dequeuing
* derivative
* described
* determine
* deterministic
* detritus
* discrepancy
* display
* either way
* elements
* entirely
* entries
* error
* everything
* expected
* explicitly
* extend
* false
* fclose
* feature
* following
* foreign
* format
* forward
* functionality
* functions
* generated
* getting
* gracefully
* happened
* hashicorp
* healthcheck
* hierarchy
* however
* http
* identify
* idleness
* ignored
* incremental
* information
* initialization
* length
* locally
* macros
* malformed
* means
* mechanism
* multipart
* multiple
* must
* namespace
* necessary
* nonexistent
* notifications
* occurred
* official
* outputs
* outputted
* overridden
* ownership
* parallelism
* partition
* passthrough
* pause
* penguin
* perform
* permission
* populated
* position
* preferably
* prefixes
* presumably
* previous
* print
* quadruple
* reference
* regardless
* registry
* renewed
* request
* requires
* reshard
* resource
* result to
* satisfy
* secret
* separate
* separator
* setting
* shouldn't
* skipping
* some
* somehow
* something
* specific
* struct
* succeeded
* success
* successful
* successfully
* syntax
* testing
* truncated
* unambiguously
* unittest
* unmodified
* unnecessary
* valid_action
* verifying
* versioning
* visible
* whatever
* whenever

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-11-27 10:27:32 -05:00
Josh Soref
82ec01e208 rgw: rewrite rgw_admin help text
* The line wrapping was fairly random.
* There were cases where words appeared to be doubled.
  - In fact one was an argument
  - the other was the start of the help text.

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-11-27 10:26:58 -05:00
Casey Bodley
f6bc1a8ef8
Merge pull request #54626 from cbodley/wip-cmake-rocksdb-uring
cmake/rocksdb: make sure dependencies build before rocksdb

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2023-11-27 14:20:31 +00:00