mgr/dashboard: Style guide to give a the UI an overall look and feel
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Sebastian Krah <skrah@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
When running ceph-volume simple activate command on a Filestore OSD
then the data device is mounted without any specific options so the
one from the ceph configuration file are ignored.
When deploying Filestore with the lvm subcommand then everything is
fine because the filestore_activate method uses mount_osd which relies
on the mount options defined in the ceph configuration file (if any).
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1891557
Fixes: https://tracker.ceph.com/issues/48018
Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
Prevent re-using the same AioCompletion between multiple
ImageDispatchSpec objects to prevent the possibility of a memory
leak.
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Tweak the format interface's 'read' call to just let the existing
read request continue passed the migration layer if the native
format is in use. Otherwise, the provided AioCompletion would need to
be wrapped with another AioCompletion to prevent the original
image dispatch spec from getting lost.
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
mgr/dashboard: Removing the black border on the text/input field when its clicked
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
monitoring: Use null yaxes min for OSD read latency
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Patrick Seidensal <pnawracay@suse.com>
The raw format maps an abstract, fully allocated, raw block device image
to the migration source IO API.
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
The file stream helper will translate byte-extent IO read requests
to ASIO file read requests on the specified backing file. This can be
layered with file format helpers to translate image IO extents down
to the backing file.
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
With the exception of the 'prepare' command, always attempt to open
the destination image first. This will better align with the
ability for read-only, non-native images to be used as a source
image.
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
* refs/pull/37776/head:
cephfs: Fix variable declartion in capture list in lambda
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
* refs/pull/37629/head:
qa/cephfs: add session_timeout option support
qa/cephfs: move the cephfs's opertions setting to create()
qa/cephfs: add 'cephfs:' section support
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
* refs/pull/37652/head:
qa/tasks: tear down the background process before unmounting
qa/tasks: switch to _kill_background() helper to terminate the daemons
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
This will help ensure that the source ImageCtx can be made optional
when migrating from a read-only, non-native image source.
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
When using advanced, non-legacy migration sources like a remote Ceph
cluster or a flat file, this API will return the JSON-encoded description
of the migration source.
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
The legacy migration source format has explicit pool, namespace, and image
parameters. This helper method will convert it into the JSON format that
will be used for the new-style migration source-spec.
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
mgr/dashboard: Adding more style to the notification sidebar
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
osd: Handle possible future work items returned from mclock scheduler.
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
/home/jenkins/workspace/ceph-master-compile/src/tools/cephfs_mirror/Mirror.cc:529:33: error: 'mirror_action' in capture list does not name a variable
m_cond.wait(locker, [this, &mirror_action] {return !mirror_action.action_in_progress;});
^
/home/jenkins/workspace/ceph-master-compile/src/tools/cephfs_mirror/Mirror.cc:529:57: error: reference to local binding 'mirror_action' declared in enclosing function 'cephfs:🪞:Mirror::run'
m_cond.wait(locker, [this, &mirror_action] {return !mirror_action.action_in_progress;});
^
/home/jenkins/workspace/ceph-master-compile/src/tools/cephfs_mirror/Mirror.cc:526:27: note: 'mirror_action' declared here
for (auto &[filesystem, mirror_action] : m_mirror_actions) {
^
/home/jenkins/workspace/ceph-master-compile/src/tools/cephfs_mirror/Mirror.cc:529:26: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
m_cond.wait(locker, [this, &mirror_action] {return !mirror_action.action_in_progress;});
^~~~
1 warning and 2 errors generated.
Tracker: https://tracker.ceph.com/issues/47973
Fixes: https://github.com/ceph/ceph/pull/37313
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
The code updates some attributes that may have changed between versions
when doing a lookup. However, a lookup can be done from within a
readdir callback, which causes a deadlock during the writeback. Extend
the flag indicating we're in a callback all the way down, so we can
conditionally avoid the write.
Fixes RHBZ#1845501
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
