Commit Graph

119625 Commits

Author SHA1 Message Date
Casey Bodley
05ef9e1ad9
Merge pull request #39450 from cbodley/wip-rgw-notify-double-dpp
rgw: remove duplicated ldout in rgw_notify.cc

Reviewed-by: Ali Maredia <amaredia@redhat.com>
2021-02-12 14:06:56 -05:00
Casey Bodley
f489f77dc7 rgw: remove duplicated ldout in rgw_notify.cc
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2021-02-12 11:32:09 -05:00
Sebastian Wagner
27a6c46f8a
Merge pull request #39373 from varshar16/wip-fix-rook-timezone-error
mgr/rook: Add timezone info

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: Travis Nielsen <tnielsen@redhat.com>
2021-02-12 13:58:33 +01:00
Ernesto Puerta
bd03c23fdb
Merge pull request #39362 from rhcs-dashboard/49216-delete-eof-read-pwd-from-file
mgr/dashboard: delete EOF when reading passwords from file

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: sebastian-philipp <swagner@suse.com>
2021-02-12 11:30:07 +01:00
zdover23
3b807c6f01
Merge pull request #39434 from zdover23/wip-doc-dev-about-suites-and-filters-rewrite-2021-Feb-12
doc/dev: rewrite "about suites and filters"

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2021-02-12 17:26:48 +10:00
Ramana Raja
324c672a56
Merge pull request #39327 from kotreshhr/qa-fix-mgr-vol-test-cases
qa: Fix a few mgr/volume test cases

Reviewed-by: Ramana Raja <rraja@redhat.com>
2021-02-11 23:59:22 -05:00
Jason Dillaman
7de81dd711
Merge pull request #39409 from trociny/wip-49245
librbd: don't log error if get mirror status fails due to mirroring disabled

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2021-02-11 22:51:34 -05:00
Sebastian Wagner
3016de8771
Merge pull request #38883 from sebastian-philipp/cephadm-keep-deleted-specs
mgr/cephadm: Purge deleted services

Reviewed-by: Adam King <adking@redhat.com>
2021-02-12 01:07:15 +01:00
Sebastian Wagner
ccb26e96f4
Merge pull request #39058 from sebastian-philipp/cephadm-use_repo_digest-default-true
mgr/cephadm: enable use_repo_digest by default for pacific

Reviewed-by: Sage Weil <sage@redhat.com>
2021-02-12 01:06:29 +01:00
Sebastian Wagner
0eee55d816
Merge pull request #39364 from mgfritch/cephadm-log-errs
cephadm: add error messages to log file

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: Varsha Rao <varao@redhat.com>
2021-02-12 01:06:07 +01:00
Zac Dover
3eaf27f01d doc/dev: rewrite "about suites and filters"
This improves the English in the section
"About Suites and Filters" in the new
Teuthology Guide in the Developer Guide.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2021-02-12 09:28:06 +10:00
Sage Weil
4819f209ed Merge PR #39404 into master
* refs/pull/39404/head:
	qa/suites/upgrade/octopus-x/stress-split: cephadm-based stress-split upgrade

Reviewed-by: Yuri Weinstein <yweins@redhat.com>
2021-02-11 17:10:44 -05:00
Jason Dillaman
d2b078ac64
Merge pull request #39375 from idryomov/wip-rbd-rm-exclusive
librbd: refuse to release exclusive lock when removing

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2021-02-11 14:32:08 -05:00
Jason Dillaman
ce310bf612
Merge pull request #39368 from MahatiC/wip-ssd-bug-fix
librbd/cache/pwl: Fix user request completion

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Xiaoyan Li <xiaoyan.li@intel.com>
2021-02-11 14:31:24 -05:00
Kotresh HR
4952d2132f qa: Fix a few mgr/volume test cases
Recovering dirty auth metadata file might not retain the order,
fixed the comparison in 'test_recover_auth_metadata_during_authorize'
and 'test_recover_auth_metadata_during_deauthorize'.

Fixes: https://tracker.ceph.com/issues/49192
Signed-off-by: Kotresh HR <khiremat@redhat.com>
2021-02-11 19:22:44 +05:30
Mykola Golub
1d303e6faa librbd: don't log error if get mirror status fails due to mirroring disabled
Fixes: https://tracker.ceph.com/issues/49245
Signed-off-by: Mykola Golub <mgolub@suse.com>
2021-02-11 09:24:49 +00:00
Samuel Just
498124f2bf
Merge pull request #39037 from liu-chunmei/seastore_collection
crimson/seastore: add collection implementation

Reviewed-by: Samuel Just <sjust@redhat.com>
2021-02-10 17:51:37 -08:00
Ken Dreyer
a153b1f2ed
Merge pull request #39398 from ktdreyer/cephadm-sys-fs-selinux
cephadm: make /sys/fs/selinux empty
2021-02-10 18:34:12 -07:00
Sage Weil
ec90e9b82c qa/suites/upgrade/octopus-x/stress-split: cephadm-based stress-split upgrade
Apply stress during upgrade, and also pause partway and do some
thrashing.

Signed-off-by: Sage Weil <sage@newdream.net>
2021-02-10 18:09:04 -06:00
Neha Ojha
2c26f2837e
Merge pull request #39384 from neha-ojha/wip-cephadm-compress
Revert "qa/tasks/cephadm: use cluster.sh and remote.sh for better readibility"

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
2021-02-10 15:17:27 -08:00
Mykola Golub
b4d9cc45d6
Merge pull request #39155 from dillaman/wip-49037
librbd: correct incremental deep-copy object-map inconsistencies

Reviewed-by: Mykola Golub <mgolub@suse.com>
2021-02-10 18:37:34 +02:00
Ken Dreyer
f0f96445b2 cephadm: make /sys/fs/selinux empty
When the following conditions are true:

  1) A host has selinux-policy-targeted,
  2) We mount the host's /sys into a privileged container,
  3) The container has SELINUXTYPE=targeted in /etc/selinux/config,
  4) The container does not have an selinux-policy-targeted package,

then SELinux-enabled applications like restorecon or DNF do not work inside
the container.

Resolve this by making /sys/fs/selinux an empty directory.

Fixes: https://tracker.ceph.com/issues/49239

Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
2021-02-10 08:25:10 -07:00
Ernesto Puerta
6c5ccc10b0
Merge pull request #38963 from rhcs-dashboard/refresh-crushmap
mgr/dashboard: Automatically refresh crush map metadata table

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2021-02-10 15:03:09 +01:00
Sebastian Wagner
d8fd08eebb
Merge pull request #39355 from sebastian-philipp/doc-install-rm-deepsea
doc/install: cephadm is the successor of DeepSea

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
2021-02-10 13:29:30 +01:00
Sebastian Wagner
ca41e2a559
Merge pull request #38505 from sebastian-philipp/doc-dev-cephadm-scalability-notes
doc/dev/cephadm: scalability notes

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
2021-02-10 13:17:00 +01:00
Venky Shankar
e40a9f4caf
Merge pull request #39287 from david-z/wip-fix-join-fscid
mon/MDSMonitor.cc: fix join fscid not applied with pending fsmap at boot
2021-02-10 17:30:14 +05:30
Jan Fajerski
40d5c37930 Merge PR #38318 into master
* refs/pull/38318/head:
	common: Add Windows ETW support

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-02-10 11:50:09 +01:00
chunmei-liu
4fdd451edd crimson/seastore: add collection manager implementation
Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
2021-02-09 22:48:37 -08:00
Kefu Chai
fe69a2abf4
Merge pull request #39387 from xxhdx1985126/wip-client-request-pg-ref
crimson/osd: capture pgref by value if it is to be referenced asynchronously

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-02-10 13:00:13 +08:00
Kefu Chai
2045b8322c
Merge pull request #39388 from ivzhh/master
cmake: don't pass ccache argument to RocksDB build

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-02-10 12:56:46 +08:00
Sheng Mao
59a5f333fa cmake: don't pass ccache argument to RocksDB build
RocksDB's cmake has a similar logic to turn on ccache as the main cmake.
Currently BuildRocksDB.cmake explicitly passes ccache to RocksDB cmake
arguments as CMAKE_CXX_COMPILER_LAUNCHER. This causes a compilation error
on ccache 4.0, especially in make -j mode.

ccache: error: Recursive invocation (the name of the ccache binary must
be "ccache")

This commit lets cmake from RocksDB decide RULE_LAUNCH_COMPILE by itself.

Signed-off-by: Sheng Mao <shngmao@gmail.com>
2021-02-09 20:17:53 -07:00
Xuehan Xu
affa3a6cce crimson/osd: capture pgref by value if it is to be referenced asynchronously
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2021-02-10 10:51:08 +08:00
zdover23
718af4faaf
Merge pull request #39351 from zdover23/wip-doc-dev-getting-binaries-rewrite-08-Feb-2021
doc/dev: rewrite "getting binaries" section

Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-02-10 12:00:15 +10:00
Brad Hubbard
6aa9528c17
Merge pull request #39383 from badone/wip-unmask-deep-scrub-stdout-lazy_omap_stats_test
test/lazy-omap-stats: Immediate deep-scrub output

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-02-10 11:37:17 +10:00
Samuel Just
3ccf7cb8ca
Merge pull request #39333 from cyx1231st/wip-seastore-onode-tree-empty-oid-ns
crimson/onode-staged-tree: support empty ns and oid

Reviewed-by: Samuel Just <sjust@redhat.com>
2021-02-09 15:39:13 -08:00
Neha Ojha
3ced450cdd Revert "qa/tasks/cephadm: use cluster.sh and remote.sh for better readibility"
This reverts commit 6d7ba1180e.

Fixes: https://tracker.ceph.com/issues/49228
Signed-off-by: Neha Ojha <nojha@redhat.com>
2021-02-09 22:15:37 +00:00
Brad Hubbard
3e79a035ee test/lazy-omap-stats: Immediate deep-scrub output
Show stdout from the child process as it happens.

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
2021-02-10 08:02:00 +10:00
Casey Bodley
7f72ff359e
Merge pull request #38871 from cbodley/wip-qa-rgw-valgrind-on
qa/rgw: reenable valgrind in rgw/verify suite

Reviewed-by: Ali Maredia <amaredia@redhat.com>
2021-02-09 16:22:42 -05:00
Zac Dover
cce1fc800d doc/dev: rewrite "getting binaries" section
This rewrites the "Getting Binaries" section
of the "Workflow" section of the "Tests:
Integration Tests" section of the Developer Guide.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2021-02-10 06:46:48 +10:00
Casey Bodley
a635e523be qa/rgw: test_rgw_reshard.py just tries common ports
the 'sudo netstat | grep radosgw' command is causing failures:

  File "qa/workunits/rgw/test_rgw_reshard.py", line 53, in get_radosgw_port
    x = out.decode('utf8').split(" ")
AttributeError: 'bool' object has no attribute 'decode'

because when valgrind is enabled, the process name is 'valgrind' instead
of 'radosgw'

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2021-02-09 14:26:26 -05:00
Casey Bodley
c706740dbe test/rgw: re-enable valgrind in rgw verify suite
this only enables it for radosgw itself, not the other daemons

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2021-02-09 14:26:19 -05:00
Casey Bodley
58e0da8fc9 qa/rgw: move valgrind config into valgrind.yaml
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2021-02-09 14:26:19 -05:00
Nizamudeen A
bc8562ef2a mgr/dashboard: Automatically refresh the crush map metadata table
If we make any change to the osd crush map like do an osd crush reweight from cli, for that change to be reflected on metadata table we need to reload the entire page. Instead this PR takes care of auto refreshing the tree view.

Fixes: https://tracker.ceph.com/issues/48922
Signed-off-by: Nizamudeen A <nia@redhat.com>
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
2021-02-09 23:51:07 +05:30
Michael Fritch
3e503d1487
cephadm: add error messages to log file
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-02-09 11:12:37 -07:00
Ilya Dryomov
b90ee634fa librbd: journal::StandardPolicy template defaults to ImageCtx
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2021-02-09 14:29:35 +01:00
Ilya Dryomov
b1bf3eaef2 librbd: don't hold owner_lock for validate_image_removal()
handle_exclusive_lock() and handle_shut_down_exclusive_lock() call
validate_image_removal() without owner_lock held, so holding it in
shut_down_exclusive_lock() appears to be redundant.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2021-02-09 14:29:35 +01:00
Ilya Dryomov
2f82c98f5a librbd: treat EROFS as expected in handle_acquire_lock()
If the peer refuses to release exclusive lock (e.g. in case automatic
exclusive lock transitions are disabled), EROFS is retured.  Suppress
a rather confusing "Read-only file system" error message -- this case
is no different from EBUSY or EAGAIN.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2021-02-09 14:29:35 +01:00
Ilya Dryomov
707907ea3f librbd: refuse to release exclusive lock when removing
Commit 25c2ffe145 ("librbd: acquire exclusive lock from peer when
removing") changed PreRemoveRequest to request exclusive lock from the
peer instead of giving up and proceeding without exclusive lock.  This
caused one of the test cases that sometimes runs concurrent "rbd rm"
against the same image to fail intermittently, most often on assert

  ceph_assert(image_ctx.exclusive_lock == nullptr ||
              image_ctx.exclusive_lock->is_lock_owner());

because exclusive lock is now automatically transitioned to another
"rbd rm" on its request.

The root cause is older and probably goes back to when synchronous
librbd::remove() which held owner_lock across all operations including
trim_image() was converted to a set of state machines.  Since then, any
peer that requests exclusive lock (instead of trying once and backing
off) is able to mess with image removal.

Install StandardPolicy to disable automatic exclusive lock transitions
during image removal.

Fixes: https://tracker.ceph.com/issues/49226
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2021-02-09 14:29:35 +01:00
Ilya Dryomov
948f3c761d librbd: templatize exclusive_lock::StandardPolicy
This will be used by expect_set_exclusive_lock_policy() in
test_mock_PreRemoveRequest.cc.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2021-02-09 14:29:22 +01:00
Casey Bodley
8d7cf601a2
Merge pull request #39211 from cbodley/wip-rgw-admin-formatter
radosgw-admin: fix leaks with make_unique()

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2021-02-09 07:31:05 -05:00