ansible-core started to include files whose filenames are encoded in
non-ascii characters, so we have to use a more capable encoding for the
locale in order to install this package. otherwise we'd have following
error:
Collecting ansible-core<2.12,>=2.11.3
Using cached ansible-core-2.11.4.tar.gz (6.8 MB)
ERROR: Exception:
Traceback (most recent call last):
File "/tmp/tmp.fX76ASIrch/venv/lib/python3.8/site-packages/pip/_internal/cli/base_command.py", line 173, in _main
status = self.run(options, args)
...
File "/tmp/tmp.fX76ASIrch/venv/lib/python3.8/site-packages/pip/_internal/utils/unpacking.py", line 226, in untar_file
with open(path, "wb") as destfp:
UnicodeEncodeError: 'latin-1' codec can't encode characters in position 137-140: ordinal not in range(256)
Signed-off-by: Kefu Chai <kchai@redhat.com>
crimson/seastore alloc extent hint
Replace L_ADDR_MIN by obj hash in onode, omap, object_data when alloc_extent.
Reviewed-by: Sam Just <sjust@redhat.com> and Cheng, Yingxin <yingxin.cheng@intel.com>
when download/building grafonnet-lib, dpdk, spdk, liburing and fio,
they dump lots of output during configuration and building phrases,
all of which is irrelevant to us. so let's just silence it.
Signed-off-by: Kefu Chai <kchai@redhat.com>
run-make-check: pass -Werror when compiling C++ code and a couple cleanups
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
to silence warnings like:
In file included from nvme_tcp.c:52:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/spdk/include/spdk_internal/nvme_tcp.h:369:17: warning: variable 'plen' set but not used [-Wunused-but-set-variable]
uint32_t hlen, plen;
^
Signed-off-by: Kefu Chai <kchai@redhat.com>
`len` is used to track the total length of received data, but we already
collect the data in `bl`, so we can always check `bl` for the total
length. this change also silences following warning from Clang:
../src/rgw/rgw_rest.cc:1477:21: warning: variable 'len' set but not used [-Wunused-but-set-variable]
int read_len = 0, len = 0;
^
1 warning generated.
Signed-off-by: Kefu Chai <kchai@redhat.com>
cct is defined so it can be used by dout(), but when the source code is
compiled for crimson, dout() does not use cct at all, so in that case,
compiler complains like:
../src/os/bluestore/BlueStore.cc:17413:8: warning: unused variable 'cct' [-Wunused-variable]
auto cct = onode->c->store->cct;
^
1 warning generated.
in this change, cct is marked with [[maybe_unused]] to silence this
warning.
Signed-off-by: Kefu Chai <kchai@redhat.com>
otherwise identity_type is a random number on stack. and there is good
chance that it does not match with the one decoded from the encoded
blob.
this change should address the failures like:
**** rgw_log_entry test 2 binary reencode check failed ****
ceph-dencoder type rgw_log_entry select_test 2 encode export /tmp/typ-O8hVYK2Gb
ceph-dencoder type rgw_log_entry select_test 2 encode decode encode export /tmp/typ-G09itHHIC
cmp /tmp/typ-O8hVYK2Gb /tmp/typ-G09itHHIC
The following tests FAILED:
132 - check-generated.sh (Failed)
..
Fixes: https://tracker.ceph.com/issues/52278
Signed-off-by: Kefu Chai <kchai@redhat.com>
these two tests are very chatty, just silence it. we can always re-enable the
logging, if something goes wrong with any of them.
Signed-off-by: Kefu Chai <kchai@redhat.com>
otherwise we have:
src/spdk/dpdk/lib/librte_eal/linux/eal.c:591:11: error: variable 'total_mem' set but not used [-Werror,-Wunused-but-set-variable]
uint64_t total_mem = 0;
^
1 error generated.
when building dpdk with Clang. dpdk passes -Werror to compiler, so
we have to disable this option.
Signed-off-by: Kefu Chai <kchai@redhat.com>
to pick up the clang build fix. we should use the upstream repo, once the
clang build fix gets merged.
bumping up the fio helps to address following error, as this part was rewritten:
src/test/fio/CMakeFiles/fio_ceph_objectstore.dir/fio_ceph_objectstore.cc.o.d -o src/test/fio/CMakeFiles/fio_ceph_objectstore.dir/fio_ceph_objectstore.cc.o -c ../src/test/fio/fio_ceph_objectstore.cc
In file included from ../src/test/fio/fio_ceph_objectstore.cc:26:
In file included from src/fio/fio.h:18:
In file included from src/fio/thread_options.h:6:
In file included from src/fio/options.h:8:
src/fio/parse.h:128:13: error: arithmetic on a pointer to void
return ret + offset;
~~~ ^
1 error generated.
Signed-off-by: Kefu Chai <kchai@redhat.com>
crimson/onode-staged-tree: force test to work with invalidated transactions
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
is_then() is failed to interrupt the continuation chain and cause
unit test failure. So add a workaround to make the test pass again.
Fixes: https://tracker.ceph.com/issues/52259
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
cmake: set CMAKE_BUILD_TYPE only if it is not specified
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Mark Nelson <mnelson@redhat.com>
so the identifiers in "std" namespace do not conflict the ones in C code
or the idenfitiers in other namespaces.
Signed-off-by: Kefu Chai <kchai@redhat.com>
* add "using" declarations in .cc files.
so we don't rely on "using namespace std" in one or more included
headers.
Signed-off-by: Kefu Chai <kchai@redhat.com>
* add "using" declarations in .cc files.
so we don't rely on "using namespace std" in one or more included
headers.
Signed-off-by: Kefu Chai <kchai@redhat.com>
* add "std::" prefix in headers
* add "using" declarations in .cc files.
so we don't rely on "using namespace std" in one or more included
headers.
Signed-off-by: Kefu Chai <kchai@redhat.com>
* add "std::" prefix in headers
* add "using" declarations in .cc files.
so we don't rely on "using namespace std" in one or more included
headers.
Signed-off-by: Kefu Chai <kchai@redhat.com>
* add "std::" prefix in headers
* add "using" declarations in .cc files.
so we don't rely on "using namespace std" in one or more included
headers.
Signed-off-by: Kefu Chai <kchai@redhat.com>
* add "std::" prefix in headers
* add "using" declarations in .cc files.
so we don't rely on "using namespace std" in one or more included
headers.
Signed-off-by: Kefu Chai <kchai@redhat.com>
* add "std::" prefix in headers
* add "using" declarations in .cc files.
so we don't rely on "using namespace std" in one or more included
headers.
Signed-off-by: Kefu Chai <kchai@redhat.com>
* add "std::" prefix in headers
* add "using" declarations in .cc files.
so we don't rely on "using namespace std" in one or more included
headers.
Signed-off-by: Kefu Chai <kchai@redhat.com>