Commit Graph

102268 Commits

Author SHA1 Message Date
Jason Dillaman
057547fadb
Merge pull request #30484 from trociny/wip-handle_start_replay_interrupted
rbd-mirror: potential nullptr dereference in ImageReplayer::handle_start_replay

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2019-09-20 07:55:00 -04:00
Lenz Grimmer
b2ca51a8bf
mgr/dashboard Adds multiple selection in osd table (#29662)
mgr/dashboard Adds multiple selection in osd table

Reviewed-by: Patrick Seidensal <pnawracay@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2019-09-20 09:21:28 +00:00
Mykola Golub
72076d3a0c
Merge pull request #30438 from dillaman/wip-41833
cls/rbd: sanitize entity instance messenger version type

Reviewed-by: Mykola Golub <mgolub@suse.com>
2019-09-20 11:59:27 +03:00
Mykola Golub
a01597b00f rbd-mirror: potential nullptr dereference in ImageReplayer::handle_start_replay
Signed-off-by: Mykola Golub <mgolub@suse.com>
2019-09-20 09:25:01 +01:00
Kefu Chai
a363dea882
Merge pull request #30474 from tchaikov/wip-discard-future
crimson: run in foreground if possible, silence warnings

Reviewed-by: Samuel Just <sjust@redhat.com>
2019-09-20 10:51:54 +08:00
Yuval Lifshitz
751c4514e0
Merge pull request #28971 from yuvalif/wip-yuval-pubsub-api2
rgw/pubsub: add S3 compliant API to master zone
2019-09-20 01:35:02 +03:00
Alfredo Deza
41e456a4d6
Merge pull request #30101 from rishabh-d-dave/cv-minor
ceph-volume: api/lvm: check if list of LVs is empty

Reviewed-by: Alfredo Deza <adeza@redhat.com>
Reviewed-by: Jan Fajerski <jfajerski@suse.com>
2019-09-19 15:10:49 -04:00
Casey Bodley
bd94272cd2
Merge pull request #19020 from zhangsw/feature-rgw-bucketsync-api
rgw: add admin rest api for bucket sync

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-09-19 14:33:47 -04:00
Casey Bodley
125ab97d88
Merge pull request #29637 from liuchang0812/rgw-es7
rgw: sync with elastic search v7

Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>
2019-09-19 14:24:47 -04:00
Casey Bodley
3993a72412
Merge pull request #29897 from tianshan/fix_list_start_with_null_marker
rgw: fix list versions starts with version_id=null

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-09-19 14:23:31 -04:00
Casey Bodley
30b3ecbcc6
Merge pull request #29909 from cbodley/wip-40935
rgw: fix default storage class for get_compression_type

Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>
2019-09-19 14:22:18 -04:00
Casey Bodley
d5d0d7fef3
Merge pull request #30127 from zhangsw/rgw-fix-adminuser
rgw: add missing admin property when sync user info.

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-09-19 14:21:37 -04:00
Casey Bodley
026eed47d2
Merge pull request #30163 from zhangsw/feature-rgw-opslog-transid
rgw: add transaction id to ops log.

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-09-19 14:20:50 -04:00
Casey Bodley
b087c4eacd
Merge pull request #30175 from tianshan/improve-data-sync-retry
rgw: improve data sync restart after failure

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-09-19 14:18:59 -04:00
Casey Bodley
20159f03e0
Merge pull request #30189 from linuxbox2/wip-rgw-ss3lite
rgw: crypt: permit RGW-AUTO/default with SSE-S3 headers

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-09-19 14:18:14 -04:00
Casey Bodley
2c82b290e9
Merge pull request #30194 from vumrao/wip-vumrao-41589
radosgw-admin: add --uid check in bucket list command

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
2019-09-19 14:17:35 -04:00
Casey Bodley
49d0395317
Merge pull request #30332 from linuxbox2/wip-ldap-denied
rgw: ldap auth: S3 auth failure should return InvalidAccessKeyId

Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>
2019-09-19 14:16:29 -04:00
Casey Bodley
c18db0c40b
Merge pull request #30384 from ZVampirEM77/bucket-create-time
rgw: add creation time information into bucket stats

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-09-19 14:15:33 -04:00
Abhishek L
89945b1bf3
Merge pull request #29680 from liuchang0812/s3-lock-bugfix
rgw: DefaultRetention requires either Days or Years

Reviewed-By: Casey Bodley <cbodley@redhat.com>
Reviewed-By: Abhishek Lekshmanan <abhishek@suse.com>
2019-09-19 19:41:00 +02:00
Venky Shankar
7cdad344b9
Merge pull request #30451 from ajarr/fix-41903
mgr/volumes: return string type to ceph-manager
2019-09-19 18:58:32 +05:30
Lenz Grimmer
bbb580e938
mgr/dashboard: Add smartctl data as an details tab of an OSD (#30324)
mgr/dashboard: Add smartctl data as an details tab of an OSD

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2019-09-19 12:48:51 +00:00
Samuel Just
c30fa85f1d crimson/osd: suppress warnings about unused future<> return values
These are dropped on purpose, suppress warnings.

Signed-off-by: Samuel Just <sjust@redhat.com>
2019-09-19 18:23:20 +08:00
Kefu Chai
e541750959 crimson/osd: ShardServices::send_pg_temp() returns future
it should not run in background unless necessary.

please note, we don't have a caller of this method yet.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-09-19 18:23:20 +08:00
Kefu Chai
1a8841cfe3 crimson/osd: evict object state in foreground
when doing error handling, we need to make sure the stale object state
is evicted before we return.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-09-19 18:23:20 +08:00
Kefu Chai
c345b593da crimson/osd: add_peer() in parallel
we should not add peers in background, and we can do this in parallel!

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-09-19 18:23:20 +08:00
Kefu Chai
6d5f5ed69c crimson/osd: Heartbeat::add_reporter_peers() returns future
the sole caller `Heartbeat::update_peers()` also returns future, so
there is no reason that `add_reporter_peers()` runs in background.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-09-19 18:23:20 +08:00
Kefu Chai
4aed49b626 crimson/osd: fix the order in OSD::update_heartbeat_peers()
before this chance, we do following things in background and in
parallel:

* add peers from pg map
* and peers from whole osdmap
* remove dead peers

but we should prioritize the peer candidates, apparently, the ones from
pgmap should have higher priority. as they are more likely to be used in
cluser and they are more important to current OSD, as they serve the
same set of PGs.

so we need to do these things in a proper order:

1. add peers from pg map
2. and peers from whole osdmap
3. remove dead peers

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-09-19 18:23:20 +08:00
Kefu Chai
b102c44291 crimson/osd/heartbeat: avoid racing when connecting to peer
before this change, we could initialize connections to newly added peers
in parallel repeatly, if an OSD is listed in up/acting of multiple PGs
served by current OSD.

after this change, we try to add the peer to `Heartbeat.peers` first,
and then try to connect to it with the hb front/back addresses, to avoid
potential repeatly connecting to peer.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-09-19 18:23:20 +08:00
Ricardo Dias
efe91beccf
Merge pull request #30270 from ricardoasmarques/wip-41727
mgr/dashboard: Check if `num_sessions` is available

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2019-09-19 11:08:48 +01:00
Venky Shankar
88aa0576a6 mgr/volumes: return string type to ceph-manager
The 'volumes' ceph-mgr module returns a byte type instead of a string
type as the stdout result of commands, `fs subvolume getpath` and
`fs subvolumegroup getpath` to the ceph-mgr. This causes the commands
to hang and the ceph-mgr to utilize 100% CPU. Fix the 'volumes'
ceph-mgr module to return string type to ceph-mgr as the stdout
result of the commands.

Introduced-by: 3d63cd947f
Fixes: https://tracker.ceph.com/issues/41903
Signed-off-by: Venky Shankar <vshankar@redhat.com>
2019-09-19 14:56:26 +05:30
Kefu Chai
b82fd0320d crimson/osd: do not cluster_msgr.set_myaddrs() in background
we should do the initialization in foreground

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-09-19 16:31:26 +08:00
Samuel Just
bb2bd5f42a crimson/net: avoid warning about signed comparison with enum classes
Signed-off-by: Samuel Just <sjust@redhat.com>
2019-09-19 15:16:23 +08:00
Kefu Chai
3d7e5b0e3f
Merge pull request #30410 from tchaikov/wip-debian-g++
debian/control: Build-Depends on g++

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Patrick Seidensal <pnawracay@suse.com>
2019-09-19 10:02:02 +08:00
Kefu Chai
e7287257ef
Merge pull request #30405 from p-se/wip-pna-ubuntu-disco-deps
install-deps.sh: add support for Ubuntu Disco Dingo

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-09-19 10:01:07 +08:00
Kefu Chai
51dd3740db
Merge pull request #30453 from tchaikov/wip-doc-crimson
doc/dev/crimson: transpose options of compare.py

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2019-09-19 09:22:19 +08:00
David Zafman
7ea365920b
Merge pull request #30440 from dzafman/wip-41900
Revert "common: default pg_autoscale_mode=on for new pools"

Reviewed-by: Sage Weil <sage@redhat.com>
2019-09-18 09:18:46 -07:00
Kefu Chai
3914de3fc6
Merge pull request #30458 from tchaikov/wip-crimson-cbt-test
test/crimson: lower the bar for cbt test

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2019-09-18 23:47:59 +08:00
Pooja
fb179b2dc1 mgr/dashboard Adds multiple selection to osd table
Fixes: https://tracker.ceph.com/issues/38091

Signed-off-by: Pooja <pooja.gautam@ts.fujitsu.com>
2019-09-18 17:43:13 +02:00
Kefu Chai
a6bf7671a9
Merge pull request #30433 from tchaikov/wip-crimson-pgls
crimson/osd: add pgls support

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2019-09-18 23:38:03 +08:00
Kefu Chai
c25a9d7233 crimson/osd: add pgls_filter support
it's modeled after pgnls_filter. and use seastar::map_reduce() for
filtering the objects into the response.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-09-18 22:59:18 +08:00
Kefu Chai
d7be213b8c crimson/osd: return hobject_t from pgls_filter()
so we can use it as the mapper function in seastar::map_reduce().

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-09-18 22:57:31 +08:00
Kefu Chai
b9e2c808c6 crimson/osd: add pgls support
Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-09-18 22:57:07 +08:00
Kefu Chai
eec27f5832 crimson/osd: handle pg ops with do_pg_ops()
currently, OpsExecuter tries to load the object info for all ops to be
executed, but the PG ops do not require the existence of object
specified by op. so we need to specialize for them.

in this change,

* `OpsExecuter::execute_pg_op()` is added to handle pg ops without
  loading object info first.
* `pgnls` and `pgnls_filter` are handled by
  `OpsExecuter::execute_pg_op()`.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-09-18 22:54:39 +08:00
Kefu Chai
05b88f644e crimson/osd/OpsExecuter: pass nspace in msg to do_pg_op()
as pg ops should not require the object info, as there is chance that
the object specified in pg ops does not exist at all.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-09-18 22:51:28 +08:00
Kefu Chai
a967e40198 crimson/osd/OpsExecuter: s/do_osd_op/execute_osd_op/
will add execute_pg_op() for performing pg specific ops, which do not
need the object state.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-09-18 22:51:28 +08:00
Kefu Chai
8bc359fef6 test/crimson: lower the bar for cbt test
sometimes we have

13:27:59 - WARNING  - cbt      -prefill/incerta08.front.sepia.ceph.com/0: iops_stddev: (or (less) (near 0.05)):: 13.0/9.53939  => rejected

i think it's acceptable

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-09-18 22:26:48 +08:00
Kefu Chai
044b7620e4 github: add "jenkins test crimson perf" to triggers doc
Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-09-18 22:24:04 +08:00
Jason Dillaman
c0c6b25d4f cls/rbd: sanitize entity instance messenger version type
The entity_addr_t::type field does not uniquely identify the connection
and might switch back and forth between LEGACY, V2, and ALL depending on
the client, the OSD, and the OSD map feature bits. Therefore, always
fix the entity address type to ANY prior to any comparisons.

Fixes: https://tracker.ceph.com/issues/41833
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-09-18 10:03:13 -04:00
Ilya Dryomov
d3c19d531d
Merge pull request #30452 from idryomov/wip-krbd-discard-direct
qa: avoid page cache for krbd discard round off tests

Reviewed-by: Dongsheng Yang <dongsheng.yang@easystack.cn>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2019-09-18 14:53:43 +02:00
Kefu Chai
14e73478b0
Merge pull request #30386 from tchaikov/wip-run_tox.sh-cleanup
script/run_tox.sh: remove unused code

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-09-18 20:11:23 +08:00