Fix invalid syntax where "linenos:" was printed in the
final rendered documentation instead of being used as
formatting syntax.
There is no need to use sudo for editing a source file
so run vim without sudo.
Change the whole block to use bash prompt since it is
a command.
Also modify the preceding text to hopefully not bold it.
Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
Always return std::nullopt rather than an empty buffer -- this way users
can rely on this as an invariant.
Signed-off-by: Samuel Just <sjust@redhat.com>
ceph.in: clarify the usage of `--format` in the ceph command
Reviewed-by: Vikhyat Umrao <vikhyat@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Adding new command to export free dump to binary format plus capability
to use new format for replay.
This dramatically increases large dump loading.
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
crimson: check -ENAMETOOLONG for Name, Locator, NameSpace
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
mgr/dashboard: RGW users and buckets tables are empty if the selected gateway is down
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
... and switch to using v1 addresses (if users haven't specified those
explicitly). kernel versions <5.11 do not understand `ms_mode' mount
option which would result in mount failure.
Fixes: http://tracker.ceph.com/issues/55110
Signed-off-by: Venky Shankar <vshankar@redhat.com>
It is redundant -- the only caller sets both since commit 6593e31fff
("librbd/cache/pwl: correct cache state").
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
When empty and/or clean bools are updated in I/O handling code paths,
ImageCacheState becomes inconistent for a short while: e.g. with clean
transitioned to true, dirty_bytes counter could still be positive
because the counters are updated only in periodic_stats(). Move to
updating the counters in update_image_cache_state(Context*) to avoid
this.
update_image_cache_state(Context*) now requires m_lock -- most call
sites already hold it anyway. The only problematic call site was
AbstractWriteLog::shut_down() callback chain: perf_stop() needed to
be moved to the very end since perf counters must be alive now for
update_image_cache_state() to work.
Don't override expect_op_work_queue() in unit tests: completing
context in the same thread now results in a deadlock on m_lock in
all test cases that call AbstractWriteLog::init().
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
get_json_format() and create_image_cache_state() attempt to get
particular keys which could result in an unhandled std::runtime_error
exception. Conversely, ImageCacheState constructor just swallows that
exception which could leave the newly constructed object incorrectly
initialized. Avoid doing parsing in the constructor and introduce
init_from_config() and init_from_metadata() methods instead.
While at it, move everything out from under "persistent_cache" key.
Also fix init_state_json_write test case which stopped working now
that types are enforced by json_spirit.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Add basic metrics to ImageCacheState and persist them, including
allocated_bytes, cached_bytes, dirty_bytes, free_bytes and hit/miss
info.
Leverage periodic_stats() timer to call update_image_cache_state.
In order to avoid outputting too much debug information, the original
statistics output log level is changed to 5.
Switch to json_spirit for encoding because encode_json encodes bool as
"true"/"false" string.
Remove rbd_persistent_cache_log_periodic_stats option because we need
to always update cache state.
[ idryomov: add cached_bytes and hits_partial; report misses and
miss_bytes instead of respective totals; naming ]
Fixes: https://tracker.ceph.com/issues/50614
Signed-off-by: Yin Congmin <congmin.yin@intel.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
