Commit Graph

119212 Commits

Author SHA1 Message Date
Ilya Dryomov
0357c0215b qa/tasks/rbd: dev_create() expects a properties dict
In order to add encryption_format property, commit 3754c665a1
(":qa/tasks/rbd: test qemu on top of rbd encryption") changed the
dev_create() contract.  It now expects a properties dict, but the
main task routine wasn't updated and still passes role_images.

On top of that, role_images itself got broken.  It is supposed
to be a mapping from role to a corresponding image name, not to
a dict with an image_name key.  This affected generic_mount().

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2021-02-01 17:05:47 +01:00
Sebastian Wagner
4203a7f93d
Merge pull request #39200 from mitsu-ko/mypatch
doc/mgr/orchestrator: Unify the content of command and yaml

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-02-01 13:22:50 +01:00
Kefu Chai
65285f8f08
Merge pull request #39201 from tchaikov/wip-sphinx-openapi
doc: silence warnings from openapi sphinx extension

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2021-02-01 20:15:23 +08:00
Kefu Chai
8a01bad75f
Merge pull request #39194 from tchaikov/wip-dashboard-enum
pybind/mgr/dashboard: do not install enum34

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2021-02-01 19:11:32 +08:00
Mitsumasa KONDO
53639c2b01 doc/mgr/orchestrator: Unify the content of command and yaml
Signed-off-by: Mitsumasa KONDO <kondo.mitsumasa@gmail.com>
2021-02-01 18:13:12 +08:00
Kefu Chai
1debd98565 doc: silence warnings from openapi sphinx extension
it prints out

skipping non-JSON example generation.

if an API does not contains example while ":example:" is specified for
openapi extension, and if this API is not a GET request, openapi
extention complains.

see also
9dbae9c9a6/sphinxcontrib/openapi/openapi30.py (L191)

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-02-01 17:57:57 +08:00
Sebastian Wagner
639fac3564
Merge pull request #39198 from tchaikov/wip-mypy.ini
mypy.ini: fix the unresolve conflict

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-02-01 09:48:04 +01:00
zdover23
e9a74d6951
Merge pull request #39196 from badone/wip-doc-python3-api
doc/rados/api: Update code samples to python3

Reviewed-by: Zac Dover <zac.dover@gmail.com>
2021-02-01 17:18:35 +10:00
Kefu Chai
0c926d26cd mypy.ini: fix the unresolved conflict
it was introduced by a0930a6310, i failed
to resolve this conflict when resolving the merge confliction.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-02-01 15:11:56 +08:00
Brad Hubbard
0060cc52f9 doc/rados/api: Update code samples to python3
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
2021-02-01 11:14:16 +10:00
Kefu Chai
d6c6669032
Merge pull request #39106 from mgfritch/cephadm-apt-get
cephadm: use `apt-get` for package install/update

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
2021-01-31 17:23:10 +08:00
Kefu Chai
15a53419ca
Merge pull request #39131 from sebastian-philipp/rook-disable-untyped
mgr/rook: disallow_untyped_defs = True

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Varsha Rao <varao@redhat.com>
2021-01-31 17:22:20 +08:00
Kefu Chai
9d0023ba90 pybind/mgr/dashboard: do not install enum34
enum was introduced by python 3.4, but we require python3.6 and up.
so drop it.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-31 12:04:23 +08:00
Sebastian Wagner
a3555a22c8 doc: add rook_client._helper to mock_imports
This is due to `mgr/rook` now also includes `._helper`

Co-authored-by Kefu Chai <kchai@redhat.com>

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-01-31 11:19:01 +08:00
Sebastian Wagner
a0930a6310 mgr/rook: disallow_untyped_defs = True
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-01-31 11:18:58 +08:00
Sebastian Wagner
ea51f6990c mgr/rook: Fix possibly infinite loop in _execute_blight_job
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-01-31 11:18:12 +08:00
Kefu Chai
79b91ea62d
Merge pull request #39143 from adk3798/ha-rgw-data-dir
cephadm: fix get_data_dir calls for ha-rgw daemons

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Daniel-Pivonka <dpivonka@redhat.com>
2021-01-31 10:34:46 +08:00
Kefu Chai
383af836d7
Merge pull request #39081 from ifed01/wip-ifed-perpg-instrumentation
os/bluestore: be more verbose when fsck detects stray per-pg omaps

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-01-31 10:31:13 +08:00
Kefu Chai
78cdd1e5a2
Merge pull request #39095 from tchaikov/wip-cephadm-fsid
cephadm: add fsid if --name is not specified

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-01-31 10:29:59 +08:00
Kefu Chai
461b384aeb
Merge pull request #39056 from sebastian-philipp/alerts-percent-d
mgr/alerts: interval can be None

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-01-31 10:28:54 +08:00
Kefu Chai
aca5ed1442
Merge pull request #38930 from vbashkirtsev/master
client/fuse_ll.cc: use uint64_t for fuse_ll_forget() nlookup argument

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-01-31 10:28:13 +08:00
Kefu Chai
510b0e067e
Merge pull request #39132 from rzarzynski/wip-blk-ptr_node-for-aio
blk: avoid temporary bptrs on aio paths; use ptr_node instead.

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2021-01-31 10:26:38 +08:00
Kefu Chai
11a8d4fbd5
Merge pull request #39151 from batrick/radosstriper-refactor
libradosstriper: make default layout const and static

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-01-31 10:25:46 +08:00
Kefu Chai
6527ec533c
Merge pull request #39116 from tchaikov/wip-crimson-pgstat
crimson/osd: keep a local copy of pg_stat and cleanups

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-01-31 10:24:36 +08:00
Kefu Chai
1e0f52a713
Merge pull request #39158 from tchaikov/wip-mgr-snap-stat-ann
pybind/mgr/{snap-schedule,status,iostat}: add type annotations

Reviewed-by: Sebastian Wagner <swagner@suse.com>
2021-01-31 10:17:54 +08:00
Kefu Chai
0b5d8e1928
Merge pull request #39187 from tchaikov/wip-standalone-mon-misc.sh
qa/standalone/mon/misc: verify that len(monmap.features.persistent) == 9

Reviewed-by: Sage Weil <sage@redhat.com>
2021-01-31 10:09:27 +08:00
Sage Weil
b2651236b9 Merge PR #39097 into master
* refs/pull/39097/head:
	qa/workunits/cephadm/test_cephadm: fix argument
	qa/workunits/cephadm/test_cephadm: show exporter output
	qa/workunits/cephadm/test_cephadm: don't bother pulling octopus
	qa/workunits/cephadm/test_cephadm: behave on terminal
	qa/workunits/cepham/test_cephadm: pull only recent images, from quay.ceph.io
	qa/workunits/cephadm/test_cephadm: don't respawn for python versions

Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
2021-01-30 10:14:43 -06:00
Sage Weil
b224ba3135 Merge PR #39172 into master
* refs/pull/39172/head:
	mgr/orchestrator: remove 'host' arg for 'orch ls'

Reviewed-by: Sebastian Wagner <swagner@suse.com>
2021-01-30 10:12:43 -06:00
Sage Weil
576a89fdaf Merge PR #39173 into master
* refs/pull/39173/head:
	mgr/devicehealth: make CLI commands error when pool doesn't exist
	mgr/devicehealth: only create pool when we have some osds

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sunny Kumar <sunkumar@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-01-30 10:09:48 -06:00
Kefu Chai
8dc097ff46 qa/standalone/mon/misc: verify that len(monmap.features.persistent) == 9
in beb62c029a, FEATURE_QUINCY was added to
ceph::features::mon::get_persistent(), so update the test accordingly.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-30 22:45:20 +08:00
Matt Benjamin
c26eaed15a
Merge pull request #38892 from ceph/update_s3select_add_zero_segment_log
s3select: update s3select submodule to last commit ; add zero segment log
2021-01-29 15:50:18 -05:00
Samuel Just
d972c3e1fe
Merge pull request #38767 from myoungwon/wip-manifest-chunk-scrub
osd: add has_manifest_chunk to count chunks in snapshot

Reviewed-by: Samuel Just <sjust@redhat.com>
2021-01-29 12:25:38 -08:00
Sage Weil
713f79fdf4 Merge PR #39039 into master
* refs/pull/39039/head:
	src/test/cli/monmaptool: adjust for new monmap features
	qa/tasks/cephadm: allow custom git_url for cephadm_branch pull
	qa/suites/rados/upgrade: include pacific-x
	qa/suites/upgrade/pacific-x/parallel
	qa/suites: some clean up for quincy
	mon: updates for quincy
	mon: update for quincy ondisk features
	script: add pacific
	doc/dev/release-checklist: we tagged v17.0.0
	ceph-volume: change to quincy
	include/ceph_features: retire MON_SINGLE_PAXOS
	include/ceph_features: define FEATURE_SERVER_QUINCY
	mon/MgrMonitor: add always_on_modules for quincy
	add feature/release name quincy
	kickoff v17 quincy
	doc/dev/release-checklists: uncheck everything!

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-01-29 14:01:26 -06:00
Sage Weil
8c625c077b qa/workunits/cephadm/test_cephadm: fix argument
Signed-off-by: Sage Weil <sage@newdream.net>
2021-01-29 13:34:44 -06:00
Sebastian Wagner
9c4df44fc5
Merge pull request #37144 from jmolmo/storage_devices_mgmt
doc: High level workflow for storage devices

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Jan Fajerski <jfajerski@suse.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
Reviewed-by: Zac Dover <zac.dover@gmail.com>
2021-01-29 19:16:54 +01:00
Sage Weil
e19e99a8a7 src/test/cli/monmaptool: adjust for new monmap features
Signed-off-by: Sage Weil <sage@newdream.net>
2021-01-29 11:45:11 -06:00
Sage Weil
5842058d12 qa/tasks/cephadm: allow custom git_url for cephadm_branch pull
Normally the git_url is git://git.ceph.com/ceph-ci.git, which mirrors
upstream ceph-ci.git.  However, the release branches aren't present there.
Allow a custom git_url so we can pull these from the main ceph.git.

Signed-off-by: Sage Weil <sage@newdream.net>
2021-01-29 11:45:02 -06:00
Sage Weil
db31d09efa mgr/devicehealth: make CLI commands error when pool doesn't exist
This is better than silently failing to do anything.

Signed-off-by: Sage Weil <sage@newdream.net>
2021-01-29 10:40:44 -06:00
Sage Weil
2abf4f1fc3 mgr/devicehealth: only create pool when we have some osds
If we create the pool before we have OSDs, the PGs won't be active+clean
and we'll raise a health warning that we shouldn't.  This will annoy
a new users deploying a new cluster, and (more importantly?) make
qa tests fail while deploying initial clusters due to the health
warning.

Signed-off-by: Sage Weil <sage@newdream.net>
2021-01-29 10:40:19 -06:00
Casey Bodley
09bdf42b0f
Merge pull request #39025 from yuvalif/wip-yuval-fix-48963
rgw: fix valgrind errors when protected_fixedsize_stack is used

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2021-01-29 11:01:14 -05:00
Sage Weil
38b3ca2a73 mgr/orchestrator: remove 'host' arg for 'orch ls'
The host arg is unused, and also missing from the documentation.

Signed-off-by: Sage Weil <sage@newdream.net>
2021-01-29 09:45:16 -06:00
Neha Ojha
07f7e3647e
Merge pull request #39152 from neha-ojha/wip-46323
qa/*/thrash_cache_writeback_proxy_none.yaml: disable writeback overlay tests

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2021-01-29 07:37:52 -08:00
Kefu Chai
1d6829f41c
Merge pull request #39118 from tchaikov/wip-cmake-rook-client
cmake: install rook-client-python using ExternalProject

Reviewed-by: Sebastian Wagner <swagner@suse.com>
2021-01-29 19:49:06 +08:00
Kefu Chai
b442a88d3d pybind/mgr/snap-schedule: silence flake8 warnings
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-29 19:42:32 +08:00
Kefu Chai
e9e4ae8378 pybind/mgr/snap-schedule: use use_fs if fs is not specified
the "vol_name" parameter of "fs subvolume getpath" command is not
optional, so we have to pass an fs name to it.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-29 19:42:32 +08:00
Kefu Chai
52d17e5852 pybind/mgr/snap-schedule: close a string with single quote
if it starts with single quote, we should close it with a single quote
also.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-29 19:42:32 +08:00
Kefu Chai
80cbf407c2 pybind/mgr/snap-schedule: add typing annotations
please note, the behavior of `updates_schedule_db()` is changed so that
it now returns the return value of the decorated function. this change
makes it a real decorator which keeps the signature of the decorated
function unchanged. the reason why we need this change is that mypy does
not allow us to match the parameter pack of a Callable at the time of
writing.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-29 19:42:32 +08:00
Kefu Chai
9d888ee42c pybind/mgr/status: flake8 cleanup
* remove unused import
* wrap long lines
* remove comments which do not start with "# "

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-29 19:42:32 +08:00
Kefu Chai
60bef081f8 pybind/mgr/status: add typing annotations
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-29 19:42:32 +08:00
Kefu Chai
6f68dea55c pybind/mgr/status: always map 'mds_version' to a list of dict
more consistent this way, as json format is supposed to be consumed by a
parser not human being.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-01-29 19:42:32 +08:00