This sort of awareness belongs at a higher level in the stack -- as
evidenced by nobody using the option at this level. Remove it from the
implementations and the interface
Signed-off-by: Greg Farnum <greg@inktank.com>
There's no particular reason why any of the callers of collection_getattrs
want to avoid looking at Ceph's internal xattrs.
It looks like this flag (set in 1862ddd885) was
set this way by mistake.
And finally, we don't actually set xattrs on collections anymore, anyway.
Signed-off-by: Greg Farnum <greg@inktank.com>
Previously we were not doing so, and that resulted in unpredictable loss
of xattrs from the client's perspective.
Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
Reviewed-by: Greg Farnum <greg@inktank.com>
Add xattr synthetic test to test ObjectStore xattr related interfaces.
Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
Reviewed-by: Greg Farnum <greg@inktank.com>
The const spg_t member is been insantiated from constructor
and now get_pgid() can reference this to return a spg_t instance
without the need of pg_info (thus not requiring to acquire pg_lock).
Signed-off-by: Somnath Roy <somnath.roy@sandisk.com>
Covers 1-node cluster issues, fewer OSDs than replicas, and
active + clean + inconsistent states in greater detail.
Signed-off-by: John Wilkins <john.wilkins@inktank.com>
The config option for sharded threadpool is changed to
osd_op_num_threads_per_shard instead of osd_op_num_sharded_pool_threads.
Along with osd_op_num_shards this will be much more user friendly while
configuring the number of op threads for the osd.
Signed-off-by: Somnath Roy <somnath.roy@sandisk.com>
If we are starting many daemons and hit an error, we normally note it and
move on. Do the same when doing the pre-mount step.
Fixes: #8554
Signed-off-by: Sage Weil <sage@inktank.com>
This includes tests for standard io and asynchronous io, similar to what is tested in the rados tests.
In addition, it includes in depth tests of the striping itself.
Signed-off-by: Sebastien Ponce <sebastien.ponce@cern.ch>
The user facing API is implemented in libradosstriper.cc and the backend in RadosStriperImpl.cc.
Details on how the code works are given in a comment at the top of RadosStriperImple.cc
Signed-off-by: Sebastien Ponce <sebastien.ponce@cern.ch>
No need to call ioctl(XFS_IOC_FSSETXATTR) if extsize is already set to
the value we want or if any extents are allocated - XFS will refuse to
change extsize in that's the case.
Fixes: #8241
Signed-off-by: Ilya Dryomov <ilya.dryomov@inktank.com>
Latest version of librados uses write_full when writing entire object.
Should the documentation mention that the method "write" used to serve
this function.
Signed-off-by: Kevin Dalley <kevin@kelphead.org>
This fixes
In file included from test/perf_counters.cc:19:0:
./common/perf_counters.h: In member function ‘std::pair PerfCounters::perf_counter_data_any_d::read_avg() const’:
warning: ./common/perf_counters.h:156:36: comparison between signed and unsigned integer expressions [-Wsign-compare]
} while (avgcount2.read() != count);
^
Signed-off-by: Sage Weil <sage@inktank.com>
In file included from test/objectstore/store_test.cc:33:0:
../src/gtest/include/gtest/gtest.h: In function ‘testing::AssertionResult testing::internal::CmpHelperNE(const char*, const char*, const T1&, const T2&) [with T1 = long unsigned int, T2 = int]’:
test/objectstore/store_test.cc:82:5: instantiated from here
warning: ../src/gtest/include/gtest/gtest.h:1379:1: comparison between signed and unsigned integer expressions [-Wsign-compare]
Signed-off-by: Sage Weil <sage@inktank.com>