Commit Graph

142337 Commits

Author SHA1 Message Date
Anthony D'Atri
1e3c8ed33a
Merge pull request #62444 from zdover23/wip-doc-2025-03-22-backport-62422-to-reef
reef: doc/cephadm/services: Add mention of --zap for OSD removal
2025-03-22 10:54:04 -04:00
Anthony D'Atri
9e462aa692 doc/cephadm/services: Add mention of --zap for OSD removal
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 20b621fceb)
2025-03-22 12:47:12 +10:00
SrinivasaBharathKanta
e893270566
Merge pull request #61653 from aclamk/wip-aclamk-pereman2-bluefs-expand-bug-reef
[reef] os/bluestore: fix _extend_log seq advance
2025-03-22 02:53:25 +05:30
Anthony D'Atri
6b27f2d375
Merge pull request #62428 from zdover23/wip-doc-2025-03-21-backport-62426-to-reef
reef: doc/cephadm/services: Correct indentation in osd.rst
2025-03-21 12:07:05 -04:00
SrinivasaBharathKanta
70e2c779b9
Merge pull request #60901 from mohit84/wip-69086-reef
reef: TEST_backfill_grow fails after finding "num_bytes mismatch" in osd log
2025-03-21 19:42:15 +05:30
SrinivasaBharathKanta
f70d108332
Merge pull request #57065 from batrick/wip-65623-reef
reef: mgr: process map before notifying clients
2025-03-21 19:41:49 +05:30
SrinivasaBharathKanta
83218bc9a6
Merge pull request #62212 from NitzanMordhai/wip-70379-reef
reef: LogMonitor: set no_reply for forward MLog commands
2025-03-21 19:36:59 +05:30
NitzanMordhai
55f682cc43
Merge pull request #62220 from ifed01/wip-ifed-limit-discard-qlen-reef
reef: blk/KernelDevice: Introduce a cap on the number of pending discards
2025-03-21 10:51:13 +02:00
Nitzan Mordechai
d4afcccf14 LogMonitor: set no_reply for forward MLog commands
On streach mod clusters we can see slow ops when
removing and adding osds with --zap --force when osds
connected to peon monitor and forwarding the MLog to leader.
the no_reply is set only when we are connected to the leader,
this fix will add also the other option - so no_reply set anyway.

Fixes: https://tracker.ceph.com/issues/54489
Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
(cherry picked from commit 56cb53db96)
2025-03-21 08:49:52 +00:00
NitzanMordhai
0405c32cfb
Merge pull request #62210 from NitzanMordhai/wip-70382-reef
reef: suites/rados: cache tier deprecated, no need to keep the tests for it
2025-03-21 10:42:06 +02:00
NitzanMordhai
c3737fdd77
Merge pull request #62145 from ifed01/wip-ifed-no-compression-plugin-reload-reef
reef: os/bluestore: do cache locally compressor engines ever used
2025-03-21 10:41:29 +02:00
Anthony D'Atri
0eaa1616bf doc/cephadm/services: Correct indentation in osd.rst
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 7b5f73f4c1)
2025-03-21 15:35:57 +10:00
Pere Diaz Bou
0210f57a5e os/bluestore: fix _extend_log seq advance
when extending the log, the sequence was left on a bad state because it would first create a transaction to update with the current seq number but leave the "real" transaction with the same sequence number which should be `extend_log_transaction.seq + 1`.

Signed-off-by: Pere Diaz Bou <pdiabou@redhat.com>
(cherry picked from commit 63f0a0df14)

Fixes: https://tracker.ceph.com/issues/69764
2025-03-20 15:04:19 +00:00
Pere Diaz Bou
e785ef2333 os/bluestore: test _extend_log sequence advance
Signed-off-by: Pere Diaz Bou <pdiabou@redhat.com>
(cherry picked from commit 8c68a503f1)
2025-03-20 15:04:19 +00:00
Zac Dover
db35d16e1a
Merge pull request #62405 from zdover23/wip-doc-2025-03-20-backport-62394-to-reef
reef: doc/radosgw /notifications: fix topic details

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2025-03-20 22:07:53 +10:00
Laimis Juzeliūnas
de37dfa9b5 doc/radosgw /notifications: fix topic details
This commit fixes documentation about many-to-many topic relationship for notifications. The current sentence states the same fact twice instead of clarifying.

Fixes: https://tracker.ceph.com/issues/64956
Signed-off-by: Laimis Juzeliunas <laimis.juzeliunas@oxylabs.io>
(cherry picked from commit 058b95abe6)
2025-03-20 11:30:15 +10:00
Adam King
5afba69ebc
Merge pull request #62339 from phlogistonjohn/wip-70506-reef
reef: build-with-container: two small fixes

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Dan Mick <dan.mick@redhat.com>
2025-03-19 14:05:41 -04:00
Anthony D'Atri
577b12186c
Merge pull request #62380 from zdover23/wip-doc-2025-03-19-backport-62367-to-reef
reef: doc/cephadm: Add PG autoscaler advice to upgrade.rst
2025-03-19 10:11:33 -04:00
Aashish Sharma
4a3b149652
Merge pull request #62354 from aaSharma14/wip-70523-reef
reef: mgr/dashboard: When configuring the RGW Multisite endpoints from the UI allow FQDN(Not only IP)

Reviewed-by: Naman Munet <naman.munet@ibm.com>
2025-03-19 12:47:41 +05:30
Anthony D'Atri
0ff712f981 doc/cephadm: Add PG autoscaler advice to upgrade.rst
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit ee69f52193)
2025-03-19 16:02:08 +10:00
Zac Dover
89508af597
Merge pull request #62376 from zdover23/wip-doc-2025-03-19-backport-62371-to-reef
reef: doc/dev/developer_guide/essentials: update mailing lists

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2025-03-19 15:30:50 +10:00
Laimis Juzeliūnas
dd4e17e49a doc/dev/developer_guide/essentials: update mailing lists
Update information for subscribing to Ceph development mailing lists as current documentation is outdated.

Fixes: https://tracker.ceph.com/issues/64580
Signed-off-by: Laimis Juzeliunas <laimis.juzeliunas@oxylabs.io>
(cherry picked from commit e7bf607269)
2025-03-19 14:49:32 +10:00
Laura Flores
2df3784f80
Merge pull request #62191 from ljflores/wip-reef-backport-69760 2025-03-18 22:13:30 -05:00
Laura Flores
899aae109d
Merge pull request #62369 from phlogistonjohn/jjm-reef-more-type-ignore 2025-03-18 21:32:07 -05:00
John Mulligan
e09ae8e252 reef: mgr/diskprediction_local: avoid more mypy errors
Similar to c411103317 this patch
suppresses mypy errors in the diskprediction_local mgr module.
I probably put the magic comment on more lines than needed but
mypy does not have a block-comment method to suppress checking
for just a region of code today.
This patch is not a backport as the issue is only impacting
reef CI jobs and so it is applied directly to the reef branch.

Signed-off-by: John Mulligan <phlogistonjohn@asynchrono.us>
2025-03-18 15:56:25 -04:00
John Mulligan
987e23829c script: ensure curl is always available in build containers
Ensure that curl is installed in all build containers regardless of
ceph's dependencies or other factors. This allows us to use curl in
any subsequent build steps/scripts.

Fixes: https://tracker.ceph.com/issues/70451
Signed-off-by: John Mulligan <jmulligan@redhat.com>
(cherry picked from commit b4e11f75bf)
2025-03-18 07:56:22 -04:00
Aashish Sharma
eafc85928f mgr/dashboard: When configuring the RGW Multisite endpoints from the UI allow FQDN(Not only IP)
When configuring the RGW Multisite endpoints from the UI allow FQDN, at the moment when using a FQDN it's not allowed

Fixes: https://tracker.ceph.com/issues/69055

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit 9f3619af9a)

Conflicts:
	src/pybind/mgr/dashboard/frontend/package-lock.json (conflicts
with typescript package version, kept the existing one)
	src/pybind/mgr/dashboard/frontend/package.json (conflicts with
typescript package version, kept the existing one)
	src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-multisite-migrate/rgw-multisite-migrate.component.ts (conflicts with automated system user creation in main)
	src/pybind/mgr/dashboard/frontend/src/app/shared/forms/cd-validators.ts (conflicts with oauthAddressTest validator)
2025-03-18 16:36:38 +05:30
Laura Flores
00043d2419 mon, osd: add command to remove invalid pg-upmap-primary entries
The current rm-pg-upmap-primary command checks that the pgid exists
in the pgmap before continuing to remove it. Due to https://tracker.ceph.com/issues/66867,
some invalid pg-upmap-primary entires may exist for pools that have been removed.
Currently, these mappings are impossible to remove since the pgids no longer
exist in the pgmap.

This new command, rm-pg-upmap-primary-all, allows users the ability to remove
any and all pg-upmap-primary mappings in the osdmap at once, which includes
valid and invalid entries.

This command may also be helpful when upgrading from versions where users
are plagued by https://tracker.ceph.com/issues/61948. Users may use an upgraded
mon to remove all pg-upmap-primray entries (valid and invalid) so they continue
to upgrade to a safe version.

See manual testing for this patch here: https://tracker.ceph.com/issues/67179#note-12

Fixes: https://tracker.ceph.com/issues/67179
Fixes: https://tracker.ceph.com/issues/69760
Signed-off-by: Laura Flores <lflores@ibm.com>
(cherry picked from commit 6e9e2033bf)

Conflicts:
	src/osd/OSDMap.cc
	src/osd/OSDMap.h
The `rm_all_upmap_prims` per pool function is part of
2953db8b58, which
is related to the "size optimized" read balancer feature that
is only included >= Squid.
2025-03-17 17:34:52 -05:00
John Mulligan
e15a5f873d script/build-with-container: fix incorrect build invocation for tests
The `tests` build target was set to build the "normal" target but it
needs to build the tests.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
(cherry picked from commit 6b635d3ec0)
2025-03-17 10:50:17 -04:00
Aashish Sharma
41ff2bdacd
Merge pull request #62087 from aaSharma14/wip-70252-reef
reef: mgr: fix subuser creation via dashboard

Reviewed-by: Nizamudeen A <nia@redhat.com>
2025-03-17 11:22:29 +05:30
Zac Dover
7f91f1e933
Merge pull request #62321 from zdover23/wip-doc-2025-03-15-backport-62319-to-reef
reef: doc/rados/troubleshooting: Improve troubleshooting-pg.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2025-03-15 13:23:53 +10:00
Anthony D'Atri
9ebc3a0c15 doc/rados/troubleshooting: Improve troubleshooting-pg.rst
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 56a21cbc03)
2025-03-15 12:57:45 +10:00
Anthony D'Atri
ad78e0a9da
Merge pull request #62318 from zdover23/wip-doc-2025-03-15-backport-62316-to-reef
reef: doc/rados/operations: improve crush-map-edits.rst
2025-03-14 22:47:09 -04:00
Anthony D'Atri
2c10e50df6 doc/rados/operations: improve crush-map-edits.rst
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 59a894713a)
2025-03-15 12:23:52 +10:00
Yuri Weinstein
5ea1c5072e
Merge pull request #62218 from idryomov/wip-66419-reef
reef: qa/workunits/rbd: wait for resize to be applied in rbd-nbd

Reviewed-by: Ramana Raja <rraja@redhat.com>
2025-03-14 13:23:42 -07:00
Laura Flores
476b47e6fc
Merge pull request #60615 from YiteGu/wip-68792-reef
reef: blk/KernelDevice: using join() to wait thread end is more safe
2025-03-14 15:20:25 -05:00
Anthony D'Atri
1d08f2afa2
Merge pull request #62298 from zdover23/wip-doc-2025-03-14-backport-62119-to-reef
reef: doc: fixup #58689 - document SSE-C iam condition key
2025-03-14 08:18:45 -04:00
dawg
5c7f8f28d5 doc: fixup #58689 - document SSE-C iam condition key
Signed-off-by: dawg <code@dawg.eu>

(cherry picked from commit 7b4ac88662)
2025-03-14 17:09:49 +10:00
Anthony D'Atri
c95c527527
Merge pull request #62266 from zdover23/wip-doc-2025-03-13-backport-62249-to-reef
reef: doc/monitoring: Improve index.rst
2025-03-13 08:08:13 -04:00
afreen23
7e3bc10c1d
Merge pull request #59697 from rhcs-dashboard/wip-67928-reef
reef: qa/mgr/dashboard: fix test race condition  

Reviewed-by: Afreen Misbah <afreen@ibm.com>
2025-03-13 16:09:23 +05:30
Hannes Baum
2036e87b91 mgr: fix subuser creation via dashboard
Subusers couldn't be created through the dashboard, because the get call was overwritten with Python magic due to it being the function under the HTTP call.
The get function was therefore split into an "external" and "internal" function, whereas one
can be used by functions without triggering the magic. Since the user object was then returned correctly, json.loads could be removed.

Signed-off-by: Hannes Baum <hannes.baum@cloudandheat.com>
(cherry picked from commit 90e221d0b5)
2025-03-13 14:09:22 +05:30
Nizamudeen A
2e1544e6be qa/tests: retry the api call after making the request
based on the pointer from Bill in https://tracker.ceph.com/issues/62972#note-75

Fixes: https://tracker.ceph.com/issues/62972
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 1588712b55)
2025-03-13 11:31:10 +05:30
Nizamudeen A
5cc7fc6806 qa/dashboard: fix test_list_enabled_module failure
Check the ports availability and go for a new port if the current one is
not available

Fixes: https://tracker.ceph.com/issues/62972
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit a2a4a3415c)
2025-03-13 11:31:05 +05:30
Nizamudeen A
c0955dc2ad qa/dashboard: fix tasks.mgr.dashboard.test_health.HealthTest
as per: https://tracker.ceph.com/issues/47612#note-14

Fixes: https://tracker.ceph.com/issues/47612
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 79d61bbb58)
2025-03-13 11:31:01 +05:30
Nizamudeen A
afba83d8af qa/tests: fix test_list_enabled_modules timeout error
This test deals with enabling/disabling the modules. The assumption I
have is after enabling the
module test will wait for an active mgr but its not able to find it in
time and it fails. so taking inspiration from 6c7253be6f adding retries and logs to see if that's the case

Fixes: https://tracker.ceph.com/issues/62972
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit b2da7394ee)
2025-03-13 11:30:57 +05:30
Ernesto Puerta
bfee4c6b17 qa/mgr/dashboard: fix test race condition
Fixes: https://tracker.ceph.com/issues/66844

Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
(cherry picked from commit 6c7253be6f)
2025-03-13 11:30:49 +05:30
Nizamudeen A
6992f57173
Merge pull request #62256 from rhcs-dashboard/wip-70424-reef
reef: mgr/dashboard: pin lxml to fix run-dashboard-tox-make-check failure
2025-03-13 11:20:30 +05:30
Anthony D'Atri
f4e5aaf4b3 doc/monitoring: Improve index.rst
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 1bc67295c8)
2025-03-13 14:56:03 +10:00
Nizamudeen A
d56a8afd4e mgr/dashboard: pin lxml to fix run-dashboard-tox-make-check failure
xmlsec had an upgrade yesterday night and python3-saml might need to
adapt its library accordingly I suppose. Testing a fix by pinning lxml

Another approach is being tried out separately
https://github.com/ceph/ceph/pull/62239, but that is failing with some
other errors.

Fixes: https://tracker.ceph.com/issues/70411
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 1f84505f12)

 Conflicts:
	src/pybind/mgr/dashboard/requirements.txt
 - only kept the lxml pinning. didn't add the newer deps that are
   present in main
2025-03-12 22:47:26 +05:30
Yuri Weinstein
1f7fb81be4
Merge pull request #57590 from NitzanMordhai/wip-66141-reef
reef: common/pick_address: check if address in subnet all public address

Reviewed-by: Laura Flores <lflores@redhat.com>
2025-03-12 07:33:48 -07:00