mgr/dashboard/qa: add isort check

Add isort check to the QA test files and
fix issues.

Fixes: https://tracker.ceph.com/issues/47757
Signed-off-by: Tatjana Dehler <tdehler@suse.com>

qa/tasks/mgr/dashboard/helper.py

@@ -4,14 +4,12 @@ from __future__ import absolute_import
 
 import json
 import logging
-from collections import namedtuple
 import time
+from collections import namedtuple
 
 import requests
-from teuthology.exceptions import CommandFailedError
-
 from tasks.mgr.mgr_test_case import MgrTestCase
-
+from teuthology.exceptions import CommandFailedError
 
 log = logging.getLogger(__name__)
 

qa/tasks/mgr/dashboard/test_auth.py

@@ -6,7 +6,7 @@ import time
 
 import jwt
 
-from .helper import DashboardTestCase, JObj, JLeaf
+from .helper import DashboardTestCase, JLeaf, JObj
 
 
 class AuthTest(DashboardTestCase):

qa/tasks/mgr/dashboard/test_cephfs.py

@@ -1,7 +1,7 @@
 # -*- coding: utf-8 -*-
 from contextlib import contextmanager
 
-from .helper import DashboardTestCase, JObj, JList, JLeaf
+from .helper import DashboardTestCase, JLeaf, JList, JObj
 
 
 class CephfsTest(DashboardTestCase):

qa/tasks/mgr/dashboard/test_crush_rule.py

@@ -2,7 +2,7 @@
 
 from __future__ import absolute_import
 
-from .helper import DashboardTestCase, JObj, JList
+from .helper import DashboardTestCase, JList, JObj
 
 
 class CrushRuleTest(DashboardTestCase):

qa/tasks/mgr/dashboard/test_erasure_code_profile.py

@@ -2,7 +2,7 @@
 
 from __future__ import absolute_import
 
-from .helper import DashboardTestCase, JObj, JList
+from .helper import DashboardTestCase, JList, JObj
 
 
 class ECPTest(DashboardTestCase):

qa/tasks/mgr/dashboard/test_ganesha.py

@@ -3,7 +3,6 @@
 
 from __future__ import absolute_import
 
-
 from .helper import DashboardTestCase, JList, JObj
 
 

qa/tasks/mgr/dashboard/test_mgr_module.py

@@ -2,9 +2,10 @@
 from __future__ import absolute_import
 
 import logging
+
 import requests
 
-from .helper import DashboardTestCase, JAny, JObj, JList, JLeaf
+from .helper import DashboardTestCase, JAny, JLeaf, JList, JObj
 
 logger = logging.getLogger(__name__)
 

qa/tasks/mgr/dashboard/test_orchestrator.py

@@ -1,10 +1,10 @@
 # -*- coding: utf-8 -*-
 from __future__ import absolute_import
+
 import json
 
 from .helper import DashboardTestCase
 
-
 test_data = {
     'inventory': [
         {

qa/tasks/mgr/dashboard/test_osd.py

@@ -4,7 +4,7 @@ from __future__ import absolute_import
 
 import json
 
-from .helper import DashboardTestCase, JObj, JAny, JList, JLeaf, JTuple
+from .helper import DashboardTestCase, JAny, JLeaf, JList, JObj, JTuple
 
 
 class OsdTest(DashboardTestCase):

qa/tasks/mgr/dashboard/test_rbd.py

@@ -5,7 +5,7 @@ from __future__ import absolute_import
 
 import time
 
-from .helper import DashboardTestCase, JObj, JLeaf, JList
+from .helper import DashboardTestCase, JLeaf, JList, JObj
 
 
 class RbdTest(DashboardTestCase):

qa/tasks/mgr/dashboard/test_rgw.py

@@ -4,14 +4,13 @@ from __future__ import absolute_import
 import base64
 import logging
 import time
-
 from urllib import parse
 
 from cryptography.hazmat.backends import default_backend
-from cryptography.hazmat.primitives.twofactor.totp import TOTP
 from cryptography.hazmat.primitives.hashes import SHA1
+from cryptography.hazmat.primitives.twofactor.totp import TOTP
 
-from .helper import DashboardTestCase, JObj, JList, JLeaf
+from .helper import DashboardTestCase, JLeaf, JList, JObj
 
 logger = logging.getLogger(__name__)
 

qa/tasks/mgr/dashboard/test_settings.py

@@ -2,7 +2,7 @@
 
 from __future__ import absolute_import
 
-from .helper import DashboardTestCase, JList, JObj, JAny
+from .helper import DashboardTestCase, JAny, JList, JObj
 
 
 class SettingsTest(DashboardTestCase):

qa/tasks/mgr/dashboard/test_user.py

@@ -3,7 +3,6 @@
 from __future__ import absolute_import
 
 import time
-
 from datetime import datetime, timedelta
 
 from .helper import DashboardTestCase

src/pybind/mgr/dashboard/tox.ini

@@ -107,6 +107,7 @@ commands =
     flake8
     flake8 --config=tox.ini ../../../../qa/tasks/mgr/dashboard
     isort . --check
+    isort ../../../../qa/tasks/mgr/dashboard --check
     {[base-pylint]commands}
     {[base-rst]commands}
 
@@ -148,6 +149,7 @@ commands =
     python --version
     autopep8 {[autopep8]addopts} {posargs:.}
     isort .
+    isort ../../../../qa/tasks/mgr/dashboard
 
 [testenv:check]
 commands =