mirror of https://github.com/mpv-player/mpv
ba35335939
vo_opengl creates an invisible window with VOFLAG_HIDDEN in order to test whether the OpenGL context is useable. The visible window is created at a later point. This has been broken forever (in vo_gl, now called vo_opengl_old, it could be avoided by disabling auto- detection explicitly using the "yuv" sub-option). Avoiding VOFLAG_HIDDEN only mitigates the issue, and a related bug can still happen with some window managers (see below). As a hack, code was added to vo_gl to destroy the (hidden) window so that all state was destroyed. Later, more hacks were added to deal with some caveats that came with recreating the window, such as probing for the context up to 4 times. Attempt to fix the problem properly. There were two problems: first, the window was not resized to video size before mapping. This was the main cause for the placement issue, e.g. mapping the window as 320x200, and then resizing it. Second, mpv tried to force the window position with XSetWMNormalHints and PPosition with values it just read with XGetGeometry. This messes up the window manager's default placement. It seems to be a race condition, and behavior is different across various WMs too: with IceWM, the window manager's placement is usually preferred, and with Fluxbox, mpv's position is preferred. mpv's default position is centering the window on the screen, which is much nicer for video in general than typical WM default placement, so it's possible that this bug was perceived as a feature. (Users who want this have to use --geometry="50%:50%", doing this by default is probably not safe with all WMs.) Since the old code was hard to follow and full of issues, it's easier to redo it. Move general window creation stuff out of the vo_x11_config_vo_window function, and move the resize logic into it. This has been tested on IcwWM, Fluxbox, awesome, Unity/Compiz. |
||
|---|---|---|
| .. | ||
| aspect.c | ||
| aspect.h | ||
| bitmap_packer.c | ||
| bitmap_packer.h | ||
| cocoa_common.h | ||
| cocoa_common.m | ||
| d3d_shader_yuv.h | ||
| d3d_shader_yuv.hlsl | ||
| filter_kernels.c | ||
| filter_kernels.h | ||
| gl_common.c | ||
| gl_common.h | ||
| gl_header_fixes.h | ||
| gl_osd.c | ||
| gl_osd.h | ||
| osx_common.h | ||
| osx_common.m | ||
| pnm_loader.c | ||
| pnm_loader.h | ||
| vo.c | ||
| vo.h | ||
| vo_caca.c | ||
| vo_corevideo.h | ||
| vo_corevideo.m | ||
| vo_direct3d.c | ||
| vo_image.c | ||
| vo_lavc.c | ||
| vo_null.c | ||
| vo_opengl.c | ||
| vo_opengl_old.c | ||
| vo_opengl_shaders.glsl | ||
| vo_sdl.c | ||
| vo_vdpau.c | ||
| vo_x11.c | ||
| vo_xv.c | ||
| w32_common.c | ||
| w32_common.h | ||
| wayland_common.c | ||
| wayland_common.h | ||
| x11_common.c | ||
| x11_common.h | ||