suckless
/
slstatus
mirror of git://git.suckless.org/slstatus
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
604 Commits 1 Branch 1 Tag 702 KiB
Commit Graph

604 Commits

Author SHA1 Message Date
Aaron Marcher 932f65c373 datetime: Add error message 2018-05-06 22:38:29 +02:00
Aaron Marcher ee5ec75621 Fix coding style 
- Use block for single statement ifs
- Keep lines to reasonable length (current debate as to reasonable)
- When functions return -1 for error test against 0 not -1
- Do not indent cases another level
- Do not test against NULL and 0 explicitly
- Use tabs for indentation, use spaces for alignment
 2018-05-06 22:28:56 +02:00
Aaron Marcher 66a7fb16fc Remove cpu_iowait 
The third value from load_avg (idle) gives us almost the same
information as cpu_iowait. Plus OpenBSD does not offer an iowait value
as Linux and thus the corresponding function would not be portable.
 2018-05-06 21:11:50 +02:00
Aaron Marcher 235fa3c306 cpu_perc: Documentation and readbility improvements 2018-05-06 21:10:02 +02:00
Aaron Marcher 2b82bf0248 cpu_perc: Port to OpenBSD 
In OpenBSD the CPU usage in percent is now computed using KERN_CPTIME
sysctl.
 2018-05-06 17:48:37 +02:00
Aaron Marcher efb41724b5 swap_*: Port to OpenBSD 2018-05-06 01:20:46 +02:00
Aaron Marcher 417f473fe2 battery: Remove full indicator 
It does not respect charging thresholds and it is not trivial to
implement the indicator in OpenBSD.
 2018-05-04 18:04:53 +02:00
Aaron Marcher 699f6734d9 wifi_perc: Fix file descriptor leak 2018-05-02 19:41:53 +02:00
Aaron Marcher af3cdfbbc8 Add examples to config.def.h 2018-05-02 12:30:16 +02:00
Aaron Marcher 54ebd0dabe uptime: Add missing brace 2018-05-02 12:08:54 +02:00
parazyd 34010907a6 volume: Cast SOUND_MIXER_READ_DEVMASK to int to avoid warning. 2018-05-02 11:49:15 +02:00
Aaron Marcher f7a6d6c8f7 wifi: Various cleanups 2018-05-02 08:49:06 +02:00
Aaron Marcher 709549b4bd user: Only declare variables in the beginning 2018-05-02 08:42:55 +02:00
Aaron Marcher e43c3a16f0 uptime: Simplifiy and clean up 2018-05-02 08:41:06 +02:00
Aaron Marcher f007007156 run_command: Clean up 2018-05-02 08:29:36 +02:00
Aaron Marcher 7c11f890a5 keyboard_indicators: Clean up opening display 2018-05-02 08:26:23 +02:00
Aaron Marcher b2b6eb638e ip: Sort headers alphabetically 2018-05-02 08:21:32 +02:00
Aaron Marcher 2bd581a47b battery_state: Unify unknown state with "?" symbol 2018-05-02 08:16:21 +02:00
Aaron Marcher f5f3808f36 Update README todo 2018-05-01 21:05:50 +02:00
Aaron Marcher 4f5ac5d9fe Remove battery_power for various reasons 
- Battery power cannot be easily gatherable via apm(4)
- IMHO it does not represent essential information
 2018-05-01 21:01:25 +02:00
Laslo Hunhold 24b663d657 Tweak build system a little bit 
Be consistent with brackets and add a comment for OpenBSD to make it
clearer what the actual intent of the uncommented line is.

In the Makefile, add a dependency of slstatus.o from config.mk.
 2018-05-01 20:53:27 +02:00
Aaron Marcher 41deabf2ec battery_perc: Port to OpenBSD 2018-05-01 20:45:29 +02:00
Laslo Hunhold 19343ff343 components/swap.c | move duplicated code to separate function 2018-05-01 20:24:13 +02:00
Laslo Hunhold 9750a3d731 Use indentation to increase readability 
Granted, this style is definitely not common, but for the short
utility-functions of this program it's just the right choice. This
provides great flexibility, such that in the long run, it will be
possible to also share code between the OS-implementations.

This also keeps the state-keeping at a minimum and makes it clearer
which functions are implemented on which OS without having to jiggle
around with too many files in the process.
 2018-05-01 19:43:49 +02:00
Laslo Hunhold 42edfea89a Revert component-split 
this reverts the commits from 92ab9ef52e up to
d42870d6ca.

After heavy consideration, the component split has more disadvantages
than advantages, especially given there will be utility-functions
sharing quite a lot of code that would then need to be duplicated, as it
does not fit into the util.c due to its speciality.

One big advantage of the component-wise build is readability, and
without doubt, this was achieved here. This point will be addressed
with a different approach that will be visible in the upcoming commits.

One big disadvantage of the component build is the fact that it
introduces state to the build process which is not necessary. Before its
introduction, the only influencing factors where the system-defines
__linux__ and __OpenBSD__. With the components, we are also relying on
the output of uname(1).
Additionally, if the os.mk is not present, make gives the output

     $ make
     Makefile:5: os.mk: No such file or directory
     make: *** No rule to make target 'os.mk'.  Stop.

This could easily be fixed by providing some sort of meta-rule for this
file, however, it indicates the problem we have here, and this entire
statefulness will heavily complicate packaging of this tool and makes
the build process much more complex than it actually has to be.
 2018-05-01 19:43:34 +02:00
Quentin Rameau d42870d6ca Makefile: add distclean target 2018-04-30 16:27:07 +02:00
Quentin Rameau 2ea3d46f13 Makefile: move OS-specific libs to configure script 2018-04-30 16:27:07 +02:00
Quentin Rameau 95665e437b Makefile: separate default flags from user flags 2018-04-30 16:27:07 +02:00
Aaron Marcher 085431b282 Update LICENSE for Quentin Rameau 2018-04-30 15:44:41 +02:00
Quentin Rameau 97ff66522c wifi: OS split 2018-04-30 15:42:16 +02:00
Quentin Rameau 19f3c8f545 uptime: OS split 2018-04-30 15:42:08 +02:00
Quentin Rameau 71eb1d321d temperature: OS split 2018-04-30 15:42:00 +02:00
Quentin Rameau 72f5a0d69a swap: OS split 2018-04-30 15:41:52 +02:00
Quentin Rameau 259e106b4f ram: OS split 2018-04-30 15:41:43 +02:00
Quentin Rameau 3cc649e34c entropy: OS split 2018-04-30 15:41:31 +02:00
Quentin Rameau f088dbfea0 cpu: OS split 2018-04-30 15:41:09 +02:00
Quentin Rameau 720569bd56 battery: OS split 2018-04-30 15:40:59 +02:00
Quentin Rameau 92ab9ef52e Makefile: detect running OS 2018-04-30 15:40:20 +02:00
Aaron Marcher 3fe1db8892 cpu_freq: Port to OpenBSD 
In OpenBSD CPU frequency gets fetched using sysctl now.
 2018-04-30 13:20:24 +02:00
Aaron Marcher c3ce506b7f Fix typo in temperature 2018-04-29 22:44:09 +02:00
Aaron Marcher 4113a39ee6 Update README for OpenBSD build 2018-04-29 22:33:15 +02:00
Aaron Marcher 273d3db573 uptime: Separate function for readbility 2018-04-29 20:07:09 +02:00
Aaron Marcher 09950055ba battery: Separate function for readbility 2018-04-29 20:02:42 +02:00
Aaron Marcher cee6811036 ram: Move up includes 2018-04-29 20:00:38 +02:00
Aaron Marcher 7baad64a4b Sort LICENSE according to first commit 2018-04-29 18:50:44 +02:00
Aaron Marcher 489c6f87d1 temp: Port to OpenBSD 
In OpenBSD temperature gets fetched using sysctl now.
 2018-04-29 18:35:41 +02:00
Aaron Marcher b6d2b652d0 Remove vol_perc() from todo in README 2018-04-29 16:08:45 +02:00
Aaron Marcher 57b1c1719f Update LICENSE for parazyd 2018-04-29 16:05:53 +02:00
parazyd d66e775c8d Add OpenBSD support in volume.c 2018-04-29 15:57:17 +02:00
Aaron Marcher 53ecbcb3ad Update LICENSE for Ali H. Fardan 2018-04-29 13:02:08 +02:00