caskd/bemenu
1
0
Fork 0
forked from RepoMirrors/bemenu
Code Pull Requests Activity

lib/renderers/curses/curses.c: always use "%s"-style format for printf()-style functions

Browse Source 
`ncuses-6.3` added printf-style function attributes and now makes
it easier to catch cases when user input is used in palce of format
string when built with CFLAGS=-Werror=format-security:

    lib/renderers/curses/curses.c:234:9:
      error: format not a string literal and no format arguments [-Werror=format-security]
      234 |         mvprintw(0, 0, menu->title);
          |         ^~~~~~~~

Let's wrap all the missing places with "%s" format.
This commit is contained in:
Sergei Trofimovich 2021-11-02 23:47:13 +00:00 committed by Jari Vetoniemi
parent b7f8db7128
commit d31164db75
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/renderers/curses/curses.c
View File

@ -231,7 +231,7 @@ render(const struct bm_menu *menu)
if (menu->title && title_len > 0) {
attron(COLOR_PAIR(1));
mvprintw(0, 0, menu->title);
mvprintw(0, 0, "%s", menu->title);
attroff(COLOR_PAIR(1));
}