Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>
Reformat adfsCollector struct
Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>
Add metrics to ADFS collector documentation
Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>
Update ADFS collector with useful queries and links to documentation
Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>
Remove bad table formatter
Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>
Reformat ADFS collector using gofmt
Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>
Fix ADFS Config and Artifact DB Query time metrics
Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>
Update ADFS collector for Config and Artifact DB Query time from gauge to counter
Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>
Update ADFS collector for Config and Artifact DB Query time from gauge to counter
Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>
See,
```
windows_memory_demand_zero_faults_total non-counter metrics should not have "_total" suffix
windows_memory_cache_faults_total non-counter metrics should not have "_total" suffix
windows_memory_page_faults_total non-counter metrics should not have "_total" suffix
windows_memory_pool_nonpaged_allocs_total non-counter metrics should not have "_total" suffix
windows_memory_pool_nonpaged_bytes_total non-counter metrics should not have "_total" suffix
windows_memory_pool_paged_allocs_total non-counter metrics should not have "_total" suffix
windows_memory_swap_page_operations_total non-counter metrics should not have "_total" suffix
windows_memory_swap_page_reads_total non-counter metrics should not have "_total" suffix
windows_memory_swap_page_writes_total non-counter metrics should not have "_total" suffix
windows_memory_swap_pages_read_total non-counter metrics should not have "_total" suffix
windows_memory_swap_pages_written_total non-counter metrics should not have "_total" suffix
windows_memory_transition_faults_total non-counter metrics should not have "_total" suffix
windows_memory_transition_pages_repurposed_total non-counter metrics should not have "_total" suffix
windows_memory_write_copies_total non-counter metrics should not have "_total" suffix
```
Only `windows_memory_pool_nonpaged_bytes` is a gauge, all the other
metrics were counters.
Also added some missing documentation.
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
Related to #659, this is a breaking change!
Fixes
```
windows_time_ntp_client_time_source_count non-histogram and non-summary metrics should not have "_count" suffix
```
for the time collector.
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
Related to #659, this is a breaking change!
Fixes
```
windows_process_handle_count non-histogram and non-summary metrics should not have "_count" suffix
windows_process_thread_count non-histogram and non-summary metrics should not have "_count" suffix
```
for process and terminal_services collectors.
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
From https://prometheus.io/docs/practices/naming/:
To avoid confusion combining different metrics, always use bytes, even
where bits appear more common.
Fixes#800
Signed-off-by: Max Lendrich <maximilian.lendrich@sap.com>
