From a5b3926063de8974cb3e3e48a5535d2afe2f879d Mon Sep 17 00:00:00 2001 From: Ben Reedy Date: Tue, 21 Mar 2023 06:39:27 +1000 Subject: [PATCH] feat: Remove default metrics from e2e test Metrics are provided by client library, and not the exporter, so comparing them for differences does not provide much value. Signed-off-by: Ben Reedy --- tools/e2e-output.txt | 68 --------------------------------------- tools/end-to-end-test.ps1 | 2 +- 2 files changed, 1 insertion(+), 69 deletions(-) diff --git a/tools/e2e-output.txt b/tools/e2e-output.txt index 5c15503c..6f5a8e58 100644 --- a/tools/e2e-output.txt +++ b/tools/e2e-output.txt @@ -1,69 +1,3 @@ -# HELP go_gc_duration_seconds A summary of the pause duration of garbage collection cycles. -# TYPE go_gc_duration_seconds summary -# HELP go_goroutines Number of goroutines that currently exist. -# TYPE go_goroutines gauge -# HELP go_info Information about the Go environment. -# TYPE go_info gauge -# HELP go_memstats_alloc_bytes Number of bytes allocated and still in use. -# TYPE go_memstats_alloc_bytes gauge -# HELP go_memstats_alloc_bytes_total Total number of bytes allocated, even if freed. -# TYPE go_memstats_alloc_bytes_total counter -# HELP go_memstats_buck_hash_sys_bytes Number of bytes used by the profiling bucket hash table. -# TYPE go_memstats_buck_hash_sys_bytes gauge -# HELP go_memstats_frees_total Total number of frees. -# TYPE go_memstats_frees_total counter -# HELP go_memstats_gc_sys_bytes Number of bytes used for garbage collection system metadata. -# TYPE go_memstats_gc_sys_bytes gauge -# HELP go_memstats_heap_alloc_bytes Number of heap bytes allocated and still in use. -# TYPE go_memstats_heap_alloc_bytes gauge -# HELP go_memstats_heap_idle_bytes Number of heap bytes waiting to be used. -# TYPE go_memstats_heap_idle_bytes gauge -# HELP go_memstats_heap_inuse_bytes Number of heap bytes that are in use. -# TYPE go_memstats_heap_inuse_bytes gauge -# HELP go_memstats_heap_objects Number of allocated objects. -# TYPE go_memstats_heap_objects gauge -# HELP go_memstats_heap_released_bytes Number of heap bytes released to OS. -# TYPE go_memstats_heap_released_bytes gauge -# HELP go_memstats_heap_sys_bytes Number of heap bytes obtained from system. -# TYPE go_memstats_heap_sys_bytes gauge -# HELP go_memstats_last_gc_time_seconds Number of seconds since 1970 of last garbage collection. -# TYPE go_memstats_last_gc_time_seconds gauge -# HELP go_memstats_lookups_total Total number of pointer lookups. -# TYPE go_memstats_lookups_total counter -# HELP go_memstats_mallocs_total Total number of mallocs. -# TYPE go_memstats_mallocs_total counter -# HELP go_memstats_mcache_inuse_bytes Number of bytes in use by mcache structures. -# TYPE go_memstats_mcache_inuse_bytes gauge -# HELP go_memstats_mcache_sys_bytes Number of bytes used for mcache structures obtained from system. -# TYPE go_memstats_mcache_sys_bytes gauge -# HELP go_memstats_mspan_inuse_bytes Number of bytes in use by mspan structures. -# TYPE go_memstats_mspan_inuse_bytes gauge -# HELP go_memstats_mspan_sys_bytes Number of bytes used for mspan structures obtained from system. -# TYPE go_memstats_mspan_sys_bytes gauge -# HELP go_memstats_next_gc_bytes Number of heap bytes when next garbage collection will take place. -# TYPE go_memstats_next_gc_bytes gauge -# HELP go_memstats_other_sys_bytes Number of bytes used for other system allocations. -# TYPE go_memstats_other_sys_bytes gauge -# HELP go_memstats_stack_inuse_bytes Number of bytes in use by the stack allocator. -# TYPE go_memstats_stack_inuse_bytes gauge -# HELP go_memstats_stack_sys_bytes Number of bytes obtained from system for stack allocator. -# TYPE go_memstats_stack_sys_bytes gauge -# HELP go_memstats_sys_bytes Number of bytes obtained from system. -# TYPE go_memstats_sys_bytes gauge -# HELP go_threads Number of OS threads created. -# TYPE go_threads gauge -# HELP process_cpu_seconds_total Total user and system CPU time spent in seconds. -# TYPE process_cpu_seconds_total counter -# HELP process_max_fds Maximum number of open file descriptors. -# TYPE process_max_fds gauge -# HELP process_open_fds Number of open file descriptors. -# TYPE process_open_fds gauge -# HELP process_resident_memory_bytes Resident memory size in bytes. -# TYPE process_resident_memory_bytes gauge -# HELP process_start_time_seconds Start time of the process since unix epoch in seconds. -# TYPE process_start_time_seconds gauge -# HELP process_virtual_memory_bytes Virtual memory size in bytes. -# TYPE process_virtual_memory_bytes gauge # HELP test_alpha_total Some random metric. # TYPE test_alpha_total counter test_alpha_total 42 @@ -99,8 +33,6 @@ test_alpha_total 42 # TYPE windows_cs_logical_processors gauge # HELP windows_cs_physical_memory_bytes ComputerSystem.TotalPhysicalMemory # TYPE windows_cs_physical_memory_bytes gauge -# HELP windows_exporter_build_info A metric with a constant '1' value labeled by version, revision, branch, goversion from which windows_exporter was built, and the goos and goarch for the build. -# TYPE windows_exporter_build_info gauge # HELP windows_exporter_collector_duration_seconds windows_exporter: Duration of a collection. # TYPE windows_exporter_collector_duration_seconds gauge # HELP windows_exporter_collector_success windows_exporter: Whether the collector was successful. diff --git a/tools/end-to-end-test.ps1 b/tools/end-to-end-test.ps1 index 3af46a82..7aa7f76d 100644 --- a/tools/end-to-end-test.ps1 +++ b/tools/end-to-end-test.ps1 @@ -25,7 +25,7 @@ $skip_re = "^(go_|windows_exporter_build_info|windows_exporter_collector_duratio $exporter_proc = Start-Process ` -PassThru ` -FilePath ..\windows_exporter.exe ` - -ArgumentList "--log.level=debug --collector.textfile.directory=$($textfile_dir)" ` + -ArgumentList "--log.level=debug --web.disable-exporter-metrics --collector.textfile.directory=$($textfile_dir)" ` -WindowStyle Hidden ` -RedirectStandardOutput "$($temp_dir)/windows_exporter.log" ` -RedirectStandardError "$($temp_dir)/windows_exporter_error.log"