From 9d1628a329782c91a37f7f968cf6f14a380818f8 Mon Sep 17 00:00:00 2001 From: Mario Trangoni Date: Thu, 30 Dec 2021 14:53:34 +0100 Subject: [PATCH] promtool: Fix `windows_time_ntp_client_time_source_count` Related to #659, this is a breaking change! Fixes ``` windows_time_ntp_client_time_source_count non-histogram and non-summary metrics should not have "_count" suffix ``` for the time collector. Signed-off-by: Mario Trangoni --- collector/time.go | 2 +- docs/collector.time.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/collector/time.go b/collector/time.go index 0f761f96..82da5fa1 100644 --- a/collector/time.go +++ b/collector/time.go @@ -45,7 +45,7 @@ func newTimeCollector() (Collector, error) { nil, ), NTPClientTimeSourceCount: prometheus.NewDesc( - prometheus.BuildFQName(Namespace, subsystem, "ntp_client_time_source_count"), + prometheus.BuildFQName(Namespace, subsystem, "ntp_client_time_sources"), "Active number of NTP Time sources being used by the client", nil, nil, diff --git a/docs/collector.time.md b/docs/collector.time.md index 8361cf68..ebc2dc8b 100644 --- a/docs/collector.time.md +++ b/docs/collector.time.md @@ -21,7 +21,7 @@ Name | Description | Type | Labels -----|-------------|------|------- `windows_time_clock_frequency_Adjustment_ppb_total` | Total adjustment made to the local system clock frequency by W32Time in parts per billion (PPB) units. 1 PPB adjustment implies the system clock was adjusted at a rate of 1 nanosecond per second (1 ns/s). The smallest possible adjustment can vary and is expected to be in the order of 100's of PPB. | counter | None `windows_time_computed_time_offset_seconds` | Absolute time offset between the system clock and the chosen time source, in seconds. | counter | None -`windows_time_ntp_client_time_source_count` | Active number of NTP Time sources being used by the client. This is a count of active, distinct IP addresses of time servers that are responding to this client's requests. | gauge | None +`windows_time_ntp_client_time_sources` | Active number of NTP Time sources being used by the client. This is a count of active, distinct IP addresses of time servers that are responding to this client's requests. | gauge | None `windows_time_ntp_round_trip_delay_seconds` | Total roundtrip delay experienced by the NTP client in receiving a response from the server for the most recent request, in seconds. This is the time elapsed on the NTP client between transmitting a request to the NTP server and receiving a valid response from the server. | gauge | None `windows_time_ntp_server_outgoing_responses_total` | Total number of requests responded to by the NTP server. | counter | None `windows_time_ntp_server_incoming_requests_total` | Total number of requests received by the NTP server. | counter | None