From 63e7fa3054b8d087fa3197910394be2f52ef19c8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan-Otto=20Kr=C3=B6pke?= <mail@jkroepke.de>
Date: Tue, 5 Dec 2023 08:47:40 +0100
Subject: [PATCH] Remove old event source registry key
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
---
 installer/windows_exporter.wxs | 32 +++++++++++++++++++++++++-------
 1 file changed, 25 insertions(+), 7 deletions(-)

diff --git a/installer/windows_exporter.wxs b/installer/windows_exporter.wxs
index 85762781..34c5d1ca 100644
--- a/installer/windows_exporter.wxs
+++ b/installer/windows_exporter.wxs
@@ -24,7 +24,25 @@
     <Property Id="REMOTE_ADDR" Secure="yes" />
     <SetProperty Id="RemoteAddressFlag" After="InstallFiles" Sequence="execute" Value="[REMOTE_ADDR]" Condition="REMOTE_ADDR" />
 
-    
+    <!-- https://github.com/prometheus-community/windows_exporter/issues/1318 -->
+    <!-- https://wixtoolset.org/docs/tools/wixext/quietexec/ -->
+    <SetProperty
+            Id="WixQuietExecCmdLine"
+            Value="&quot;[%ComSpec]&quot; /c reg delete HKLM\SYSTEM\CurrentControlSet\Services\EventLog\Application\windows_exporter /f"
+            Before="ConvolutedCoreCountCustomAction"
+            Sequence="execute"
+    />
+    <CustomAction
+            Id="RemoveEventSource"
+            BinaryRef="Wix4UtilCA_$(sys.BUILDARCHSHORT)"
+            DllEntry="WixSilentExec"
+            Execute="deferred"
+            Impersonate="no"
+            Return="ignore"
+    />
+    <InstallExecuteSequence>
+      <Custom Action="RemoveEventSource" After="InstallInitialize" />
+    </InstallExecuteSequence>
 
     <Property Id="TEXTFILE_DIR" Secure="yes" />
     <SetProperty Id="TextfileDirFlag" After="InstallFiles" Sequence="execute" Value="--collector.textfile.directory [TEXTFILE_DIR]" Condition="TEXTFILE_DIR" />
@@ -51,11 +69,11 @@
     <Feature Id="DefaultFeature" Level="1">
       <ComponentGroupRef Id="Files" />
     </Feature>
-  
-      <Directory Id="$(var.PlatformProgramFiles)">
-        <Directory Id="APPLICATIONROOTDIRECTORY" Name="windows_exporter">
-          <Directory Id="textfile_inputs" Name="textfile_inputs" />
-        </Directory>
+
+    <Directory Id="$(var.PlatformProgramFiles)">
+      <Directory Id="APPLICATIONROOTDIRECTORY" Name="windows_exporter">
+        <Directory Id="textfile_inputs" Name="textfile_inputs" />
       </Directory>
-    </Package>
+    </Directory>
+  </Package>
 </Wix>