From b4c0874ca4046c611bd46b50bd465780404b8d23 Mon Sep 17 00:00:00 2001 From: Dinifarb Date: Fri, 12 Jan 2024 16:45:56 +0100 Subject: [PATCH 1/2] fix:(#1382): rename TEXTFILE_DIR to TEXTFILE_DIRS Signed-off-by: Dinifarb --- README.md | 4 ++-- installer/windows_exporter.wxs | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 87dd22b5..a881cb73 100644 --- a/README.md +++ b/README.md @@ -106,7 +106,7 @@ Name | Description `LISTEN_ADDR` | The IP address to bind to. Defaults to 0.0.0.0 `LISTEN_PORT` | The port to bind to. Defaults to 9182. `METRICS_PATH` | The path at which to serve metrics. Defaults to `/metrics` -`TEXTFILE_DIR` | As the `--collector.textfile.directory` flag, provide a directory to read text files with metrics from +`TEXTFILE_DIRS` | As the `--collector.textfile.directories` flag, provide a directory to read text files with metrics from `REMOTE_ADDR` | Allows setting comma separated remote IP addresses for the Windows Firewall exception (allow list). Defaults to an empty string (any remote address). `EXTRA_FLAGS` | Allows passing full CLI flags. Defaults to an empty string. @@ -123,7 +123,7 @@ msiexec /i ENABLED_COLLECTORS=os,service --% EXTRA_FLAGS="--c On some older versions of Windows you may need to surround parameter values with double quotes to get the install command parsing properly: ```powershell -msiexec /i C:\Users\Administrator\Downloads\windows_exporter.msi ENABLED_COLLECTORS="ad,iis,logon,memory,process,tcp,textfile,thermalzone" TEXTFILE_DIR="C:\custom_metrics\" +msiexec /i C:\Users\Administrator\Downloads\windows_exporter.msi ENABLED_COLLECTORS="ad,iis,logon,memory,process,tcp,textfile,thermalzone" TEXTFILE_DIRS="C:\custom_metrics\" ``` Powershell versions 7.3 and above require [PSNativeCommandArgumentPassing](https://learn.microsoft.com/en-us/powershell/scripting/learn/experimental-features?view=powershell-7.3) to be set to `Legacy` when using `--% EXTRA_FLAGS`: diff --git a/installer/windows_exporter.wxs b/installer/windows_exporter.wxs index a67eff95..e13400c3 100644 --- a/installer/windows_exporter.wxs +++ b/installer/windows_exporter.wxs @@ -44,8 +44,8 @@ - - + + From bd7d7be6ea146c80dbc2ab6e9434de2fd433e0f2 Mon Sep 17 00:00:00 2001 From: Dinifarb Date: Fri, 12 Jan 2024 16:53:02 +0100 Subject: [PATCH 2/2] fix:(#1382): update TextfileDirFlag to TextfileDirsFlag Signed-off-by: Dinifarb --- installer/windows_exporter.wxs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/installer/windows_exporter.wxs b/installer/windows_exporter.wxs index e13400c3..bf52f61f 100644 --- a/installer/windows_exporter.wxs +++ b/installer/windows_exporter.wxs @@ -54,7 +54,7 @@ - +