mirror of
https://github.com/telegramdesktop/tdesktop
synced 2025-04-28 22:34:48 +00:00
4dd14b81e1
In general we need to keep a reference to the notification id, so that we can delete the notification later from history - unless the NotificationClosed reason was that the user actively dismissed it, in which case it is not kept in history anyway (so we can dismiss our reference too). -- Background -- Some desktop environments such as KDE keep a history of notifications. An API is provided to delete notifications from that history by calling the org.freedesktop.Notifications.CloseNotification endpoint with the ID of that notification. If the notification was already closed (timed out), then this will delete the notification from history. The intent is to clear these notifications from the notification history as soon as a chat with notifications originating from that person is opened, as the user is then not interested anymore in those notifications and to prevent unnecessary clutter in the history widget. It is also cleared when the chat is read on another device. -- Problem -- Telegram already has all the code in place to support this functionality, but unfortunately this did not work on Linux before, because we listen to the NotificationClosed signal and remove our reference to the notification id from our internal manager as soon as we get that signal. This means that we do not clear that notification from history once we open the chat with that person (unless we open the chat before the notification has timed out, i.e. if we didn't get the NotificationClosed signal). -- Fix -- To fix this, we keep our notification reference (if the notification was not dismissed by the user), which means that our reference will be kept around until we open the chat with that person (or close Telegram entirely). Since all the needed functionality for deleting notifications was already in place, this patch is quite short as we only need to keep the reference around longer than we did before this patch. Note also that code is already in place to clear notifications for messages that were read on another device: History::inboxRead() calls Core::App().notifications().clearIncomingFromHistory() Fixes #17111 |
||
|---|---|---|
| .. | ||
| file_utilities_linux.cpp | ||
| file_utilities_linux.h | ||
| integration_linux.cpp | ||
| integration_linux.h | ||
| launcher_linux.cpp | ||
| launcher_linux.h | ||
| linux_desktop_environment.cpp | ||
| linux_desktop_environment.h | ||
| linux_wayland_integration_dummy.cpp | ||
| linux_wayland_integration.cpp | ||
| linux_wayland_integration.h | ||
| linux_xdp_file_dialog.cpp | ||
| linux_xdp_file_dialog.h | ||
| linux_xdp_open_with_dialog.cpp | ||
| linux_xdp_open_with_dialog.h | ||
| main_window_linux.cpp | ||
| main_window_linux.h | ||
| notifications_manager_linux_dummy.cpp | ||
| notifications_manager_linux.cpp | ||
| notifications_manager_linux.h | ||
| specific_linux.cpp | ||
| specific_linux.h | ||