RepoMirrors/tdesktop
1
0
Fork 0
mirror of https://github.com/telegramdesktop/tdesktop synced 2025-03-05 22:07:44 +00:00
Code Issues Projects Releases Wiki Activity

Update media viewer window flags

Browse Source 
1. FramelessWindowHint seem to be a redudant leftover of BypassWindowManagerHint, media viewer uses fullscreen state now that implies lack of the frame
2. MaximizeUsingFullscreenGeometryHint is useless since media viewer doesn't use maximize
3. Transient parent/window modality dance is replaced with minimum/maximum size just like in other places where tiling shouldn't be done
4. setWindowState(WindowFullScreen) is replaced with showFullScreen that ensures the flag is set on each show
This commit is contained in:
Ilya Fedin 2022-03-23 19:10:43 +04:00 committed by John Preston
parent bf3fbd4141
commit 93e9eedfae
1 changed files with 4 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
Telegram/SourceFiles/media/view/media_view_overlay_widget.cpp
View File

@ -407,17 +407,12 @@ OverlayWidget::OverlayWidget()
return base::EventFilterResult::Continue;
});
if (Platform::IsLinux()) {
_widget->setWindowFlags(Qt::FramelessWindowHint
| Qt::MaximizeUsingFullscreenGeometryHint);
} else if (Platform::IsMac()) {
if constexpr (Platform::IsMac()) {
// Without Qt::Tool starting with Qt 5.15.1 this widget
// when being opened from a fullscreen main window was
// opening not as overlay over the main window, but as
// a separate fullscreen window with a separate space.
_widget->setWindowFlags(Qt::FramelessWindowHint | Qt::Tool);
} else {
_widget->setWindowFlags(Qt::FramelessWindowHint);
}
_widget->setAttribute(Qt::WA_NoSystemBackground, true);
_widget->setAttribute(Qt::WA_TranslucentBackground, true);
@ -425,13 +420,6 @@ OverlayWidget::OverlayWidget()
hide();
_widget->createWinId();
if (Platform::IsLinux()) {
window()->setTransientParent(App::wnd()->windowHandle());
_widget->setWindowModality(Qt::WindowModal);
}
if (!Platform::IsMac()) {
_widget->setWindowState(Qt::WindowFullScreen);
}
QObject::connect(
window(),
@ -548,6 +536,8 @@ void OverlayWidget::updateGeometry(bool inMove) {
.arg(use.width())
.arg(use.height()));
_widget->setGeometry(use);
_widget->setMinimumSize(use.size());
_widget->setMaximumSize(use.size());
if (useSizeHack) {
_widget->setMask(mask);
}
@ -2628,7 +2618,7 @@ void OverlayWidget::displayFinished() {
//OverlayParent::setVisibleHook(false);
//setAttribute(Qt::WA_DontShowOnScreen, false);
Ui::Platform::UpdateOverlayed(_widget);
if (Platform::IsLinux()) {
if constexpr (!Platform::IsMac()) {
_widget->showFullScreen();
} else {
_widget->show();