Allow WebDocument video thumbnails.

This commit is contained in:
John Preston 2020-05-22 19:23:19 +04:00
parent 0834920db8
commit 3f26fc9f55
5 changed files with 40 additions and 16 deletions

View File

@ -721,9 +721,7 @@ int DocumentData::thumbnailByteSize() const {
} }
bool DocumentData::hasVideoThumbnail() const { bool DocumentData::hasVideoThumbnail() const {
return _videoThumbnailLocation.valid() return _videoThumbnailLocation.valid();
&& (_videoThumbnailLocation.width() > 0)
&& (_videoThumbnailLocation.height() > 0);
} }
bool DocumentData::videoThumbnailLoading() const { bool DocumentData::videoThumbnailLoading() const {

View File

@ -2482,15 +2482,20 @@ void Session::documentConvert(
DocumentData *Session::documentFromWeb( DocumentData *Session::documentFromWeb(
const MTPWebDocument &data, const MTPWebDocument &data,
const ImageLocation &thumbnailLocation) { const ImageLocation &thumbnailLocation,
const ImageLocation &videoThumbnailLocation) {
return data.match([&](const auto &data) { return data.match([&](const auto &data) {
return documentFromWeb(data, thumbnailLocation); return documentFromWeb(
data,
thumbnailLocation,
videoThumbnailLocation);
}); });
} }
DocumentData *Session::documentFromWeb( DocumentData *Session::documentFromWeb(
const MTPDwebDocument &data, const MTPDwebDocument &data,
const ImageLocation &thumbnailLocation) { const ImageLocation &thumbnailLocation,
const ImageLocation &videoThumbnailLocation) {
const auto result = document( const auto result = document(
rand_value<DocumentId>(), rand_value<DocumentId>(),
uint64(0), uint64(0),
@ -2500,7 +2505,7 @@ DocumentData *Session::documentFromWeb(
data.vmime_type().v, data.vmime_type().v,
QByteArray(), QByteArray(),
ImageWithLocation{ .location = thumbnailLocation }, ImageWithLocation{ .location = thumbnailLocation },
ImageWithLocation(), ImageWithLocation{ .location = videoThumbnailLocation },
MTP::maindc(), MTP::maindc(),
int32(0)); // data.vsize().v int32(0)); // data.vsize().v
result->setWebLocation(WebFileLocation( result->setWebLocation(WebFileLocation(
@ -2511,7 +2516,8 @@ DocumentData *Session::documentFromWeb(
DocumentData *Session::documentFromWeb( DocumentData *Session::documentFromWeb(
const MTPDwebDocumentNoProxy &data, const MTPDwebDocumentNoProxy &data,
const ImageLocation &thumbnailLocation) { const ImageLocation &thumbnailLocation,
const ImageLocation &videoThumbnailLocation) {
const auto result = document( const auto result = document(
rand_value<DocumentId>(), rand_value<DocumentId>(),
uint64(0), uint64(0),
@ -2521,7 +2527,7 @@ DocumentData *Session::documentFromWeb(
data.vmime_type().v, data.vmime_type().v,
QByteArray(), QByteArray(),
ImageWithLocation{ .location = thumbnailLocation }, ImageWithLocation{ .location = thumbnailLocation },
ImageWithLocation(), ImageWithLocation{ .location = videoThumbnailLocation },
MTP::maindc(), MTP::maindc(),
int32(0)); // data.vsize().v int32(0)); // data.vsize().v
result->setContentUrl(qs(data.vurl())); result->setContentUrl(qs(data.vurl()));

View File

@ -508,7 +508,8 @@ public:
const MTPDocument &data); const MTPDocument &data);
[[nodiscard]] DocumentData *documentFromWeb( [[nodiscard]] DocumentData *documentFromWeb(
const MTPWebDocument &data, const MTPWebDocument &data,
const ImageLocation &thumbnailLocation); const ImageLocation &thumbnailLocation,
const ImageLocation &videoThumbnailLocation);
[[nodiscard]] not_null<WebPageData*> webpage(WebPageId id); [[nodiscard]] not_null<WebPageData*> webpage(WebPageId id);
not_null<WebPageData*> processWebpage(const MTPWebPage &data); not_null<WebPageData*> processWebpage(const MTPWebPage &data);
@ -760,10 +761,12 @@ private:
int32 size); int32 size);
DocumentData *documentFromWeb( DocumentData *documentFromWeb(
const MTPDwebDocument &data, const MTPDwebDocument &data,
const ImageLocation &thumbnailLocation); const ImageLocation &thumbnailLocation,
const ImageLocation &videoThumbnailLocation);
DocumentData *documentFromWeb( DocumentData *documentFromWeb(
const MTPDwebDocumentNoProxy &data, const MTPDwebDocumentNoProxy &data,
const ImageLocation &thumbnailLocation); const ImageLocation &thumbnailLocation,
const ImageLocation &videoThumbnailLocation);
void webpageApplyFields( void webpageApplyFields(
not_null<WebPageData*> page, not_null<WebPageData*> page,

View File

@ -133,11 +133,12 @@ int Gif::resizeGetHeight(int width) {
void Gif::paint(Painter &p, const QRect &clip, const PaintContext *context) const { void Gif::paint(Painter &p, const QRect &clip, const PaintContext *context) const {
const auto document = getShownDocument(); const auto document = getShownDocument();
const auto displayLoading = document->displayLoading();
ensureDataMediaCreated(document); ensureDataMediaCreated(document);
const auto preview = Data::VideoPreviewState(_dataMedia.get()); const auto preview = Data::VideoPreviewState(_dataMedia.get());
preview.automaticLoad(fileOrigin()); preview.automaticLoad(fileOrigin());
const auto displayLoading = !preview.usingThumbnail()
&& document->displayLoading();
const auto loaded = preview.loaded(); const auto loaded = preview.loaded();
const auto loading = preview.loading(); const auto loading = preview.loading();
if (loaded if (loaded

View File

@ -26,6 +26,8 @@ https://github.com/telegramdesktop/tdesktop/blob/master/LEGAL
namespace InlineBots { namespace InlineBots {
namespace { namespace {
const auto kVideoThumbMime = "video/mp4"_q;
QString GetContentUrl(const MTPWebDocument &document) { QString GetContentUrl(const MTPWebDocument &document) {
switch (document.type()) { switch (document.type()) {
case mtpc_webDocument: case mtpc_webDocument:
@ -84,8 +86,19 @@ std::unique_ptr<Result> Result::create(
result->_title = qs(r.vtitle().value_or_empty()); result->_title = qs(r.vtitle().value_or_empty());
result->_description = qs(r.vdescription().value_or_empty()); result->_description = qs(r.vdescription().value_or_empty());
result->_url = qs(r.vurl().value_or_empty()); result->_url = qs(r.vurl().value_or_empty());
if (const auto thumb = r.vthumb()) { const auto thumbMime = [&] {
result->_thumb = Images::Create(*thumb, result->thumbBox()); if (const auto thumb = r.vthumb()) {
return thumb->match([&](const auto &data) {
return data.vmime_type().v;
});
}
return QByteArray();
}();
const auto imageThumb = !thumbMime.isEmpty()
&& (thumbMime != kVideoThumbMime);
const auto videoThumb = !thumbMime.isEmpty() && !imageThumb;
if (imageThumb) {
result->_thumb = Images::Create(*r.vthumb(), result->thumbBox());
} }
if (const auto content = r.vcontent()) { if (const auto content = r.vcontent()) {
result->_content_url = GetContentUrl(*content); result->_content_url = GetContentUrl(*content);
@ -97,7 +110,10 @@ std::unique_ptr<Result> Result::create(
} else { } else {
result->_document = Auth().data().documentFromWeb( result->_document = Auth().data().documentFromWeb(
result->adjustAttributes(*content), result->adjustAttributes(*content),
(r.vthumb() (imageThumb
? Images::FromWebDocument(*r.vthumb())
: ImageLocation()),
(videoThumb
? Images::FromWebDocument(*r.vthumb()) ? Images::FromWebDocument(*r.vthumb())
: ImageLocation())); : ImageLocation()));
} }