Removed App:wnd for opening settings.

Removed unused App::showSettings from facades.
This commit is contained in:
23rd 2021-02-03 04:58:27 +03:00 committed by John Preston
parent 019e691fbb
commit 1f80c297ec
9 changed files with 31 additions and 20 deletions

View File

@ -346,6 +346,7 @@ bool ResolveSettings(
if (!controller) {
return false;
}
controller->window().activate();
const auto section = match->captured(1).mid(1).toLower();
if (section.isEmpty()) {
controller->window().showSettings();

View File

@ -229,12 +229,6 @@ void searchByHashtag(const QString &tag, PeerData *inPeer) {
}
}
void showSettings() {
if (auto w = App::wnd()) {
w->showSettings();
}
}
} // namespace App
namespace Ui {

View File

@ -48,7 +48,6 @@ void activateBotCommand(
int row,
int column);
void searchByHashtag(const QString &tag, PeerData *inPeer);
void showSettings();
} // namespace App

View File

@ -121,8 +121,6 @@ Widget::Widget(
_next->entity()->setClickedCallback([=] { getStep()->submit(); });
_settings->entity()->setClickedCallback([] { App::wnd()->showSettings(); });
if (_changeLanguage) {
_changeLanguage->finishAnimating();
}
@ -153,6 +151,10 @@ Widget::Widget(
}
}
rpl::producer<> Widget::showSettingsRequested() const {
return _settings->entity()->clicks() | rpl::to_empty;
}
not_null<Media::Player::FloatDelegate*> Widget::floatPlayerDelegate() {
return static_cast<Media::Player::FloatDelegate*>(this);
}

View File

@ -99,6 +99,8 @@ public:
void setInnerFocus();
[[nodiscard]] rpl::producer<> showSettingsRequested() const;
~Widget();
protected:

View File

@ -289,6 +289,11 @@ void MainWindow::setupIntro(Intro::EnterPoint point) {
destroyLayer();
auto created = object_ptr<Intro::Widget>(bodyWidget(), &account(), point);
created->showSettingsRequested(
) | rpl::start_with_next([=] {
showSettings();
}, created->lifetime());
clearWidgets();
_intro = std::move(created);
if (_passcodeLock) {
@ -342,9 +347,6 @@ void MainWindow::setupMain() {
}
void MainWindow::showSettings() {
if (isHidden()) {
showFromTray();
}
if (_passcodeLock) {
return;
}

View File

@ -1043,8 +1043,11 @@ void MainWindow::createGlobalMenu() {
auto prefs = edit->addAction(
tr::lng_mac_menu_preferences(tr::now),
App::wnd(),
[=] { App::wnd()->showSettings(); },
this,
[=] {
ensureWindowShown();
controller().showSettings();
},
QKeySequence(Qt::ControlModifier | Qt::Key_Comma));
prefs->setMenuRole(QAction::PreferencesRole);

View File

@ -699,10 +699,18 @@ void MainWindow::createGlobalMenu() {
about->setMenuRole(QAction::AboutQtRole);
main->addSeparator();
QAction *prefs = main->addAction(tr::lng_mac_menu_preferences(tr::now), App::wnd(), [=] {
App::wnd()->showSettings();
}, QKeySequence(Qt::ControlModifier | Qt::Key_Comma));
prefs->setMenuRole(QAction::PreferencesRole);
{
auto callback = [=] {
ensureWindowShown();
controller().showSettings();
};
main->addAction(
tr::lng_mac_menu_preferences(tr::now),
this,
std::move(callback),
QKeySequence(Qt::ControlModifier | Qt::Key_Comma))
->setMenuRole(QAction::PreferencesRole);
}
QMenu *file = psMainMenu.addMenu(tr::lng_mac_menu_file(tr::now));
psLogout = file->addAction(tr::lng_mac_menu_logout(tr::now));

View File

@ -930,8 +930,8 @@ void MainMenu::refreshMenu() {
_controller->session().supportTemplates().reload();
}, &st::mainMenuReload, &st::mainMenuReloadOver);
}
_menu->addAction(tr::lng_menu_settings(tr::now), [] {
App::wnd()->showSettings();
_menu->addAction(tr::lng_menu_settings(tr::now), [=] {
controller->showSettings();
}, &st::mainMenuSettings, &st::mainMenuSettingsOver);
_nightThemeAction = std::make_shared<QPointer<QAction>>();