selinux/libsemanage/tests/test_utilities.c
Nicolas Iooss 74c5e551ca libsemanage/tests: check that string pointers are not NULL before comparing them
This silences many issues reported by Infer static analyzer about
possible NULL pointer dereferences.

Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>
2019-10-01 14:33:04 -04:00

348 lines
8.5 KiB
C

/* Authors: Mark Goldman <mgoldman@tresys.com>
*
* Copyright (C) 2007 Tresys Technology, LLC
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2.1 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this library; if not, write to the Free Software
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/
/* The purpose of this file is to provide unit tests of the functions in:
*
* libsemanage/src/utilities.c
*
*/
#include <CUnit/Basic.h>
#include <CUnit/Console.h>
#include <CUnit/TestDB.h>
#include <utilities.h>
#include <stdio.h>
#include <getopt.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
#include "utilities.h"
void test_semanage_is_prefix(void);
void test_semanage_split_on_space(void);
void test_semanage_split(void);
void test_semanage_list(void);
void test_semanage_str_count(void);
void test_semanage_rtrim(void);
void test_semanage_str_replace(void);
void test_semanage_findval(void);
void test_slurp_file_filter(void);
char fname[] = {
'T', 'E', 'S', 'T', '_', 'T', 'E', 'M', 'P', '_', 'X', 'X', 'X', 'X',
'X', 'X', '\0'
};
int fd;
FILE *fptr;
int semanage_utilities_test_init(void)
{
fd = mkstemp(fname);
if (fd < 0) {
perror("test_semanage_findval: ");
CU_FAIL_FATAL
("Error opening temporary file, test cannot start.");
}
fptr = fdopen(fd, "w+");
if (!fptr) {
perror("test_semanage_findval file: ");
CU_FAIL_FATAL("Error opening file stream, test cannot start.");
}
fprintf(fptr, "one\ntwo\nthree\nsigma=foo\n#boo\n#bar\n");
rewind(fptr);
return 0;
}
int semanage_utilities_test_cleanup(void)
{
unlink(fname);
return 0;
}
int semanage_utilities_add_tests(CU_pSuite suite)
{
if (NULL == CU_add_test(suite, "semanage_is_prefix",
test_semanage_is_prefix)) {
goto err;
}
if (NULL == CU_add_test(suite, "semanage_split_on_space",
test_semanage_split_on_space)) {
goto err;
}
if (NULL == CU_add_test(suite, "semanage_split", test_semanage_split)) {
goto err;
}
if (NULL == CU_add_test(suite, "semanage_list", test_semanage_list)) {
goto err;
}
if (NULL == CU_add_test(suite, "semanage_str_count",
test_semanage_str_count)) {
goto err;
}
if (NULL == CU_add_test(suite, "semanage_rtrim", test_semanage_rtrim)) {
goto err;
}
if (NULL == CU_add_test(suite, "semanage_str_replace",
test_semanage_str_replace)) {
goto err;
}
if (NULL == CU_add_test(suite, "semanage_findval",
test_semanage_findval)) {
goto err;
}
if (NULL == CU_add_test(suite, "slurp_file_filter",
test_slurp_file_filter)) {
goto err;
}
return 0;
err:
CU_cleanup_registry();
return CU_get_error();
}
void test_semanage_is_prefix(void)
{
const char *str = "some string";
const char *pre = "some";
const char *not_pre = "not this";
CU_ASSERT_TRUE(semanage_is_prefix(str, pre));
CU_ASSERT_TRUE(semanage_is_prefix(str, ""));
CU_ASSERT_TRUE(semanage_is_prefix(str, NULL));
CU_ASSERT_FALSE(semanage_is_prefix(str, not_pre));
}
void test_semanage_split_on_space(void)
{
char *str = strdup(" foo bar baz");
char *temp;
if (!str) {
CU_FAIL
("semanage_split_on_space: unable to perform test, no memory");
return;
}
temp = semanage_split_on_space(str);
CU_ASSERT_PTR_NOT_NULL_FATAL(temp);
CU_ASSERT_STRING_EQUAL(temp, "bar baz");
free(str);
str = temp;
temp = semanage_split_on_space(str);
CU_ASSERT_PTR_NOT_NULL_FATAL(temp);
CU_ASSERT_STRING_EQUAL(temp, "baz");
free(str);
str = temp;
temp = semanage_split_on_space(str);
CU_ASSERT_PTR_NOT_NULL_FATAL(temp);
CU_ASSERT_STRING_EQUAL(temp, "");
free(str);
free(temp);
}
void test_semanage_split(void)
{
char *str = strdup("foo1 foo2 foo:bar:");
char *temp;
if (!str) {
CU_FAIL
("semanage_split_on_space: unable to perform test, no memory");
return;
}
temp = semanage_split(str, NULL);
CU_ASSERT_PTR_NOT_NULL_FATAL(temp);
CU_ASSERT_STRING_EQUAL(temp, "foo2 foo:bar:");
free(str);
str = temp;
temp = semanage_split(str, "");
CU_ASSERT_PTR_NOT_NULL_FATAL(temp);
CU_ASSERT_STRING_EQUAL(temp, "foo:bar:");
free(str);
str = temp;
temp = semanage_split(str, ":");
CU_ASSERT_PTR_NOT_NULL_FATAL(temp);
CU_ASSERT_STRING_EQUAL(temp, "bar:");
free(str);
str = temp;
temp = semanage_split(str, ":");
CU_ASSERT_PTR_NOT_NULL_FATAL(temp);
CU_ASSERT_STRING_EQUAL(temp, "");
free(str);
free(temp);
}
void test_semanage_list(void)
{
semanage_list_t *list = NULL;
semanage_list_t *ptr = NULL;
char *temp = NULL;
int retval = 0;
CU_ASSERT_FALSE(semanage_list_push(&list, "foo"));
CU_ASSERT_PTR_NOT_NULL(list);
CU_ASSERT_FALSE(semanage_list_push(&list, "bar"));
CU_ASSERT_FALSE(semanage_list_push(&list, "gonk"));
CU_ASSERT_FALSE(semanage_list_push(&list, "zebra"));
for (ptr = list; ptr; ptr = ptr->next)
retval++;
CU_ASSERT_EQUAL(retval, 4);
temp = semanage_list_pop(&list);
CU_ASSERT_STRING_EQUAL(temp, "zebra");
CU_ASSERT_FALSE(semanage_list_push(&list, temp));
free(temp);
temp = NULL;
retval = 0;
for (ptr = list; ptr; ptr = ptr->next)
retval++;
CU_ASSERT_EQUAL(retval, 4);
retval = semanage_list_sort(&list);
if (retval) {
CU_FAIL
("semanage_list_sort: error unrelated to sort (memory?)");
goto past_sort;
}
CU_ASSERT_STRING_EQUAL(list->data, "bar");
CU_ASSERT_STRING_EQUAL(list->next->data, "foo");
CU_ASSERT_STRING_EQUAL(list->next->next->data, "gonk");
CU_ASSERT_STRING_EQUAL(list->next->next->next->data, "zebra");
past_sort:
ptr = semanage_list_find(list, "zebra");
CU_ASSERT_PTR_NOT_NULL(ptr);
ptr = semanage_list_find(list, "bogus");
CU_ASSERT_PTR_NULL(ptr);
semanage_list_destroy(&list);
CU_ASSERT_PTR_NULL(list);
}
void test_semanage_str_count(void)
{
const char *test_string = "abaababbaaaba";
CU_ASSERT_EQUAL(semanage_str_count(test_string, 'z'), 0);
CU_ASSERT_EQUAL(semanage_str_count(test_string, 'a'), 8);
CU_ASSERT_EQUAL(semanage_str_count(test_string, 'b'), 5);
}
void test_semanage_rtrim(void)
{
char *str = strdup("/blah/foo/bar/baz/");
CU_ASSERT_PTR_NOT_NULL_FATAL(str);
semanage_rtrim(str, 'Q');
CU_ASSERT_STRING_EQUAL(str, "/blah/foo/bar/baz/");
semanage_rtrim(str, 'a');
CU_ASSERT_STRING_EQUAL(str, "/blah/foo/bar/b");
semanage_rtrim(str, '/');
CU_ASSERT_STRING_EQUAL(str, "/blah/foo/bar");
free(str);
}
void test_semanage_str_replace(void)
{
const char *test_str = "Hello, I am %{USERNAME} and my id is %{USERID}";
char *str1, *str2;
str1 = semanage_str_replace("%{USERNAME}", "root", test_str, 0);
CU_ASSERT_STRING_EQUAL(str1, "Hello, I am root and my id is %{USERID}");
str2 = semanage_str_replace("%{USERID}", "0", str1, 1);
CU_ASSERT_STRING_EQUAL(str2, "Hello, I am root and my id is 0");
free(str1);
free(str2);
str1 = semanage_str_replace(":(", ";)", "Test :( :) ! :(:(:))(:(", 0);
CU_ASSERT_STRING_EQUAL(str1, "Test ;) :) ! ;);):))(;)");
free(str1);
str1 = semanage_str_replace(":(", ";)", "Test :( :) ! :(:(:))(:(", 3);
CU_ASSERT_STRING_EQUAL(str1, "Test ;) :) ! ;);):))(:(");
free(str1);
str1 = semanage_str_replace("", "empty search string", "test", 0);
CU_ASSERT_EQUAL(str1, NULL);
str1 = semanage_str_replace("a", "", "abracadabra", 0);
CU_ASSERT_STRING_EQUAL(str1, "brcdbr");
free(str1);
}
void test_semanage_findval(void)
{
char *tok;
if (!fptr) {
CU_FAIL_FATAL("Temporary file was not created, aborting test.");
}
tok = semanage_findval(fname, "one", NULL);
CU_ASSERT_PTR_NOT_NULL_FATAL(tok);
CU_ASSERT_STRING_EQUAL(tok, "");
free(tok);
rewind(fptr);
tok = semanage_findval(fname, "one", "");
CU_ASSERT_PTR_NOT_NULL_FATAL(tok);
CU_ASSERT_STRING_EQUAL(tok, "");
free(tok);
rewind(fptr);
tok = semanage_findval(fname, "sigma", "=");
CU_ASSERT_PTR_NOT_NULL_FATAL(tok);
CU_ASSERT_STRING_EQUAL(tok, "foo");
free(tok);
}
int PREDICATE(const char *str)
{
return semanage_is_prefix(str, "#");
}
void test_slurp_file_filter(void)
{
semanage_list_t *data, *tmp;
int cnt = 0;
if (!fptr) {
CU_FAIL_FATAL("Temporary file was not created, aborting test.");
}
rewind(fptr);
data = semanage_slurp_file_filter(fptr, PREDICATE);
CU_ASSERT_PTR_NOT_NULL_FATAL(data);
for (tmp = data; tmp; tmp = tmp->next)
cnt++;
CU_ASSERT_EQUAL(cnt, 2);
semanage_list_destroy(&data);
}