Go to file
James Carter 67a8dc8117 libsepol/cil: Allow duplicate optional blocks in most cases
The commit d155b410d4 (libsepol/cil:
Check for duplicate blocks, optionals, and macros) fixed a bug
that allowed duplicate blocks, optionals, and macros with the same
name in the same namespace. For blocks and macros, a duplicate
is always a problem, but optional block names are only used for
in-statement resolution. If no in-statement refers to an optional
block, then it does not matter if more than one with same name
exists.

One easy way to generate multiple optional blocks with the same
name declaration is to call a macro with an optional block multiple
times in the same namespace.

As an example, here is a portion of CIL policy
  (macro m1 ((type t))
    (optional op1
      (allow t self (CLASS (PERM)))
    )
  )
  (type t1)
  (call m1 (t1))
  (type t2)
  (call m1 (t2))
This will result in two optional blocks with the name op1.

There are three parts to allowing multiple optional blocks with
the same name declaration.

1) Track an optional block's enabled status in a different way.

   One hinderance to allowing multiple optional blocks with the same
   name declaration is that they cannot share the same datum. This is
   because the datum is used to get the struct cil_optional which has
   the enabled field and each block's enabled status is independent of
   the others.

   Remove the enabled field from struct cil_optional, so it only contains
   the datum. Use a stack to track which optional blocks are being
   disabled, so they can be deleted in the right order.

2) Allow multiple declarations of optional blocks.

   Update cil_allow_multiple_decls() so that a flavor of CIL_OPTIONAL
   will return CIL_TRUE. Also remove the check in cil_copy_optional().

3) Check if an in-statement refers to an optional with multiple
   declarations and exit with an error if it does.

Signed-off-by: James Carter <jwcart2@gmail.com>
Acked-by: Nicolas Iooss <nicolas.iooss@m4x.org>
2021-06-24 10:02:26 -04:00
.circleci CircleCI: run scan-build and publish its results automatically 2019-09-26 09:45:47 -04:00
.github/workflows GitHub Actions: run SELinux testsuite in Fedora virtual machine 2021-01-20 16:45:12 +01:00
checkpolicy checkpolicy: Do not automatically upgrade when using "-b" flag 2021-03-15 21:52:03 +01:00
dbus Update VERSIONs to 3.2 for release. 2021-03-04 16:42:59 +01:00
gui Update VERSIONs to 3.2 for release. 2021-03-04 16:42:59 +01:00
libselinux selinux.8: document how mount flag nosuid affects SELinux 2021-06-18 16:44:50 +02:00
libsemanage libsemanage: fix use-after-free in parse_module_store() 2021-06-18 16:48:57 +02:00
libsepol libsepol/cil: Allow duplicate optional blocks in most cases 2021-06-24 10:02:26 -04:00
mcstrans Update VERSIONs to 3.2 for release. 2021-03-04 16:42:59 +01:00
policycoreutils fixfiles: do not exclude /dev and /run in -C mode 2021-05-12 09:36:16 +02:00
python Update VERSIONs to 3.2 for release. 2021-03-04 16:42:59 +01:00
restorecond Update VERSIONs to 3.2 for release. 2021-03-04 16:42:59 +01:00
sandbox Update VERSIONs to 3.2 for release. 2021-03-04 16:42:59 +01:00
scripts scripts/ci: use F34 image instead of F33 2021-05-18 10:05:03 +02:00
secilc secilc/test: Add test for anonymous args 2021-06-22 09:33:28 -04:00
semodule-utils Update VERSIONs to 3.2 for release. 2021-03-04 16:42:59 +01:00
.gitignore restorecond: Add gitignore 2016-11-16 11:20:05 -05:00
.travis.yml travis: run only selinux-testsuite 2020-11-27 15:37:31 +01:00
CleanSpec.mk Add empty top level Android.mk / CleanSpec.mk files 2015-04-16 07:54:09 -04:00
CONTRIBUTING.md Fix many misspellings 2019-09-18 22:47:35 +02:00
lgtm.yml Add configuration file for lgtm.com 2019-09-18 08:24:11 -04:00
Makefile Makefile: always build with -fno-common 2020-01-27 10:51:23 -05:00
README.md README: start a section for documenting CFLAGS 2020-06-18 19:31:08 +02:00
VERSION Update VERSIONs to 3.2 for release. 2021-03-04 16:42:59 +01:00

SELinux Userspace

SELinux logo Build Status

Please submit all bug reports and patches to selinux@vger.kernel.org.

Subscribe by sending "subscribe selinux" in the body of an email to majordomo@vger.kernel.org.

Archive of this mailing list is available on https://lore.kernel.org/selinux/.

Installation

SELinux libraries and tools are packaged in several Linux distributions:

Building and testing

Build dependencies on Fedora:

# For C libraries and programs
dnf install \
    audit-libs-devel \
    bison \
    bzip2-devel \
    CUnit-devel \
    diffutils \
    flex \
    gcc \
    gettext \
    glib2-devel \
    make \
    libcap-devel \
    libcap-ng-devel \
    pam-devel \
    pcre-devel \
    xmlto

# For Python and Ruby bindings
dnf install \
    python3-devel \
    ruby-devel \
    swig

Build dependencies on Debian:

# For C libraries and programs
apt-get install --no-install-recommends --no-install-suggests \
    bison \
    flex \
    gawk \
    gcc \
    gettext \
    make \
    libaudit-dev \
    libbz2-dev \
    libcap-dev \
    libcap-ng-dev \
    libcunit1-dev \
    libglib2.0-dev \
    libpcre3-dev \
    pkgconf \
    python3 \
    python3-distutils \
    systemd \
    xmlto

# For Python and Ruby bindings
apt-get install --no-install-recommends --no-install-suggests \
    python3-dev \
    ruby-dev \
    swig

To build and install everything under a private directory, run:

make clean distclean

make DESTDIR=~/obj install install-rubywrap install-pywrap

On Debian PYTHON_SETUP_ARGS=--install-layout=deb needs to be set when installing the python wrappers in order to create the correct python directory structure.

To run tests with the built libraries and programs, several paths (relative to $DESTDIR) need to be added to variables $LD_LIBRARY_PATH, $PATH and $PYTHONPATH. This can be done using ./scripts/env_use_destdir:

DESTDIR=~/obj ./scripts/env_use_destdir make test

Some tests require the reference policy to be installed (for example in python/sepolgen). In order to run these ones, instructions similar to the ones in section install of ./.travis.yml can be executed.

To install as the default system libraries and binaries (overwriting any previously installed ones - dangerous!), on x86_64, run:

make LIBDIR=/usr/lib64 SHLIBDIR=/lib64 install install-pywrap relabel

or on x86 (32-bit), run:

make install install-pywrap relabel

This may render your system unusable if the upstream SELinux userspace lacks library functions or other dependencies relied upon by your distribution. If it breaks, you get to keep both pieces.

Setting CFLAGS

Setting CFLAGS during the make process will cause the omission of many defaults. While the project strives to provide a reasonable set of default flags, custom CFLAGS could break the build, or have other undesired changes on the build output. Thus, be very careful when setting CFLAGS. CFLAGS that are encouraged to be set when overriding are:

  • -fno-semantic-interposition for gcc or compilers that do not do this. clang does this by default. clang-10 and up will support passing this flag, but ignore it. Previous clang versions fail.

macOS

To install libsepol on macOS (mainly for policy analysis):

cd libsepol; make PREFIX=/usr/local install

This requires GNU coreutils:

brew install coreutils