Go to file
James Carter 2b3dd2c77d libsepol/cil: Do not call ebitmap_init twice for an ebitmap
While it does no harm to call ebitmap_init() twice for an ebitmap,
since it is just memsetting the ebitmap to 0, it is poor practice.

In the function cil_type_matches() in cil_find.c, either ebitmap_and()
or ebitmap_set_bit() will be called. The function ebitmap_and() will
call ebitmap_init() on the destination ebitmap, but ebitmap_set_bit()
does not.

Instead of calling ebitmap_init() before the call to cil_type_matches(),
let cil_type_matches() make the call if it is going to call
ebitmap_set_bit(). It can also call ebitmap_destroy() on an error.

Since we are removing the call to ebitmap_init() in cil_self_match_any(),
cleanup some other things in the function (like using the FLAVOR()
macro and using ebitmap_is_empty()).

Signed-off-by: James Carter <jwcart2@gmail.com>
Acked-by: Petr Lautrbach <lautrbach@redhat.com>
2023-08-16 13:33:50 -04:00
.circleci CircleCI: do not add Debian-specific parameter when invoking setup.py 2022-07-06 15:57:21 -04:00
.github/workflows ci: bump to python 3.11 in GitHub Actions 2023-02-01 16:48:21 +01:00
checkpolicy Do not automatically install Russian translations 2023-08-16 13:33:47 -04:00
dbus Update VERSIONs to 3.5 for release. 2023-02-23 05:16:11 -08:00
gui Do not automatically install Russian translations 2023-08-16 13:33:47 -04:00
libselinux Do not automatically install Russian translations 2023-08-16 13:33:47 -04:00
libsemanage Do not automatically install Russian translations 2023-08-16 13:33:47 -04:00
libsepol libsepol/cil: Do not call ebitmap_init twice for an ebitmap 2023-08-16 13:33:50 -04:00
mcstrans Do not automatically install Russian translations 2023-08-16 13:33:47 -04:00
policycoreutils Do not automatically install Russian translations 2023-08-16 13:33:47 -04:00
python Do not automatically install Russian translations 2023-08-16 13:33:47 -04:00
restorecond Do not automatically install Russian translations 2023-08-16 13:33:47 -04:00
sandbox Do not automatically install Russian translations 2023-08-16 13:33:47 -04:00
scripts scripts/ci: install rdma-core-devel for selinux-testsuite 2023-03-20 14:44:05 +01:00
secilc secilc: add check for malloc in secilc 2023-08-04 13:52:55 -04:00
semodule-utils Do not automatically install Russian translations 2023-08-16 13:33:47 -04:00
.gitignore restorecond: Add gitignore 2016-11-16 11:20:05 -05:00
.travis.yml travis: run only selinux-testsuite 2020-11-27 15:37:31 +01:00
CleanSpec.mk Add empty top level Android.mk / CleanSpec.mk files 2015-04-16 07:54:09 -04:00
CONTRIBUTING.md Replace PCRE with PCRE2 build dependencies 2021-12-09 11:07:10 -05:00
lgtm.yml Add configuration file for lgtm.com 2019-09-18 08:24:11 -04:00
LICENSE docs: provide a top level LICENSE file 2022-10-05 08:20:38 -04:00
Makefile Enable missing prototypes 2022-04-20 14:03:44 -04:00
README.md Use pip install instead of setup.py install 2022-12-16 17:09:27 -05:00
SECURITY.md docs: Add GPG fingerprints 2022-10-24 08:26:05 -04:00
VERSION Update VERSIONs to 3.5 for release. 2023-02-23 05:16:11 -08:00

SELinux Userspace

SELinux logo Run Tests Run SELinux testsuite in a virtual machine OSS-Fuzz Status CIFuzz Status

SELinux is a flexible Mandatory Access Control (MAC) system built into the Linux Kernel. SELinux provides administrators with a comprehensive access control mechanism that enables greater access granularity over the existing Linux Discretionary Access Controls (DAC) and is present in many major Linux distributions. This repository contains the sources for the SELinux utilities and system libraries which allow for the configuration and management of an SELinux-based system.

Please submit all bug reports and patches to the selinux@vger.kernel.org mailing list. You can subscribe by sending "subscribe selinux" in the body of an email to majordomo@vger.kernel.org. Archives of the mailing list are available at https://lore.kernel.org/selinux.

Installation

SELinux libraries and tools are packaged in several Linux distributions:

Building and testing

Build dependencies on Fedora:

# For C libraries and programs
dnf install \
    audit-libs-devel \
    bison \
    bzip2-devel \
    CUnit-devel \
    diffutils \
    flex \
    gcc \
    gettext \
    glib2-devel \
    make \
    libcap-devel \
    libcap-ng-devel \
    pam-devel \
    pcre2-devel \
    xmlto

# For Python and Ruby bindings
dnf install \
    python3-devel \
    python3-pip \
    python3-setuptools \
    python3-wheel \
    ruby-devel \
    swig

Build dependencies on Debian:

# For C libraries and programs
apt-get install --no-install-recommends --no-install-suggests \
    bison \
    flex \
    gawk \
    gcc \
    gettext \
    make \
    libaudit-dev \
    libbz2-dev \
    libcap-dev \
    libcap-ng-dev \
    libcunit1-dev \
    libglib2.0-dev \
    libpcre2-dev \
    pkgconf \
    python3 \
    systemd \
    xmlto

# For Python and Ruby bindings
apt-get install --no-install-recommends --no-install-suggests \
    python3-dev \
    python3-pip \
    python3-setuptools \
    python3-wheel \
    ruby-dev \
    swig

To build and install everything under a private directory, run:

make clean distclean

make DESTDIR=~/obj install install-rubywrap install-pywrap

On Debian PYTHON_SETUP_ARGS='--install-option "--install-layout=deb"' needs to be set when installing the python wrappers in order to create the correct python directory structure.

To run tests with the built libraries and programs, several paths (relative to $DESTDIR) need to be added to variables $LD_LIBRARY_PATH, $PATH and $PYTHONPATH. This can be done using ./scripts/env_use_destdir:

DESTDIR=~/obj ./scripts/env_use_destdir make test

Some tests require the reference policy to be installed (for example in python/sepolgen). In order to run these ones, instructions similar to the ones in section install of ./.travis.yml can be executed.

To install as the default system libraries and binaries (overwriting any previously installed ones - dangerous!), on x86_64, run:

make LIBDIR=/usr/lib64 SHLIBDIR=/lib64 install install-pywrap relabel

or on x86 (32-bit), run:

make install install-pywrap relabel

This may render your system unusable if the upstream SELinux userspace lacks library functions or other dependencies relied upon by your distribution. If it breaks, you get to keep both pieces.

Setting CFLAGS

Setting CFLAGS during the make process will cause the omission of many defaults. While the project strives to provide a reasonable set of default flags, custom CFLAGS could break the build, or have other undesired changes on the build output. Thus, be very careful when setting CFLAGS. CFLAGS that are encouraged to be set when overriding are:

  • -fno-semantic-interposition for gcc or compilers that do not do this. clang does this by default. clang-10 and up will support passing this flag, but ignore it. Previous clang versions fail.

macOS

To install libsepol on macOS (mainly for policy analysis):

cd libsepol; make PREFIX=/usr/local install

This requires GNU coreutils:

brew install coreutils