mirror of
https://github.com/SELinuxProject/selinux
synced 2025-02-17 10:06:51 +00:00
Josh asked me to look through the autotools work. Here are the issues I have found with the libsepol package: 1. In configure.ac, the AC_INIT macro is not filled out; 2. Within libsepol/src/Makefile.am, the internal header files are not assigned to COMMONSRC; 3. Within utils/Makefile.am, the builddir for utils is not necessarily sibling to src; 4. libsepol is being installed to $(LIBDIR). In this case, it should default to the system library. 5. Most importantly, the unit tests are not built nor run. I resolved the first three issues with the patch below. After applying the changes, 'make distcheck' succeeded for me. For the fourth issue, consider adding to configure.ac an AC_ARG_WITH, "--with-libsepol-dir", that sets the location to install libsepol.so. This would default to /lib or /lib64, depending upon the target architecture. For the fifth issue, the enable_tests variable ought to default to yes, and then conditional compiliation be used to actually compile and run those tests. -- Jason Tang / jtang@tresys.com |
||
---|---|---|
.. | ||
chkcon.c | ||
Makefile.am |