RepoMirrors/selinux
1
0
Fork 0
mirror of https://github.com/SELinuxProject/selinux synced 2024-12-19 04:34:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

python/sepolgen: remove buggy code

Browse Source 
av_extract_params() may call __param_insert() with only 2 parameters
instead of 4, which has no chance to work fine. Moreover it uses "PERM",
which is undefined. As nobody complained about this code, it seems to be
dead, so remove it.

This issue has been found using flake8. This Python linter reported:

    python/sepolgen/src/sepolgen/interfaces.py:158:37: F821 undefined
    name 'PERM'

While at it, fix a typo in a comment.

Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>
This commit is contained in:
Nicolas Iooss 2018-08-04 14:38:24 +02:00
parent 20db6a5a73
commit e6dd227272
No known key found for this signature in database
GPG Key ID: C191415F340DAAA0
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
python/sepolgen/src/sepolgen/interfaces.py
View File

@ -112,7 +112,7 @@ def av_extract_params(av, params):
entries in the dict, but if an unresolvable conflict is
found it is reported to the caller.
The goal here is to figure out how interface paramaters are
The goal here is to figure out how interface parameters are
actually used in the interface - e.g., that $1 is a domain used as
a SRC_TYPE. In general an interface will look like this:
@ -153,11 +153,6 @@ def av_extract_params(av, params):
if __param_insert(av.obj_class, refpolicy.OBJ_CLASS, av, params) == 1:
ret = 1
for perm in av.perms:
if access.is_idparam(perm):
if __param_insert(perm, PERM) == 1:
ret = 1
return ret
def role_extract_params(role, params):