RepoMirrors/selinux
1
0
Fork 0
mirror of https://github.com/SELinuxProject/selinux synced 2024-12-25 23:42:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

mcstrans: fix memory leaks reported by clang's static analyzer

Browse Source 
There are many memory leaks in mcstrans. Clean them up in order to
reduce the noise in clang's static analyzer report. Some are remaining,
because they are more complex to fix.

Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>
This commit is contained in:
Nicolas Iooss 2018-04-13 23:26:52 +02:00
parent f9a56ed765
commit d0ca433e21
No known key found for this signature in database
GPG Key ID: C191415F340DAAA0
1 changed files with 56 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

68
mcstrans/src/mcstrans.c
View File

@ -708,6 +708,7 @@ append(affix_t **affixes, const char *val) {
err: err:
log_error("allocation error %s", strerror(errno)); log_error("allocation error %s", strerror(errno));
free(affix);
return -1; return -1;
} }
@ -1517,8 +1518,10 @@ trans_context(const security_context_t incon, security_context_t *rcon) {
} else { } else {
trans = compute_trans_from_raw(range, domain); trans = compute_trans_from_raw(range, domain);
if (trans) if (trans)
if (add_cache(domain, range, trans) < 0) if (add_cache(domain, range, trans) < 0) {
free(range);
return -1; return -1;
}
} }
if (lrange && urange) { if (lrange && urange) {
@ -1526,12 +1529,15 @@ trans_context(const security_context_t incon, security_context_t *rcon) {
if (! ltrans) { if (! ltrans) {
ltrans = compute_trans_from_raw(lrange, domain); ltrans = compute_trans_from_raw(lrange, domain);
if (ltrans) { if (ltrans) {
if (add_cache(domain, lrange, ltrans) < 0) if (add_cache(domain, lrange, ltrans) < 0) {
free(range);
return -1; return -1;
}
} else { } else {
ltrans = strdup(lrange); ltrans = strdup(lrange);
if (! ltrans) { if (! ltrans) {
log_error("strdup failed %s", strerror(errno)); log_error("strdup failed %s", strerror(errno));
free(range);
return -1; return -1;
} }
} }
@ -1541,25 +1547,36 @@ trans_context(const security_context_t incon, security_context_t *rcon) {
if (! utrans) { if (! utrans) {
utrans = compute_trans_from_raw(urange, domain); utrans = compute_trans_from_raw(urange, domain);
if (utrans) { if (utrans) {
if (add_cache(domain, urange, utrans) < 0) if (add_cache(domain, urange, utrans) < 0) {
free(ltrans);
free(range);
return -1; return -1;
}
} else { } else {
utrans = strdup(urange); utrans = strdup(urange);
if (! utrans) { if (! utrans) {
log_error("strdup failed %s", strerror(errno)); log_error("strdup failed %s", strerror(errno));
return -1; free(ltrans);
} free(range);
} return -1;
}
}
} }
if (strcmp(ltrans, utrans) == 0) { if (strcmp(ltrans, utrans) == 0) {
if (asprintf(&trans, "%s", ltrans) < 0) { if (asprintf(&trans, "%s", ltrans) < 0) {
log_error("asprintf failed %s", strerror(errno)); log_error("asprintf failed %s", strerror(errno));
free(utrans);
free(ltrans);
free(range);
return -1; return -1;
} }
} else { } else {
if (asprintf(&trans, "%s-%s", ltrans, utrans) < 0) { if (asprintf(&trans, "%s-%s", ltrans, utrans) < 0) {
log_error("asprintf failed %s", strerror(errno)); log_error("asprintf failed %s", strerror(errno));
free(utrans);
free(ltrans);
free(range);
return -1; return -1;
} }
} }
@ -1629,13 +1646,17 @@ untrans_context(const security_context_t incon, security_context_t *rcon) {
if (!canonical) { if (!canonical) {
canonical = compute_trans_from_raw(raw, domain); canonical = compute_trans_from_raw(raw, domain);
if (canonical && strcmp(canonical, range)) if (canonical && strcmp(canonical, range))
if (add_cache(domain, raw, canonical) < 0) if (add_cache(domain, raw, canonical) < 0) {
free(range);
return -1; return -1;
}
} }
if (canonical) if (canonical)
free(canonical); free(canonical);
if (add_cache(domain, raw, range) < 0) if (add_cache(domain, raw, range) < 0) {
free(range);
return -1; return -1;
}
} else { } else {
log_debug("untrans_context unable to compute raw context %s\n", range); log_debug("untrans_context unable to compute raw context %s\n", range);
} }
@ -1650,17 +1671,24 @@ untrans_context(const security_context_t incon, security_context_t *rcon) {
if (!canonical) { if (!canonical) {
canonical = compute_trans_from_raw(lraw, domain); canonical = compute_trans_from_raw(lraw, domain);
if (canonical) if (canonical)
if (add_cache(domain, lraw, canonical) < 0) if (add_cache(domain, lraw, canonical) < 0) {
free(lraw);
free(range);
return -1; return -1;
}
} }
if (canonical) if (canonical)
free(canonical); free(canonical);
if (add_cache(domain, lraw, lrange) < 0) if (add_cache(domain, lraw, lrange) < 0) {
free(lraw);
free(range);
return -1; return -1;
}
} else { } else {
lraw = strdup(lrange); lraw = strdup(lrange);
if (! lraw) { if (! lraw) {
log_error("strdup failed %s", strerror(errno)); log_error("strdup failed %s", strerror(errno));
free(range);
return -1; return -1;
} }
} }
@ -1674,17 +1702,27 @@ untrans_context(const security_context_t incon, security_context_t *rcon) {
if (!canonical) { if (!canonical) {
canonical = compute_trans_from_raw(uraw, domain); canonical = compute_trans_from_raw(uraw, domain);
if (canonical) if (canonical)
if (add_cache(domain, uraw, canonical) < 0) if (add_cache(domain, uraw, canonical) < 0) {
free(uraw);
free(lraw);
free(range);
return -1; return -1;
} }
}
if (canonical) if (canonical)
free(canonical); free(canonical);
if (add_cache(domain, uraw, urange) < 0) if (add_cache(domain, uraw, urange) < 0) {
free(uraw);
free(lraw);
free(range);
return -1; return -1;
}
} else { } else {
uraw = strdup(urange); uraw = strdup(urange);
if (! uraw) { if (! uraw) {
log_error("strdup failed %s", strerror(errno)); log_error("strdup failed %s", strerror(errno));
free(lraw);
free(range);
return -1; return -1;
} }
} }
@ -1694,11 +1732,17 @@ untrans_context(const security_context_t incon, security_context_t *rcon) {
if (strcmp(lraw, uraw) == 0) { if (strcmp(lraw, uraw) == 0) {
if (asprintf(&raw, "%s", lraw) < 0) { if (asprintf(&raw, "%s", lraw) < 0) {
log_error("asprintf failed %s", strerror(errno)); log_error("asprintf failed %s", strerror(errno));
free(uraw);
free(lraw);
free(range);
return -1; return -1;
} }
} else { } else {
if (asprintf(&raw, "%s-%s", lraw, uraw) < 0) { if (asprintf(&raw, "%s-%s", lraw, uraw) < 0) {
log_error("asprintf failed %s", strerror(errno)); log_error("asprintf failed %s", strerror(errno));
free(uraw);
free(lraw);
free(range);
return -1; return -1;
} }
} }