RepoMirrors/selinux
1
0
Fork 0
mirror of https://github.com/SELinuxProject/selinux synced 2024-12-28 00:42:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

libselinux: procattr: return einval for <= 0 pid args.

Browse Source 
getpidcon documentation does not specify that a pid of 0 refers to the
current process, and getcon exists specifically to provide this
functionality, and getpidcon(getpid()) would provide it as well.
Disallow pid values <= 0 that may lead to unintended behavior in
userspace object managers.

Signed-off-by: Daniel Cashman <dcashman@android.com>
This commit is contained in:
dcashman 2016-02-23 12:24:00 -08:00 committed by Stephen Smalley
parent ece9a6db47
commit c7cf5d8aa0
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
libselinux/src/procattr.c
View File

@ -306,11 +306,21 @@ static int setprocattrcon(const char * context,
#define getpidattr_def(fn, attr) \
int get##fn##_raw(pid_t pid, char **c) \
{ \
return getprocattrcon_raw(c, pid, #attr); \
if (pid <= 0) { \
errno = EINVAL; \
return -1; \
} else { \
return getprocattrcon_raw(c, pid, #attr); \
} \
} \
int get##fn(pid_t pid, char **c) \
{ \
return getprocattrcon(c, pid, #attr); \
if (pid <= 0) { \
errno = EINVAL; \
return -1; \
} else { \
return getprocattrcon(c, pid, #attr); \
} \
}
all_selfattr_def(con, current)