From c14a86af9a2304175e54897634f808b42345325b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20G=C3=B6ttsche?= Date: Fri, 20 May 2022 14:51:07 +0200 Subject: [PATCH] python/audit2allow: close file stream on error MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit sepolgen-ifgen-attr-helper.c: In function ‘load_policy’: sepolgen-ifgen-attr-helper.c:196:17: warning: leak of FILE ‘fp’ [CWE-775] [-Wanalyzer-file-leak] 196 | fprintf(stderr, "Out of memory!\n"); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Christian Göttsche Acked-by: James Carter --- python/audit2allow/sepolgen-ifgen-attr-helper.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/python/audit2allow/sepolgen-ifgen-attr-helper.c b/python/audit2allow/sepolgen-ifgen-attr-helper.c index 6f3ba962..5e6cffc1 100644 --- a/python/audit2allow/sepolgen-ifgen-attr-helper.c +++ b/python/audit2allow/sepolgen-ifgen-attr-helper.c @@ -194,12 +194,14 @@ static policydb_t *load_policy(const char *filename) policydb = malloc(sizeof(policydb_t)); if (policydb == NULL) { fprintf(stderr, "Out of memory!\n"); + fclose(fp); return NULL; } if (policydb_init(policydb)) { fprintf(stderr, "Out of memory!\n"); free(policydb); + fclose(fp); return NULL; } @@ -208,6 +210,7 @@ static policydb_t *load_policy(const char *filename) fprintf(stderr, "error(s) encountered while parsing configuration\n"); free(policydb); + fclose(fp); return NULL; }