From c046d974c5513c5bc1c29f964177e2fac4004544 Mon Sep 17 00:00:00 2001 From: Thomas Hurd Date: Thu, 19 Mar 2015 13:03:49 -0400 Subject: [PATCH] libsepol: bool_copy_callback set state on creation Boolean states are only written on a declaration. If a module is turned off which includes a tunable declaration that is required in another module, the state is never set. This patch sets the state when the booldatum is created so that an uninitialized memory read does not occur in cond_write_bool and write garbage to the link binary. This can cause a failure in cond_read_bool when running semodule_expand. Signed-off-by: Thomas Hurd --- libsepol/src/link.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libsepol/src/link.c b/libsepol/src/link.c index f98a8d26..f211164b 100644 --- a/libsepol/src/link.c +++ b/libsepol/src/link.c @@ -630,6 +630,7 @@ static int bool_copy_callback(hashtab_key_t key, hashtab_datum_t datum, state->base->p_bools.nprim++; base_bool = new_bool; base_bool->flags = booldatum->flags; + base_bool->state = booldatum->state; } else if ((booldatum->flags & COND_BOOL_FLAGS_TUNABLE) != (base_bool->flags & COND_BOOL_FLAGS_TUNABLE)) { /* A mismatch between boolean/tunable declaration