RepoMirrors/selinux
1
0
Fork 0
mirror of https://github.com/SELinuxProject/selinux synced 2025-02-11 15:17:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

libsemanage: semanage_seuser_key_create: copy name

Browse Source 
When removing a login using semanage with Python 3 the following error
occurs:

    # semanage login -l | grep my_user
    my_user                   user_u

    # semanage login --delete my_user
    ValueError: Login mapping for my_user is not defined

This is due to a use-after-free in the swig-generated code for python3
bindings.

Copy the user name in semanage_seuser_key_create() and free it in
semanage_seuser_key_free(), like commit eac6f1f1b5 ("libsepol:
sepol_{bool|iface|user}_key_create: copy name") did.

Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>
This commit is contained in:
Nicolas Iooss 2016-11-12 13:05:03 +01:00 committed by Stephen Smalley
parent bfe9360ca5
commit b372170058
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
libsemanage/src/seuser_record.c
View File

@ -33,7 +33,7 @@ struct semanage_seuser {
struct semanage_seuser_key {
/* This user's name */
const char *name;
char *name;
};
int semanage_seuser_key_create(semanage_handle_t * handle,
@ -48,7 +48,12 @@ int semanage_seuser_key_create(semanage_handle_t * handle,
ERR(handle, "out of memory, could not create seuser key");
return STATUS_ERR;
}
tmp_key->name = name;
tmp_key->name = strdup(name);
if (!tmp_key->name) {
ERR(handle, "out of memory, could not create seuser key");
free(tmp_key);
return STATUS_ERR;
}
*key_ptr = tmp_key;
return STATUS_SUCCESS;
@ -75,7 +80,7 @@ hidden_def(semanage_seuser_key_extract)
void semanage_seuser_key_free(semanage_seuser_key_t * key)
{
free(key->name);
free(key);
}