RepoMirrors
/
selinux
mirror of https://github.com/SELinuxProject/selinux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

checkpolicy/fuzz: drop redundant notdefined check 

The level_datum_t member notdefined is checked to be 1 during validation
and the fuzzer calls policydb_validate().
Drop the redundant check (as announced in the TODO).

Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
Acked-by: James Carter <jwcart2@gmail.com>
This commit is contained in:
Christian Göttsche 2024-03-11 15:57:02 +01:00 committed by James Carter
parent c205b924e2
commit b106fad29f
1 changed files with 0 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
checkpolicy/fuzz/checkpolicy-fuzzer.c
View File

@ -130,21 +130,6 @@ static int read_source_policy(policydb_t *p, const uint8_t *data, size_t size)
return 0; return 0;
} }
static int check_level(hashtab_key_t key, hashtab_datum_t datum, void *arg __attribute__ ((unused)))
{
const level_datum_t *levdatum = (level_datum_t *) datum;
// TODO: drop member defined if proven to be always set
if (!levdatum->isalias && levdatum->notdefined) {
fprintf(stderr,
"Error: sensitivity %s was not used in a level definition!\n",
key);
abort();
}
return 0;
}
static int write_binary_policy(FILE *outfp, policydb_t *p) static int write_binary_policy(FILE *outfp, policydb_t *p)
{ {
struct policy_file pf; struct policy_file pf;
@ -198,8 +183,6 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size)
if (read_source_policy(&parsepolicydb, data, size)) if (read_source_policy(&parsepolicydb, data, size))
goto exit; goto exit;
(void) hashtab_map(parsepolicydb.p_levels.table, check_level, NULL);
if (parsepolicydb.policy_type == POLICY_BASE) { if (parsepolicydb.policy_type == POLICY_BASE) {
if (link_modules(NULL, &parsepolicydb, NULL, 0, VERBOSE)) if (link_modules(NULL, &parsepolicydb, NULL, 0, VERBOSE))
goto exit; goto exit;