RepoMirrors/selinux
1
0
Fork 0
mirror of https://github.com/SELinuxProject/selinux synced 2025-04-17 04:40:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

libsepol: drop unnecessary const discarding casts

Browse Source 
`hashtab_search()` takes a const_hashtab_key_t, alias `const char*` as
second key parameter type.  Do not unnecessarily cast variables of type
`const char*` to hashtab_key_t, alias `char*`.

    policydb.c: In function ‘policydb_string_to_security_class’:
    policydb.c:4164:39: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
     4164 |                                       (hashtab_key_t) class_name);
          |                                       ^
    policydb.c: In function ‘policydb_string_to_av_perm’:
    policydb.c:4184:25: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
     4184 |                         (hashtab_key_t)perm_name);
          |                         ^
    policydb.c:4193:25: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
     4193 |                         (hashtab_key_t)perm_name);
          |                         ^

Acked-by: James Carter <jwcart2@gmail.com>
Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
This commit is contained in:
Christian Göttsche 2022-04-08 15:10:52 +02:00 committed by James Carter
parent 68a29c3aee
commit 9d57ab6c32
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libsepol/src/policydb.c
View File

@ -4160,7 +4160,7 @@ static sepol_security_class_t policydb_string_to_security_class(
class_datum_t *tclass_datum;
tclass_datum = hashtab_search(policydb->p_classes.table,
(hashtab_key_t) class_name);
class_name);
if (!tclass_datum)
return 0;
return tclass_datum->s.value;
@ -4180,7 +4180,7 @@ static sepol_access_vector_t policydb_string_to_av_perm(
perm_datum = (perm_datum_t *)
hashtab_search(tclass_datum->permissions.table,
(hashtab_key_t)perm_name);
perm_name);
if (perm_datum != NULL)
return UINT32_C(1) << (perm_datum->s.value - 1);
@ -4189,7 +4189,7 @@ static sepol_access_vector_t policydb_string_to_av_perm(
perm_datum = (perm_datum_t *)
hashtab_search(tclass_datum->comdatum->permissions.table,
(hashtab_key_t)perm_name);
perm_name);
if (perm_datum != NULL)
return UINT32_C(1) << (perm_datum->s.value - 1);