From 99170284ef3c8af273088f66f9a8e8462ec5a13c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20G=C3=B6ttsche?= Date: Fri, 5 Jan 2024 19:35:33 +0100 Subject: [PATCH] sandbox: do not override warning CFLAGS MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Do not unconditionally add warning flags and especially -Werror to CFLAGS, only when CFLAGS is empty. This helps when building with noisy warning flags, like -Weverything. Also drop -W, since it is an alias for -Wextra. Signed-off-by: Christian Göttsche Acked-by: James Carter --- sandbox/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sandbox/Makefile b/sandbox/Makefile index 360a8bc5..0799ab7c 100644 --- a/sandbox/Makefile +++ b/sandbox/Makefile @@ -8,7 +8,8 @@ BINDIR ?= $(PREFIX)/bin SBINDIR ?= $(PREFIX)/sbin MANDIR ?= $(PREFIX)/share/man SHAREDIR ?= $(PREFIX)/share/sandbox -override CFLAGS += -DPACKAGE="\"policycoreutils\"" -Wall -Werror -Wextra -W +CFLAGS ?= -Werror -Wall -Wextra +override CFLAGS += -DPACKAGE="\"policycoreutils\"" override LDLIBS += -lselinux -lcap-ng SEUNSHARE_OBJS = seunshare.o