From 933840af6c41ea0203485227c4ac2258f15d40f5 Mon Sep 17 00:00:00 2001 From: Eric Paris Date: Tue, 4 Dec 2012 15:23:57 -0500 Subject: [PATCH] libselinux: audit2why: make sure path is nul terminated We use strncpy which could leave a non-nul terminated string if the source is longer than PATH_MAX. Add that nul. Signed-off-by: Eric Paris Acked-by: Dan Walsh --- libselinux/src/audit2why.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libselinux/src/audit2why.c b/libselinux/src/audit2why.c index 02483a38..807bc42f 100644 --- a/libselinux/src/audit2why.c +++ b/libselinux/src/audit2why.c @@ -195,8 +195,9 @@ static int __policy_init(const char *init_path) int rc; unsigned int cnt; + path[PATH_MAX-1] = '\0'; if (init_path) { - strncpy(path, init_path, PATH_MAX); + strncpy(path, init_path, PATH_MAX-1); fp = fopen(path, "r"); if (!fp) { snprintf(errormsg, sizeof(errormsg),