RepoMirrors/selinux
1
0
Fork 0
mirror of https://github.com/SELinuxProject/selinux synced 2025-02-03 19:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

libsemanage: do not dereference a NULL pointer when calloc() fails

Browse Source 
If "names = calloc(num_modinfos, sizeof(*names))" fails in
semanage_get_cil_paths(), the function tries to frees items in array
"names" even though it is NULL. Avoid this by returning directly.

This issue has been found using clang's static analyzer.

Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>
This commit is contained in:
Nicolas Iooss 2017-03-28 23:41:51 +02:00 committed by James Carter
parent 0438d5c421
commit 85da6194ea
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libsemanage/src/semanage_store.c
View File

@ -1012,8 +1012,7 @@ int semanage_get_cil_paths(semanage_handle_t * sh,
names = calloc(num_modinfos, sizeof(*names)); names = calloc(num_modinfos, sizeof(*names));
if (names == NULL) { if (names == NULL) {
ERR(sh, "Error allocating space for filenames."); ERR(sh, "Error allocating space for filenames.");
status = -1; return -1;
goto cleanup;
} }
for (i = 0; i < num_modinfos; i++) { for (i = 0; i < num_modinfos; i++) {