RepoMirrors/selinux
1
0
Fork 0
mirror of https://github.com/SELinuxProject/selinux synced 2024-12-22 14:02:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

semodule_link: avoid NULL dereference on OOM

Browse Source 
In case the initial calloc(3) call fails the variable mods is still NULL
while its size hint num_mods is set.

Reported by Clang Analyzer:

    semodule_link.c:182:29: warning: Array access (from variable 'mods') results in a null pointer dereference [core.NullDereference]
      182 |                 sepol_module_package_free(mods[i]);
          |                                           ^~~~~~~

Fixes: 63e798a203 ("semodule_link: update")

Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
Acked-by: James Carter <jwcart2@gmail.com>
This commit is contained in:
Christian Göttsche 2023-11-09 14:53:11 +01:00 committed by James Carter
parent de491fda3d
commit 8547846ecd
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
semodule-utils/semodule_link/semodule_link.c
View File

@ -178,9 +178,11 @@ failure:
ret = EXIT_FAILURE;
cleanup:
for (i = 0; i < num_mods; i++)
sepol_module_package_free(mods[i]);
free(mods);
if (mods) {
for (i = 0; i < num_mods; i++)
sepol_module_package_free(mods[i]);
free(mods);
}
sepol_module_package_free(base);
return ret;