From 7eef9386c2f91b622121985482ad79e4e1f043b6 Mon Sep 17 00:00:00 2001 From: Nicolas Iooss Date: Wed, 26 Jun 2019 08:51:03 +0200 Subject: [PATCH] libsepol: initialize a local variable once Function optimize_cond_av_list() initializes its local variable pcov_cur twice. Remove the first initialization. This issue has been found using clang's static analyzer: https://282-118970575-gh.circle-artifacts.com/0/output-scan-build/2019-06-24-210510-6101-1/report-c64da3.html#EndPath Signed-off-by: Nicolas Iooss --- libsepol/src/optimize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libsepol/src/optimize.c b/libsepol/src/optimize.c index 3780b68b..10399a43 100644 --- a/libsepol/src/optimize.c +++ b/libsepol/src/optimize.c @@ -247,7 +247,7 @@ static void optimize_cond_av_list(cond_av_list_t **cond, cond_av_list_t **del, { cond_av_list_t **listp = cond; cond_av_list_t *pcov = NULL; - cond_av_list_t **pcov_cur = &pcov; + cond_av_list_t **pcov_cur; /* * Separate out all "potentially covering" rules (src or tgt is an attr)