RepoMirrors/selinux
1
0
Fork 0
mirror of https://github.com/SELinuxProject/selinux synced 2024-12-26 16:02:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Author: Daniel J Walsh

Browse Source 
Email: dwalsh@redhat.com
Subject: Fix memory leak on disabled selinux machines.
Date: Wed, 24 Feb 2010 14:15:31 -0500

I think this patch originally came from Eric Paris and was updated by
others but has not been adopted yet.  Not sure why.

Always free buf on exit.

Signed-off-by: Joshua Brindle <method@manicmethod.com>
This commit is contained in:
Daniel J Walsh 2010-02-28 17:54:18 -05:00 committed by Joshua Brindle
parent c8d100bb03
commit 660f70f4c4
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
libselinux/src/init.c
View File

@ -23,7 +23,7 @@ int obj_class_compat = 1;
static void init_selinuxmnt(void)
{
char *buf=NULL, *p;
FILE *fp;
FILE *fp=NULL;
struct statfs sfbuf;
int rc;
size_t len;
@ -57,16 +57,17 @@ static void init_selinuxmnt(void)
break;
}
}
fclose(fp);
if (!exists)
return;
if (!exists)
goto out;
fclose(fp);
/* At this point, the usual spot doesn't have an selinuxfs so
* we look around for it */
fp = fopen("/proc/mounts", "r");
if (!fp)
return;
goto out;
__fsetlocking(fp, FSETLOCKING_BYCALLER);
while ((num = getline(&buf, &len, fp)) != -1) {
@ -90,7 +91,8 @@ static void init_selinuxmnt(void)
out:
free(buf);
fclose(fp);
if (fp)
fclose(fp);
return;
}