From 4ad0abd983115bc04c8d8ad12a431cfeabc9555b Mon Sep 17 00:00:00 2001 From: Topi Miettinen Date: Fri, 15 May 2020 14:41:11 +0300 Subject: [PATCH] secilc/docs: fix use of TMPDIR Environment variable TMPDIR may be already set for the user building and this could be equal to $XDG_RUNTIME_DIR or /tmp which are existing directories. Then when running 'make clean', there are unintended side effects: rm -rf /run/user/1000 rm: cannot remove '/run/user/1000/dconf/user': Permission denied rm: cannot remove '/run/user/1000/systemd': Permission denied rm: cannot remove '/run/user/1000/gnupg': Permission denied rm: cannot remove '/run/user/1000/dbus-1': Is a directory rm: cannot remove '/run/user/1000/inaccessible': Permission denied make[1]: *** [Makefile:68: clean] Error 1 Fix by always setting the variable. Signed-off-by: Topi Miettinen Suggested-by: Petr Lautrbach Acked-by: Petr Lautrbach --- secilc/docs/Makefile | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/secilc/docs/Makefile b/secilc/docs/Makefile index 6b07ce7f..197ccef2 100644 --- a/secilc/docs/Makefile +++ b/secilc/docs/Makefile @@ -1,8 +1,8 @@ -CWD ?= $(shell pwd) -HTMLDIR ?= $(CWD)/html -PDFDIR ?= $(CWD)/pdf -TMPDIR ?= $(CWD)/tmp -TESTDIR ?= $(CWD)/../test +CWD = $(shell pwd) +HTMLDIR = $(CWD)/html +PDFDIR = $(CWD)/pdf +TMPDIR = $(CWD)/tmp +TESTDIR = $(CWD)/../test # All the markdown files that make up the guide: FILE_LIST ?= cil_introduction.md \