RepoMirrors/selinux
1
0
Fork 0
mirror of https://github.com/SELinuxProject/selinux synced 2025-01-20 12:30:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

checkpolicy: avoid assigning garbage values

Browse Source 
Only assign the computed value on success, since it is not set by
declare_symbol() on failure.

Reported by GCC:

    module_compiler.c: In function 'create_role':
    module_compiler.c:287:24: warning: use of uninitialized value 'value' [CWE-457] [-Wanalyzer-use-of-uninitialized-value]
      287 |         datum->s.value = value;
          |         ~~~~~~~~~~~~~~~^~~~~~~

Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
Acked-by: James Carter <jwcart2@gmail.com>
This commit is contained in:
Christian Göttsche 2024-01-22 14:55:06 +01:00 committed by James Carter
parent 63207ce82e
commit 22f7bb8c2a
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
checkpolicy/module_compiler.c
View File

@ -284,9 +284,8 @@ static int create_role(uint32_t scope, unsigned char isattr, role_datum_t **role
ret = require_symbol(SYM_ROLES, id, datum, &value, &value);
}
datum->s.value = value;
if (ret == 0) {
datum->s.value = value;
*role = datum;
*key = strdup(id);
if (*key == NULL) {
@ -303,6 +302,7 @@ static int create_role(uint32_t scope, unsigned char isattr, role_datum_t **role
free(datum);
return -1;
}
datum->s.value = value;
*role = datum;
*key = id;
} else {
@ -529,9 +529,8 @@ static int create_user(uint32_t scope, user_datum_t **user, char **key)
ret = require_symbol(SYM_USERS, id, datum, &value, &value);
}
datum->s.value = value;
if (ret == 0) {
datum->s.value = value;
*user = datum;
*key = strdup(id);
if (*key == NULL) {
@ -539,6 +538,7 @@ static int create_user(uint32_t scope, user_datum_t **user, char **key)
return -1;
}
} else if (ret == 1) {
datum->s.value = value;
*user = datum;
*key = id;
} else {