From 1ac883f1bf81de5bc88118d7db6bfe9c7d698a1d Mon Sep 17 00:00:00 2001 From: Alan Jenkins Date: Sun, 26 Mar 2017 17:22:44 +0100 Subject: [PATCH] policycoreutils/setfiles: don't scramble stdout and stderr together https://bugzilla.redhat.com/show_bug.cgi?id=1435894 When output to a non-tty (as caused by the implementation of fixfiles), stdout is fully buffered. stdout should be flushed before writes to stderr. See e.g. https://news.ycombinator.com/item?id=1271015 Signed-off-by: Alan Jenkins --- policycoreutils/setfiles/setfiles.c | 1 + 1 file changed, 1 insertion(+) diff --git a/policycoreutils/setfiles/setfiles.c b/policycoreutils/setfiles/setfiles.c index 83e0b2a0..bc83c27b 100644 --- a/policycoreutils/setfiles/setfiles.c +++ b/policycoreutils/setfiles/setfiles.c @@ -149,6 +149,7 @@ log_callback(int type, const char *fmt, ...) out = stdout; } else { out = stderr; + fflush(stdout); fprintf(out, "%s: ", r_opts.progname); } va_start(ap, fmt);