mirror of
https://github.com/prometheus/prometheus
synced 2024-12-27 17:13:22 +00:00
02c465bf58
* feat: initial implement of createedTimestamp() with tests Signed-off-by: Manik Rana <manikrana54@gmail.com> * feat: return ct after finding it Signed-off-by: Manik Rana <manikrana54@gmail.com> * chore: remove unneeded test Signed-off-by: Manik Rana <manikrana54@gmail.com> * chore: add comments Signed-off-by: Manik Rana <manikrana54@gmail.com> * feat: multiple changes - implement changes from pair programming session - use newParse.val() - advance parser p if ct is found Signed-off-by: Manik Rana <manikrana54@gmail.com> * fix: check if err from p.Next() Signed-off-by: Manik Rana <manikrana54@gmail.com> * feat: advance parser and parse histograms + summary Signed-off-by: Manik Rana <manikrana54@gmail.com> * fix: restore previous tests Signed-off-by: Manik Rana <manikrana54@gmail.com> * fix: retore failing tests Signed-off-by: Manik Rana <manikrana54@gmail.com> * chore: remove unneeded comments Signed-off-by: Manik Rana <manikrana54@gmail.com> * fix: return nil when mtype doesn't match Signed-off-by: Manik Rana <manikrana54@gmail.com> * chore: update go fmt version Signed-off-by: Manik Rana <manikrana54@gmail.com> * chore: cleanup Signed-off-by: Manik Rana <manikrana54@gmail.com> * fix: comments Signed-off-by: Manik Rana <manikrana54@gmail.com> * feat: document deepcopyparser Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com> Signed-off-by: Manik Rana <Manikrana54@gmail.com> Signed-off-by: Manik Rana <manikrana54@gmail.com> * chore: lint Signed-off-by: Manik Rana <manikrana54@gmail.com> * fix: cover edgecase of `gauge_created` in CreatedTimestamp() Signed-off-by: Manik Rana <manikrana54@gmail.com> * refac: readability updates Signed-off-by: Manik Rana <manikrana54@gmail.com> * refac: dedeuplicate labeldiff checks Signed-off-by: Manik Rana <manikrana54@gmail.com> * tests: add tests for new label functions Signed-off-by: Manik Rana <manikrana54@gmail.com> * feat: document CreatedTimestamp func Signed-off-by: Manik Rana <manikrana54@gmail.com> * refac: optimize `CreatedTimestamp()` - Use refactored CreatedTimestamp function with bug fixes - Remove unused code in labels.go - Improve code documentation Signed-off-by: Manik Rana <manikrana54@gmail.com> Signed-off-by: Manik Rana <manikrana54@gmail.com> * chore: add tests and lint fixes Signed-off-by: Manik Rana <manikrana54@gmail.com> * chore: remove mName Signed-off-by: Manik Rana <manikrana54@gmail.com> * chore: lint Signed-off-by: Manik Rana <manikrana54@gmail.com> * chore: comments Signed-off-by: Manik Rana <manikrana54@gmail.com> * tests: add tests for CT parse failures and deepCopy Signed-off-by: Manik Rana <manikrana54@gmail.com> * refac: edit expectCT struct Signed-off-by: Manik Rana <manikrana54@gmail.com> * chore: lint Signed-off-by: Manik Rana <manikrana54@gmail.com> * chore: add new label in deepCopy Signed-off-by: Manik Rana <manikrana54@gmail.com> * fix: use p.builder in deepCopy Signed-off-by: Manik Rana <manikrana54@gmail.com> * fix: add NewMetricsParserWithOpts Signed-off-by: Manik Rana <manikrana54@gmail.com> * chore: lint Signed-off-by: Manik Rana <manikrana54@gmail.com> * chore: comments Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com> Signed-off-by: Manik Rana <Manikrana54@gmail.com> * chore: comments Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com> Signed-off-by: Manik Rana <Manikrana54@gmail.com> * chore: rename var Signed-off-by: Manik Rana <manikrana54@gmail.com> * fix: add condition for OM fuzzing Signed-off-by: Manik Rana <manikrana54@gmail.com> * fix: build tags Signed-off-by: Manik Rana <manikrana54@gmail.com> * refac: default skipCT to false Signed-off-by: Manik Rana <manikrana54@gmail.com> * refac: rename skipCT to skipCTSeries Signed-off-by: Manik Rana <manikrana54@gmail.com> * chore: formatting Signed-off-by: Manik Rana <manikrana54@gmail.com> * chore: comments and readability updates Signed-off-by: Manik Rana <manikrana54@gmail.com> * chore: comments Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Manik Rana <Manikrana54@gmail.com> * refac: remove NewOpenMetricsParserWithOpts Signed-off-by: Manik Rana <manikrana54@gmail.com> * chore: lint Signed-off-by: Manik Rana <manikrana54@gmail.com> * refac: extract skipCTSeries logic from parseMetricSuffix Signed-off-by: Manik Rana <manikrana54@gmail.com> * refac: inline create a NewOpenMetricsParser Signed-off-by: Manik Rana <manikrana54@gmail.com> * chore: comments Signed-off-by: Manik Rana <manikrana54@gmail.com> * chore: comments Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Manik Rana <Manikrana54@gmail.com> * refac: improve error handling Signed-off-by: Manik Rana <manikrana54@gmail.com> * fix: return error instead of nil Signed-off-by: Manik Rana <manikrana54@gmail.com> * fix: remove skipCT check from tBraceOpen Signed-off-by: Manik Rana <manikrana54@gmail.com> * Pair programming with Manik, Arthur and Daniel. Signed-off-by: bwplotka <bwplotka@gmail.com> * chore: comments and use helper funcs Signed-off-by: Manik Rana <manikrana54@gmail.com> * chore: lint Signed-off-by: Manik Rana <manikrana54@gmail.com> --------- Signed-off-by: Manik Rana <manikrana54@gmail.com> Signed-off-by: Manik Rana <Manikrana54@gmail.com> Signed-off-by: bwplotka <bwplotka@gmail.com> Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com> Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
130 lines
3.6 KiB
Go
130 lines
3.6 KiB
Go
// Copyright 2015 The Prometheus Authors
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
// Only build when go-fuzz is in use
|
|
//go:build gofuzz
|
|
|
|
package promql
|
|
|
|
import (
|
|
"errors"
|
|
"io"
|
|
|
|
"github.com/prometheus/prometheus/model/labels"
|
|
"github.com/prometheus/prometheus/model/textparse"
|
|
"github.com/prometheus/prometheus/promql/parser"
|
|
)
|
|
|
|
// PromQL parser fuzzing instrumentation for use with
|
|
// https://github.com/dvyukov/go-fuzz.
|
|
//
|
|
// Fuzz each parser by building appropriately instrumented parser, ex.
|
|
// FuzzParseMetric and execute it with it's
|
|
//
|
|
// go-fuzz-build -func FuzzParseMetric -o FuzzParseMetric.zip github.com/prometheus/prometheus/promql
|
|
//
|
|
// And then run the tests with the appropriate inputs
|
|
//
|
|
// go-fuzz -bin FuzzParseMetric.zip -workdir fuzz-data/ParseMetric
|
|
//
|
|
// Further input samples should go in the folders fuzz-data/ParseMetric/corpus.
|
|
//
|
|
// Repeat for FuzzParseOpenMetric, FuzzParseMetricSelector and FuzzParseExpr.
|
|
|
|
// Tuning which value is returned from Fuzz*-functions has a strong influence
|
|
// on how quick the fuzzer converges on "interesting" cases. At least try
|
|
// switching between fuzzMeh (= included in corpus, but not a priority) and
|
|
// fuzzDiscard (=don't use this input for re-building later inputs) when
|
|
// experimenting.
|
|
const (
|
|
fuzzInteresting = 1
|
|
fuzzMeh = 0
|
|
fuzzDiscard = -1
|
|
|
|
// Input size above which we know that Prometheus would consume too much
|
|
// memory. The recommended way to deal with it is check input size.
|
|
// https://google.github.io/oss-fuzz/getting-started/new-project-guide/#input-size
|
|
maxInputSize = 10240
|
|
)
|
|
|
|
// Use package-scope symbol table to avoid memory allocation on every fuzzing operation.
|
|
var symbolTable = labels.NewSymbolTable()
|
|
|
|
func fuzzParseMetricWithContentType(in []byte, contentType string) int {
|
|
p, warning := textparse.New(in, contentType, false, symbolTable)
|
|
if warning != nil {
|
|
// An invalid content type is being passed, which should not happen
|
|
// in this context.
|
|
panic(warning)
|
|
}
|
|
|
|
if contentType == "application/openmetrics-text" {
|
|
p = textparse.NewOpenMetricsParser(in, symbolTable)
|
|
}
|
|
|
|
var err error
|
|
for {
|
|
_, err = p.Next()
|
|
if err != nil {
|
|
break
|
|
}
|
|
}
|
|
if errors.Is(err, io.EOF) {
|
|
err = nil
|
|
}
|
|
|
|
if err == nil {
|
|
return fuzzInteresting
|
|
}
|
|
|
|
return fuzzMeh
|
|
}
|
|
|
|
// Fuzz the metric parser.
|
|
//
|
|
// Note that this is not the parser for the text-based exposition-format; that
|
|
// lives in github.com/prometheus/client_golang/text.
|
|
func FuzzParseMetric(in []byte) int {
|
|
return fuzzParseMetricWithContentType(in, "")
|
|
}
|
|
|
|
func FuzzParseOpenMetric(in []byte) int {
|
|
return fuzzParseMetricWithContentType(in, "application/openmetrics-text")
|
|
}
|
|
|
|
// Fuzz the metric selector parser.
|
|
func FuzzParseMetricSelector(in []byte) int {
|
|
if len(in) > maxInputSize {
|
|
return fuzzMeh
|
|
}
|
|
_, err := parser.ParseMetricSelector(string(in))
|
|
if err == nil {
|
|
return fuzzInteresting
|
|
}
|
|
|
|
return fuzzMeh
|
|
}
|
|
|
|
// Fuzz the expression parser.
|
|
func FuzzParseExpr(in []byte) int {
|
|
if len(in) > maxInputSize {
|
|
return fuzzMeh
|
|
}
|
|
_, err := parser.ParseExpr(string(in))
|
|
if err == nil {
|
|
return fuzzInteresting
|
|
}
|
|
|
|
return fuzzMeh
|
|
}
|