beorn7 c3c7d44d84 lint: Adjust to the lint warnings raised by current versions of golint-ci ... We haven't updated golint-ci in our CI yet, but this commit prepares for that. There are a lot of new warnings, and it is mostly because the "revive" linter got updated. I agree with most of the new warnings, mostly around not naming unused function parameters (although it is justified in some cases for documentation purposes – while things like mocks are a good example where not naming the parameter is clearer). I'm pretty upset about the "empty block" warning to include `for` loops. It's such a common pattern to do something in the head of the `for` loop and then have an empty block. There is still an open issue about this: https://github.com/mgechev/revive/issues/810 I have disabled "revive" altogether in files where empty blocks are used excessively, and I have made the effort to add individual `// nolint:revive` where empty blocks are used just once or twice. It's borderline noisy, though, but let's go with it for now. I should mention that none of the "empty block" warnings for `for` loop bodies were legitimate. Signed-off-by: beorn7 <beorn@grafana.com>		2023-04-19 17:10:10 +02:00
..
dedupe_test.go	lint: Adjust to the lint warnings raised by current versions of golint-ci	2023-04-19 17:10:10 +02:00
dedupe.go
file_test.go
file.go	refactor (util): move from github.com/pkg/errors to 'errors' and 'fmt' (#10877)	2022-06-27 18:16:58 +02:00
ratelimit.go